From: "mrbff (Code Review)" Date: Tue, 20 May 2025 12:25:59 +0000 In-Reply-To: References: Reply-To: marco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: <2cad83c515c0c64d0a7f06e3df614e0450fe098e-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="fHZLi6PS5qM="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld , stipa Cc: openvpn-devel --fHZLi6PS5qM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mrbff, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=3Demail to look at the new patch set (#14). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied= now. Change subject: PUSH_UPDATE: Added remove_option() and do_update(). ...................................................................... PUSH_UPDATE: Added remove_option() and do_update(). * Added remove_option() function and some utility functions to remove optio= ns at runtime following the push-update logic. * Added do_update() function to close and reopen the tun and apply option u= pdates. Change-Id: I507180d7397b6959844a30908010132bc3411067 Signed-off-by: Marco Baffo --- M src/openvpn/init.c M src/openvpn/init.h M src/openvpn/multi.c M src/openvpn/options.c M src/openvpn/push.c M src/openvpn/route.c M src/openvpn/route.h 7 files changed, 373 insertions(+), 42 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/09/809/14 diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 9527429..d5bc630 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -2470,7 +2470,7 @@ if (pulled_options) { - if (!do_deferred_options(c, option_types_found)) + if (!do_deferred_options(c, option_types_found, false)) { msg(D_PUSH_ERRORS, "ERROR: Failed to apply push options"); return false; @@ -2594,6 +2594,55 @@ return true; } +bool +do_update(struct context *c, unsigned int option_types_found) +{ + /* Not necessary since to receive the update the openvpn + * instance must be up and running but just in case + */ + if (!c->c2.do_up_ran) + { + return false; + } + + bool tt_dco_win =3D tuntap_is_dco_win(c->c1.tuntap); + if (tt_dco_win) + { + msg(M_NONFATAL, "dco-win doesn't yet support reopening TUN device"= ); + return false; + } + + if (!do_deferred_options(c, option_types_found, true)) + { + msg(D_PUSH_ERRORS, "ERROR: Failed to apply push options"); + return false; + } + + do_close_tun(c, true); + + management_sleep(1); + int error_flags =3D 0; + c->c2.did_open_tun =3D do_open_tun(c, &error_flags); + update_time(); + + if (c->c2.did_open_tun) + { + /* if --route-delay was specified, start timer */ + if ((route_order(c->c1.tuntap) =3D=3D ROUTE_AFTER_TUN) && c->optio= ns.route_delay_defined) + { + event_timeout_init(&c->c2.route_wakeup, c->options.route_delay= , now); + event_timeout_init(&c->c2.route_wakeup_expire, c->options.rout= e_delay + c->options.route_delay_window, now); + tun_standby_init(c->c1.tuntap); + } + + initialization_sequence_completed(c, error_flags); + } + + CLEAR(c->c1.pulled_options_digest_save); + + return true; +} + /* * These are the option categories which will be accepted by pull. */ @@ -2672,11 +2721,8 @@ return true; } -/* - * Handle non-tun-related pulled options. - */ bool -do_deferred_options(struct context *c, const unsigned int found) +do_deferred_options(struct context *c, const unsigned int found, const boo= l is_update) { if (found & OPT_P_MESSAGES) { @@ -2784,7 +2830,7 @@ /* process (potentially) pushed options */ if (c->options.pull) { - if (!check_pull_client_ncp(c, found)) + if (!is_update && !check_pull_client_ncp(c, found)) { return false; } diff --git a/src/openvpn/init.h b/src/openvpn/init.h index 50b38e3..31b7b4c 100644 --- a/src/openvpn/init.h +++ b/src/openvpn/init.h @@ -86,13 +86,29 @@ bool pulled_options, unsigned int option_types_found); +/** + * @brief A simplified version of the do_up() function. This function is c= alled + * after receiving a successful PUSH_UPDATE message. It closes and = reopens + * the TUN device to apply the updated options. + * + * @param c The context structure. + * @param option_types_found The options found in the PUSH_UPDATE message. + * @return true on success. + * @return false on error. + */ +bool do_update(struct context *c, unsigned int option_types_found); + unsigned int pull_permission_mask(const struct context *c); const char *format_common_name(struct context *c, struct gc_arena *gc); void reset_coarse_timers(struct context *c); -bool do_deferred_options(struct context *c, const unsigned int found); +/* + * Handle non-tun-related pulled options. + * Set `is_update` param to true to skip NCP check. + */ +bool do_deferred_options(struct context *c, const unsigned int found, cons= t bool is_update); void inherit_context_child(struct context *dest, const struct context *src, diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 80dd0c0..be121c0 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -2425,7 +2425,7 @@ /* * Process sourced options. */ - do_deferred_options(&mi->context, option_types_found); + do_deferred_options(&mi->context, option_types_found, false); /* * make sure we got ifconfig settings from somewhere diff --git a/src/openvpn/options.c b/src/openvpn/options.c index b0dd825..33e1a61 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -1082,6 +1082,40 @@ gc_free(&gc); } } + +static void +delete_all_dhcp_fo(struct options *o, struct env_item **list) +{ + struct env_item *current, *prev; + + ASSERT(list); + + for (current =3D *list, prev =3D NULL; current !=3D NULL; current =3D = current->next) + { + char *tmp_value =3D NULL; + if (!strncmp(current->string, "foreign_option_", sizeof("foreign_o= ption_")-1)) + { + tmp_value =3D strchr(current->string, '=3D'); + if (tmp_value && ++tmp_value) + { + if (!strncmp(tmp_value, "dhcp-option ", sizeof("dhcp-optio= n ")-1)) + { + if (prev) + { + prev->next =3D current->next; + } + else + { + *list =3D current->next; + } + o->foreign_option_index--; + } + } + } + prev =3D current; + } +} + #endif /* ifndef _WIN32 */ static in_addr_t @@ -3222,8 +3256,16 @@ msg(M_INFO, "Flag 'def1' added to --redirect-gateway (iservice is = in use)"); opt->routes->flags |=3D RG_DEF1; } + else if (opt->routes + && ((opt->route_method !=3D ROUTE_METHOD_SERVICE) + || !(opt->routes->flags & RG_REROUTE_GW)) + && (opt->routes->flags & RG_DEF1)) + { + msg(M_INFO, "Flag 'def1' removed from --redirect-gateway"); + opt->routes->flags &=3D ~RG_DEF1; + } } -#endif +#endif /* ifdef _WIN32 */ /* * Save/Restore certain option defaults before --pull is applied. @@ -5372,37 +5414,6 @@ } } -void -options_server_import(struct options *o, - const char *filename, - int msglevel, - unsigned int permission_mask, - unsigned int *option_types_found, - struct env_set *es) -{ - msg(D_PUSH, "OPTIONS IMPORT: reading client specific options from: %s"= , filename); - read_config_file(o, - filename, - 0, - filename, - 0, - msglevel, - permission_mask, - option_types_found, - es); -} - -void -options_string_import(struct options *options, - const char *config, - const int msglevel, - const unsigned int permission_mask, - unsigned int *option_types_found, - struct env_set *es) -{ - read_config_string("[CONFIG-STRING]", options, config, msglevel, permi= ssion_mask, option_types_found, es); -} - #define VERIFY_PERMISSION(mask) { = \ if (!verify_permission(p[0], file, line, (mask), permission_mask, = \ option_types_found, msglevel, options, is_i= nline)) \ @@ -5505,6 +5516,198 @@ return options->forward_compatible ? M_WARN : msglevel; } +/** + * @brief Resets options found in the PUSH_UPDATE message that are precede= d by the `-` flag. + * This function is used in push-updates to reset specified options. + * The number of parameters `p` must always be 1. If the permission= is verified, + * all related options are erased or reset to their default values. + * Upon successful permission verification (by VERIFY_PERMISSION()), + * `option_types_found` is filled with the flag corresponding to th= e option. + * + * @param c The context structure. + * @param options A pointer to the options structure. + * @param p An array of strings containing the options and their parameter= s. + * @param is_inline A boolean indicating if the option is inline. + * @param file The file where the function is called. + * @param line The line number where the function is called. + * @param msglevel The message level. + * @param permission_mask The permission mask used by VERIFY_PERMISSION(). + * @param option_types_found A pointer to the variable where the flags cor= responding to the options found are stored. + * @param es The environment set structure. + */ +static void +remove_option(struct context *c, + struct options *options, + char *p[], + bool is_inline, + const char *file, + int line, + const int msglevel, + const unsigned int permission_mask, + unsigned int *option_types_found, + struct env_set *es) +{ + int msglevel_fc =3D msglevel_forward_compatible(options, msglevel); + + if (streq(p[0], "ifconfig") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_UP); + options->ifconfig_local =3D NULL; + options->ifconfig_remote_netmask =3D NULL; + } + else if (streq(p[0], "ifconfig-ipv6") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_UP); + options->ifconfig_ipv6_local =3D NULL; + options->ifconfig_ipv6_netbits =3D 0; + options->ifconfig_ipv6_remote =3D NULL; + } + else if (streq(p[0], "route") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_ROUTE); + if (c->c1.route_list) + { + delete_routes_v4(c->c1.route_list, c->c1.tuntap, + ROUTE_OPTION_FLAGS(&c->options), + es, &c->net_ctx); + if (options->routes) + { + options->routes->routes =3D NULL; + options->routes->flags =3D 0; + } + } + } + else if (streq(p[0], "route-ipv6") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_ROUTE); + if (c->c1.route_ipv6_list) + { + delete_routes_v6(c->c1.route_ipv6_list, c->c1.tuntap, + ROUTE_OPTION_FLAGS(&c->options), + es, &c->net_ctx); + if (options->routes_ipv6) + { + options->routes_ipv6->routes_ipv6 =3D NULL; + options->routes_ipv6->flags =3D 0; + } + } + } + else if (streq(p[0], "route-gateway") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_ROUTE_EXTRAS); + options->route_gateway_via_dhcp =3D false; + options->route_default_gateway =3D NULL; + } + else if (streq(p[0], "route-metric") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_ROUTE); + options->route_default_metric =3D 0; + } + else if (streq(p[0], "push-continuation") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_PULL_MODE); + options->push_continuation =3D 0; + } + else if ((streq(p[0], "redirect-gateway") || streq(p[0], "redirect-pri= vate")) && !p[1]) + { + VERIFY_PERMISSION(OPT_P_ROUTE); + if (options->routes) + { + options->routes->flags =3D 0; + } + if (options->routes_ipv6) + { + options->routes_ipv6->flags =3D 0; + } + } + else if (streq(p[0], "dns") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_DHCPDNS); + gc_free(&options->dns_options.gc); + CLEAR(options->dns_options); + } + else if (streq(p[0], "topology") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_UP); + options->topology =3D TOP_UNDEF; + helper_setdefault_topology(options); + } + else if (streq(p[0], "tun-mtu") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_PUSH_MTU|OPT_P_CONNECTION); + options->ce.tun_mtu =3D TUN_MTU_DEFAULT; + options->ce.tun_mtu_defined =3D false; + options->ce.occ_mtu =3D 0; + } + else if (streq(p[0], "block-ipv6") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_ROUTE); + options->block_ipv6 =3D false; + } +#if defined(_WIN32) || defined(TARGET_ANDROID) + else if (streq(p[0], "dhcp-option") && !p[1]) + { + struct tuntap_options *o =3D &options->tuntap_options; + VERIFY_PERMISSION(OPT_P_DHCPDNS); + + o->domain =3D NULL; + o->netbios_scope =3D NULL; + o->netbios_node_type =3D 0; + o->dns6_len =3D 0; + memset(o->dns6, 0, sizeof(o->dns6)); + o->dns_len =3D 0; + memset(o->dns, 0, sizeof(o->dns)); + o->wins_len =3D 0; + memset(o->wins, 0, sizeof(o->wins)); + o->ntp_len =3D 0; + memset(o->ntp, 0, sizeof(o->ntp)); + o->nbdd_len =3D 0; + memset(o->nbdd, 0, sizeof(o->nbdd)); + while (o->domain_search_list_len-- > 0) + { + o->domain_search_list[o->domain_search_list_len] =3D NULL; + } + o->disable_nbt =3D 0; + o->dhcp_options =3D 0; +#if defined(TARGET_ANDROID) + o->http_proxy_port =3D 0; + o->http_proxy =3D NULL; +#endif + } +#endif /* if defined(_WIN32) || defined(TARGET_ANDROID) */ +#ifdef _WIN32 + else if (streq(p[0], "block-outside-dns") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_DHCPDNS); + options->block_outside_dns =3D false; + } +#else /* ifdef _WIN32 */ + else if (streq(p[0], "dhcp-option") && !p[1]) + { + VERIFY_PERMISSION(OPT_P_DHCPDNS); + delete_all_dhcp_fo(options, &es->list); + } +#endif + else + { + int i; + int msglevel_unknown =3D msglevel_fc; + /* Check if an option is in --ignore-unknown-option and + * set warning level to non fatal */ + for (i =3D 0; options->ignore_unknown_option && options->ignore_un= known_option[i]; i++) + { + if (streq(p[0], options->ignore_unknown_option[i])) + { + msglevel_unknown =3D M_WARN; + break; + } + } + msg(msglevel_unknown, "Unrecognized option or missing or extra par= ameter(s) in %s:%d: -%s (%s)", file, line, p[0], PACKAGE_VERSION); + } + return; +err: + msg(msglevel, "Error occurred trying to remove %s option", p[0]); +} bool apply_push_options(struct context *c, struct options *options, @@ -5538,11 +5741,47 @@ add_option(options, p, false, file, line_num, 0, msglevel, permission_mask, option_types_found, es); } + else if (push_update_option_flags & PUSH_OPT_TO_REMOVE) + { + remove_option(c, options, p, false, file, line_num, msglev= el, + permission_mask, option_types_found, es); + } } } return true; } =20 +void +options_server_import(struct options *o, + const char *filename, + int msglevel, + unsigned int permission_mask, + unsigned int *option_types_found, + struct env_set *es) +{ + msg(D_PUSH, "OPTIONS IMPORT: reading client specific options from: %s"= , filename); + read_config_file(o, + filename, + 0, + filename, + 0, + msglevel, + permission_mask, + option_types_found, + es); +} + +void +options_string_import(struct options *options, + const char *config, + const int msglevel, + const unsigned int permission_mask, + unsigned int *option_types_found, + struct env_set *es) +{ + read_config_string("[CONFIG-STRING]", options, config, msglevel, permi= ssion_mask, option_types_found, es); +} + static void set_user_script(struct options *options, const char **script, diff --git a/src/openvpn/push.c b/src/openvpn/push.c index a40a28e..bad59a4 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -542,6 +542,11 @@ { msg(M_WARN, "No updatable options found in incoming PU= SH_UPDATE message"); } + else if (!do_update(c, option_types_found)) + { + msg(D_PUSH_ERRORS, "Failed to update options"); + goto error; + } } } event_timeout_clear(&c->c2.push_request_interval); diff --git a/src/openvpn/route.c b/src/openvpn/route.c index dbdc01d..bcff674 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1257,7 +1257,16 @@ const struct tuntap *tt, unsigned int flags, const struct env_set *es, openvpn_net_ctx_t *ctx) { - if (rl && rl->iflags & RL_ROUTES_ADDED) + delete_routes_v4(rl, tt, flags, es, ctx); + delete_routes_v6(rl6, tt, flags, es, ctx); +} + +void +delete_routes_v4(struct route_list *rl, const struct tuntap *tt, + unsigned int flags, const struct env_set *es, + openvpn_net_ctx_t *ctx) +{ + if (rl && (rl->iflags & RL_ROUTES_ADDED)) { struct route_ipv4 *r; for (r =3D rl->routes; r; r =3D r->next) @@ -1273,8 +1282,14 @@ { clear_route_list(rl); } +} - if (rl6 && (rl6->iflags & RL_ROUTES_ADDED) ) +void +delete_routes_v6(struct route_ipv6_list *rl6, const struct tuntap *tt, + unsigned int flags, const struct env_set *es, + openvpn_net_ctx_t *ctx) +{ + if (rl6 && (rl6->iflags & RL_ROUTES_ADDED)) { struct route_ipv6 *r6; for (r6 =3D rl6->routes_ipv6; r6; r6 =3D r6->next) diff --git a/src/openvpn/route.h b/src/openvpn/route.h index dda210a..adec67c 100644 --- a/src/openvpn/route.h +++ b/src/openvpn/route.h @@ -328,6 +328,16 @@ const struct env_set *es, openvpn_net_ctx_t *ctx); +void +delete_routes_v4(struct route_list *rl, const struct tuntap *tt, + unsigned int flags, const struct env_set *es, + openvpn_net_ctx_t *ctx); + +void +delete_routes_v6(struct route_ipv6_list *rl6, const struct tuntap *tt, + unsigned int flags, const struct env_set *es, + openvpn_net_ctx_t *ctx); + void setenv_routes(struct env_set *es, const struct route_list *rl); void setenv_routes_ipv6(struct env_set *es, const struct route_ipv6_list *= rl6); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067 Gerrit-Change-Number: 809 Gerrit-PatchSet: 14 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mrbff Gerrit-MessageType: newpatchset --fHZLi6PS5qM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mrbff, plaisthos. <= /p>

mrbff uploaded patch set #14 to this change.

View Change

The change is no longer submittable: checks~ChecksSubmitRule is un= satisfied now.

PUSH_UPDATE: Added remove_option() and do_update().

*= Added remove_option() function and some utility functions to remove option= s at
runtime following the push-update logic.
* Added do_update() f= unction to close and reopen the tun and apply option updates.

Change= -Id: I507180d7397b6959844a30908010132bc3411067
Signed-off-by: Marco Baff= o <marco@...2726...>
---
M src/openvpn/init.c
M src/openvpn/= init.h
M src/openvpn/multi.c
M src/openvpn/options.c
M src/openvpn= /push.c
M src/openvpn/route.c
M src/openvpn/route.h
7 files change= d, 373 insertions(+), 42 deletions(-)

git pull ssh://gerrit.openv=
pn.net:29418/openvpn refs/changes/09/809/14
diff --git a/src/openvp=
n/init.c b/src/openvpn/init.c
index 9527429..d5bc630 100644=
--- a/src/openvpn/init.c
+++ b/src/openvpn= /init.c
@@ -2470,7 +2470,7 @@

<= span> if (pulled_options)
{
- if (!do_deferred_options= (c, option_types_found))
+ if (!do_deferred_options(c, option_types_found, false))
{
msg(D_PUSH_ER= RORS, "ERROR: Failed to apply push options");
= return false;
@@ -2594,6 +2594,55 @@ return true;
}

+bool

+do_update(struct context *c, unsigned int optio= n_types_found)
+{
+ /* Not necessary si= nce to receive the update the openvpn
+ * instance must be up and running but just in case
+ */
+ if (!c->c2.do_up_ran)

+ {
+ return false;
+ }
+
+ bool tt_dco_win =3D tuntap_is_dco_win(c->c1.tuntap);+ if (tt_dco_win)+ {
+ msg(M_NONFATAL, "dco-win doe= sn't yet support reopening TUN device");
+ return false;
+ }
+
= + if (!do_deferred_options(c, option_types_found, true))
+ {
+ msg(D_PUSH_ERRORS, "ERROR: Failed to= apply push options");
+ return false;
+ }
+
+ do_close_tun(c, tru= e);
+
+ management_sleep(1);

= + int error_flags =3D 0;
+ c->c2.did_open_t= un =3D do_open_tun(c, &error_flags);
+ update_time();
+
= + if (c->c2.did_open_tun)
+ {
+ = /* if --route-delay was specified, start timer */
+ if ((route_order(c->c1.tunta= p) =3D=3D ROUTE_AFTER_TUN) && c->options.route_delay_defined)
+ {
+ event_timeout_init(&= amp;c->c2.route_wakeup, c->options.route_delay, now);

+ event_timeout_init(&= ;c->c2.route_wakeup_expire, c->options.route_delay + c->options.ro= ute_delay_window, now);

+ tun_standby_init(c->c1.tuntap);
+ }
+
+ initialization_sequence_completed(c, error_flags);
+ }
+
+ CLEAR(c->c1.pulled_options_digest_save);
+
+ return true;
+}
+
/*
* These are the option categories which = will be accepted by pull.
*/
@@ -2672,11 = +2721,8 @@
return true;
}
<= span>

-/*
- * Handle non-tun-related pulled o= ptions.
- */
= bool
-do_deferre= d_options(struct context *c, const unsigned int found)
+do_deferred_options(struct context *c, c= onst unsigned int found, const bool is_update)
{ if (found & OPT_P_MESSAGES)
{@@ -2784,7 +2830,7 @@
/* process (potentially)= pushed options */
if (c->options.pull)
<= span> {
- if= (!check_pull_client_ncp(c, found))
+ if (!is_update && !check_pull_client_ncp(c,= found))
{
return fal= se;
}
diff --git a/src/openvpn/ini= t.h b/src/openvpn/init.h
index 50b38e3..31b7b4c 100644

--- a/src/openvpn/init.h
+++ b/src/openvpn/init= .h
@@ -86,13 +86,29 @@
bool pul= led_options,
unsigned int option_types_found);<= /span>

+/*= *
+ * @brief A simpli= fied version of the do_up() function. This function is called
+ * after receiving a succe= ssful PUSH_UPDATE message. It closes and reopens

+ * the TUN device to apply the updated = options.
+ *+ * @param c The context stru= cture.
+ * @param opt= ion_types_found The options found in the PUSH_UPDATE message.
+ * @return true on success.

+ * @return false on error= .
+ */
+bool do_update(struct context *c, = unsigned int option_types_found);
+
unsigned int pull_permission_mask(const str= uct context *c);

const char *format_comm= on_name(struct context *c, struct gc_arena *gc);
void reset_coarse_timers(struct context *c);

-bool do_deferred_options(= struct context *c, const unsigned int found);
+/*
+ * Handle non-tun-related pulled options.
+ * Set `is_update` param to true to skip NCP= check.
+ */+bool do_deferred_options(str= uct context *c, const unsigned int found, const bool is_update);
=
void inherit_context_child(struct context *dest,
const struct context *src,
diff --git a/src/openvpn/multi.c b/src/openvpn/multi.cindex 80dd0c0..be121c0 100644
--- a/src/openvpn/mult= i.c
+++ b/src/openvpn/multi.c
@@ -2425,7 +2= 425,7 @@
/*
* Process sourced op= tions.
*/
- do_deferred_options(&mi->context, option_types_found);=
+ do_deferred_opt= ions(&mi->context, option_types_found, false);

/*
* make sure we got ifconfig sett= ings from somewhere
diff --git a/src/openvpn/options.c b/sr= c/openvpn/options.c
index b0dd825..33e1a61 100644--- a/src/openvpn/options.c
+++ b/src/openvpn/option= s.c
@@ -1082,6 +1082,40 @@
gc_free= (&gc);
}
}
+
+static void
+delete_all_dhcp_fo(struct options *o, struct env_item **list)=
+{
+ struct env_item *current, *prev;<= br>+
+ ASSERT(list);
+
+ for (current =3D *list, prev =3D NULL; current !=3D NULL; curre= nt =3D current->next)
+ {
+ c= har *tmp_value =3D NULL;
+ if (!strncmp(current->string, "foreign_option_", = sizeof("foreign_option_")-1))
+ {
+ tmp_value =3D strchr(current->string, '=3D'= ;);
+ if (= tmp_value && ++tmp_value)
+ {
+ if (!strncmp(tmp_value, "dhcp-option ", s= izeof("dhcp-option ")-1))
+ {
+ if (prev)
+ {
+ prev->next =3D current= ->next;
+ = }
+ = else
+ = {
+= *list =3D current->next;
+ }
+ o->foreign_optio= n_index--;
+ = }
+ = }
+ }<= br>+ prev =3D current;
+ }
+}

+
#endif /* ifndef _WIN32 */
static in_addr_t
@@ -3222,8 +325= 6,16 @@
msg(M_INFO, "Flag 'def1' adde= d to --redirect-gateway (iservice is in use)");
= opt->routes->flags |=3D RG_DEF1;
}
= + else if (opt->routes
+ &&= ; ((opt->route_method !=3D ROUTE_METHOD_SERVICE)
+ || !(opt->routes->= flags & RG_REROUTE_GW))
+ && (opt->routes->flags & RG_DEF1))
+ {
+ msg(M_INFO, "Flag '= ;def1' removed from --redirect-gateway");

+ opt->routes->flags &=3D ~R= G_DEF1;
+ }=
}
-#endif
+#endif /* ifdef _WIN32= */

/*
* Save/Restore = certain option defaults before --pull is applied.
@@ -5372,= 37 +5414,6 @@
}
}

-void
-options_server_import(struct options *o,=
- = const char *filename,
= - int msglevel,
- unsigned int permission_mask,- unsigned= int *option_types_found,
- struct env_set *es)
-{
- msg(D_PUSH, "OPTIONS IMPORT: reading client specific options f= rom: %s", filename);
- read_config_file(o,
- filename,
- 0,
- filename,
- 0,
- msglevel,
- permission_mask,<= /span>
- o= ption_types_found,
- = es);
= -}
-
-void
-options_string_import(struct options *options,
= - const char= *config,
- = const int msglevel,
- const unsigned int permission_mask,- unsigned = int *option_types_found,
-{
-}
-
#define VERIFY_PERMISSION(mask) { = \
if (!verify_permissio= n(p[0], file, line, (mask), permission_mask, \
= option_types_found, msglevel, options, is_inline= )) \
@@ -5505,6 +5516,198 @@
return op= tions->forward_compatible ? M_WARN : msglevel;
}=

+/**

+ * @brief Resets options= found in the PUSH_UPDATE message that are preceded by the `-` flag.=
+ * This function is= used in push-updates to reset specified options.
+ * The number of parameters `p` must a= lways be 1. If the permission is verified,
+ * all related options are erased or reset to= their default values.
+ * `optio= n_types_found` is filled with the flag corresponding to the option.<= br>+ *
+ * @param c The context structure.+ * @param options A pointer t= o the options structure.
+ * @param p An array of strings containing the options and their param= eters.
+ * @param is_= inline A boolean indicating if the option is inline.
+ * @param file The file where the functio= n is called.
+ * @par= am line The line number where the function is called.
+ * @param msglevel The message level.
+ * @param permission_ma= sk The permission mask used by VERIFY_PERMISSION().
+ * @param option_types_found A pointer to= the variable where the flags corresponding to the options found are stored= .
+ * @param es The e= nvironment set structure.
+ */
+static voi= d
+remove_option(stru= ct context *c,
+ = struct options *options,
+ char *p[],
+ bool is_inline,
+ const char *file,
+ int line,

= + const int msglev= el,
+ co= nst unsigned int permission_mask,
+ unsigned int *option_types_found,
+ struct env_set *es)=
+{
+ int msglevel_fc =3D msglevel_forw= ard_compatible(options, msglevel);
+
+ = if (streq(p[0], "ifconfig") && !p[1])
+ {
+ VERIFY_PERMISSION(OPT_P_UP);
+ options->ifconfig_local = =3D NULL;
+ op= tions->ifconfig_remote_netmask =3D NULL;
+ }
+ else if (streq(p[0], "ifconfig-ipv6") && !p= [1])
+ {+ VERIFY_PERMISSION(OPT= _P_UP);
+ opti= ons->ifconfig_ipv6_local =3D NULL;
+ options->ifconfig_ipv6_netbits =3D 0;+ options->ifconfig= _ipv6_remote =3D NULL;
+ else if= (streq(p[0], "route") && !p[1])
+ {
+ VERIFY_PERMISSION(OPT_P_ROUTE);
+ if (c->c1.route_list)
+ {
+ delete_routes_v4(c->= c1.route_list, c->c1.tuntap,

+ ROUTE_OPTION_FLAGS(&c->opti= ons),
+ = es, &c->net_ctx);
+ if (options->routes)
+ {
+ options->routes->routes= =3D NULL;
+ = options->routes->flags =3D 0;
+ }
+ }
+ }
+ els= e if (streq(p[0], "route-ipv6") && !p[1])
+ {
+ VERIFY_PERMISSION(OPT_P_ROUTE);+ if (c->c1.route_ip= v6_list)
+ {
+ delete_ro= utes_v6(c->c1.route_ipv6_list, c->c1.tuntap,
+ ROUTE_OPTION_FL= AGS(&c->options),
+ es, &c->net_ctx);
+ if (options->routes_i= pv6)
+ {
+ optio= ns->routes_ipv6->routes_ipv6 =3D NULL;
+ options->routes_ipv6->flags = =3D 0;
+ }=
+ }+ }
+ else if (streq(p[0], "route-gate= way") && !p[1])
+ {
+ = VERIFY_PERMISSION(OPT_P_ROUTE_EXTRAS);
+ options->route_gateway_via_dhcp =3D false;=
+ options->= ;route_default_gateway =3D NULL;
+ }
+ = else if (streq(p[0], "route-metric") && !p[1])<= br>+ {
+ VERIFY_PERMISSION(OPT_P_ROUTE);
+ options->r= oute_default_metric =3D 0;
+ }
+ els= e if (streq(p[0], "push-continuation") && !p[1])+ {
+ VERIFY_PERMISSION(OPT_P_PULL_MODE= );
+ options-&= gt;push_continuation =3D 0;
+ }
+ el= se if ((streq(p[0], "redirect-gateway") || streq(p[0], "redi= rect-private")) && !p[1])
+ {
+ VERIFY_PERMISSION(OPT_P_ROUTE);
+ if (options->routes)
+ {
+ options->routes->flags =3D 0;<= /span>
+ }
= + if (options->routes= _ipv6)
+ {

+ options->= ;routes_ipv6->flags =3D 0;
+ }
+= }
+ else if (s= treq(p[0], "dns") && !p[1])
+ {
+ VERIFY_PERMISSION(OPT_P_DHCPDNS);
+ gc_free(&options->dns_opti= ons.gc);
+ CLE= AR(options->dns_options);
+ }
+ e= lse if (streq(p[0], "topology") && !p[1])
+ {
+ VERIFY_PERMISSION(OPT_P_UP);
+ options->topology =3D= TOP_UNDEF;
+ = helper_setdefault_topology(options);
+ }
+ {
+ VERIFY_PERMISSION(OPT_P_PUSH_MTU|= OPT_P_CONNECTION);
+ = options->ce.tun_mtu =3D TUN_MTU_DEFAULT;
+ options->ce.tun_mtu_defined =3D f= alse;
+ option= s->ce.occ_mtu =3D 0;
+ }
+ else i= f (streq(p[0], "block-ipv6") && !p[1])
+ {
+ VERIFY_PERMISSION(OPT_P_ROUTE);
+ options->block_ipv6 = =3D false;
+ }
+#if defined(_WIN32) || = defined(TARGET_ANDROID)
+ else if (streq(p[0], "dhcp-option") && !p[1])
+ {
+ struct tuntap_options *o =3D = &options->tuntap_options;
+ VERIFY_PERMISSION(OPT_P_DHCPDNS);
+
+ o->domain =3D NULL;
+ o->netbios_scope =3D NULL;
= + o->netbios_node_typ= e =3D 0;
+ o-&= gt;dns6_len =3D 0;
+ = memset(o->dns6, 0, sizeof(o->dns6));
+ o->dns_len =3D 0;
+ memset(o->dns, 0, sizeof(= o->dns));
+ = o->wins_len =3D 0;
+ o->ntp_len =3D 0;
+ memset(o->ntp, 0, siz= eof(o->ntp));

+ = o->nbdd_len =3D 0;
+ memset(o->nbdd, 0, sizeof(o->nbdd));
+ while (o->domain_search_li= st_len-- > 0)
+ = {
+ o= ->domain_search_list[o->domain_search_list_len] =3D NULL;
<= span style=3D"color: hsl(120, 100%, 40%);">+ }

+ o->disable_nbt =3D 0;+ o->dhcp_options = =3D 0;
+#if defined(T= ARGET_ANDROID)
+ = o->http_proxy_port =3D 0;
+ o->http_proxy =3D NULL;
+#endif
+ }
+= #endif /* if defined(_WIN32) || defined(TARGET_ANDROID) */
+#ifdef _WIN32
+ else if (streq(p[0], "block-outs= ide-dns") && !p[1])
+ {
+ = VERIFY_PERMISSION(OPT_P_DHCPDNS);
+ options->block_outside_dns =3D false;

+ }
+#else /* ifdef _WIN32 */
+ else if (streq(p[0], "dhc= p-option") && !p[1])
+ {
+= VERIFY_PERMISSION(OPT_P_DHCPDNS);
+ delete_all_dhcp_fo(options, &es->list)= ;
+ }
+#endif
+ else
+ {
+ int i;
+= int msglevel_unknown =3D msglevel_fc;
+ /* Check if an option is in --ignore-unkn= own-option and
+ = * set warning level to non fatal */
+ for (i =3D 0; options->ignore_unknown_option= && options->ignore_unknown_option[i]; i++)
+ {
+ if (streq(p[0], options->ignore_unk= nown_option[i]))
+ = {
+ = msglevel_unknown =3D M_WARN;
+ break;
+ }
+ }
+ }
= + return;
+err:
+ msg(msglevel, "Error occurred trying to remo= ve %s option", p[0]);
+}
bool
apply_push_options(struct c= ontext *c,
struct options *options,
@@ -5538,11 +5741,47 @@
add_o= ption(options, p, false, file, line_num, 0, msglevel,
= permission_mask, option_types_found, es);
= }
= + else if (push_update_option_flags & PUSH_OPT_TO_REMOVE)

+ {+ remove_optio= n(c, options, p, false, file, line_num, msglevel,
+ permission_mask= , option_types_found, es);
+ }
}
}

return true;
}
+void
+options_server_import(struct options *o,<= /span>
+ = const char *filename,
+ int msglevel,
+ unsigned int permission_mask,
+ u= nsigned int *option_types_found,
+ struct env_set *es)
+{
+ msg(D_PUSH, "OPTIONS IMPORT: reading client speci= fic options from: %s", filename);
+ read_config_file(o,
+ filename,
+ 0,
+ filename,=
+ 0,
+ m= sglevel,
+ = permission_mask,
+ option_types_found,
+ es);
+}
+
+voi= d
+options_string_imp= ort(struct options *options,
+ const char *config,
+ const int msglevel,
+ = const unsigned int permission_mask,
+ unsigned int *option_types_found,
+ s= truct env_set *es)
+{=
+ read_config_str= ing("[CONFIG-STRING]", options, config, msglevel, permission_mask= , option_types_found, es);
+}
+
= static void
set_user_script(struct options *options= ,
const char **script,
dif= f --git a/src/openvpn/push.c b/src/openvpn/push.c
index a40= a28e..bad59a4 100644
--- a/src/openvpn/push.c
+++ b/src/openvpn/push.c

@@ -542,6 +542,11 @@
= {
msg(M_WARN, &= quot;No updatable options found in incoming PUSH_UPDATE message");
}
+ else if (!do_update(c, option_types_found))
+ {
+ msg(D= _PUSH_ERRORS, "Failed to update options");
+ goto error;+ }
<= span> }

}
eve= nt_timeout_clear(&c->c2.push_request_interval);
diff= --git a/src/openvpn/route.c b/src/openvpn/route.c
index db= dc01d..bcff674 100644
--- a/src/openvpn/route.c
<= span>+++ b/src/openvpn/route.c

@@ -1257,7 +1257,16 @@
const struct tuntap *tt, unsigned int flags,
const struct env_set *es, openvpn_net_ctx_t *ctx= )
{
- = if (rl && rl->iflags & RL_ROUTES_ADDED)
+ delete_routes_v4(rl, tt, flags, e= s, ctx);
+ delete_= routes_v6(rl6, tt, flags, es, ctx);
+}
+
+void
+delete_routes_v4(struct route_list *= rl, const struct tuntap *tt,
+ unsigned int flags, const struct env_set *es,
+ openvp= n_net_ctx_t *ctx)
+{<= /span>
+ if (rl &&= ; (rl->iflags & RL_ROUTES_ADDED))
{
<= span> struct route_ipv4 *r;

for (r =3D rl-= >routes; r; r =3D r->next)
@@ -1273,8 +1282,14 @@
{
clear_route_list(rl); }
+}

- if = (rl6 && (rl6->iflags & RL_ROUTES_ADDED) )
+void
+delete_routes_v6(struct route_ipv6_list *rl6, const s= truct tuntap *tt,
+ = unsigned int flags, const struct env_set *es,
+ openvpn_net_ctx_t= *ctx)

+{
<= span style=3D"color: hsl(120, 100%, 40%);">+ if (rl6 && (rl6->= ;iflags & RL_ROUTES_ADDED))

{
= struct route_ipv6 *r6;
for (r6 =3D rl6->ro= utes_ipv6; r6; r6 =3D r6->next)
diff --git a/src/openvpn= /route.h b/src/openvpn/route.h
index dda210a..adec67c 10064= 4
--- a/src/openvpn/route.h
+++ b/src/openv= pn/route.h
@@ -328,6 +328,16 @@
= const struct env_set *es,
open= vpn_net_ctx_t *ctx);

+void
+delete_routes_v4(struct route_list *rl, const struct tuntap *tt,=
+ unsigned = int flags, const struct env_set *es,
+ openvpn_net_ctx_t *ctx);
+
+void
+delete_routes_v6(struct route_ipv6_list *rl6, const struct tuntap *tt,=
+ un= signed int flags, const struct env_set *es,
+ openvpn_net_ctx_t *ctx);+
void setenv= _routes(struct env_set *es, const struct route_list *rl);
=
void setenv_routes_ipv6(struct env_set *es, const struct = route_ipv6_list *rl6);

To view, visit <= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/809?usp=3Demail">change 809= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I507180d7397b6959844a3090801= 0132bc3411067
Gerrit-Change-Number: 809
Gerrit-PatchSet: 14
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: mrbff <marco@...2726...&g= t;
Gerrit-MessageType: newpatchset
--fHZLi6PS5qM=--