From: Pierre-Louis Bossart Subject: Re: [PATCH] ASoC: Intel: boards: add dmic format constraint Date: Tue, 18 Jun 2019 11:44:30 +0200 Message-ID: <2cd4888f-7fd8-b177-4ad5-6dc953e5833c@linux.intel.com> References: <1560836926-27055-1-git-send-email-mac.chiang@intel.com> <5B37778DAAD9B04DA049B4A421B9B3EE71EB73A9@PGSMSX112.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9E189F89682 for ; Tue, 18 Jun 2019 11:44:34 +0200 (CEST) In-Reply-To: <5B37778DAAD9B04DA049B4A421B9B3EE71EB73A9@PGSMSX112.gar.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: "Chiang, Mac" , "alsa-devel@alsa-project.org" Cc: "N, Harshapriya" , "broonie@kernel.org" , "Zhi, Yong" List-Id: alsa-devel@alsa-project.org On 6/18/19 10:41 AM, Chiang, Mac wrote: >> Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. > Hi Pierre, this is for APL platform. ok. please don't top-post and copy/paste... > > -----Original Message----- > From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com] > Sent: Tuesday, June 18, 2019 2:56 PM > To: Chiang, Mac ; alsa-devel@alsa-project.org > Cc: N, Harshapriya ; broonie@kernel.org; Zhi, Yong > Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: boards: add dmic format constraint > > On 6/18/19 7:48 AM, mac.chiang@intel.com wrote: >> From: Mac Chiang >> >> platform dmic recording fixup 16bits > > Which platforms is this needed for? IIRC this machine driver is shared with SOF-based solutions - which typically sets DMIC configs with topology - and I'd like to make sure there's no impact. > Thanks! > >> >> Signed-off-by: Mac Chiang This change is only for front-ends that are overridden by SOF, so assuming the rest of the Chrome folks are aligned on this: Acked-by: Pierre-Louis Bossart >> --- >> sound/soc/intel/boards/bxt_da7219_max98357a.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/sound/soc/intel/boards/bxt_da7219_max98357a.c >> b/sound/soc/intel/boards/bxt_da7219_max98357a.c >> index 5cadb7f..ac06408 100644 >> --- a/sound/soc/intel/boards/bxt_da7219_max98357a.c >> +++ b/sound/soc/intel/boards/bxt_da7219_max98357a.c >> @@ -330,6 +330,9 @@ static int broxton_dmic_startup(struct snd_pcm_substream *substream) >> snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, >> &constraints_channels_quad); >> >> + runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; >> + snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16); >> + >> return snd_pcm_hw_constraint_list(substream->runtime, 0, >> SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); >> } >> > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel >