From: "cron2 (Code Review)" Date: Fri, 17 Jan 2025 10:38:37 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <2cff79b3a5145fc178ba4cdfb243069f2bdd308e-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="IRV+g6FyLzo="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and include po... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: plaisthos , flichtenheld , openvpn-devel --IRV+g6FyLzo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/870?usp=3Demail ) Change subject: IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and = include port when specified ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think the patch is fine, technically, but I've spent a bit of thought on = it, and want to suggest something else - in the MR_WITH_PORT case, use `"[%s]:%d"` - in the "naked IPv6 address" case, use `"%s"` only yes this is yet another extra `if()`, but my gut feeling is that it would = help readability - and for parsers, it should not matter much. If the pars= er expects to see a port, it will always be `[]`, so no variations. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/870?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia58cff107d14e29e51df0a988e8337cbb70ebfbb Gerrit-Change-Number: 870 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mrbff Gerrit-Comment-Date: Fri, 17 Jan 2025 10:38:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --IRV+g6FyLzo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mrbff, plaisthos. <= /p>

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #1:

      I think the patch is fine, technically, but I'= ve spent a bit of thought on it, and want to suggest something else

      - in t= he MR_WITH_PORT case, use `"[%s]:%d"`
      - in the "naked IP= v6 address" case, use `"%s"` only

      yes this is yet a= nother extra `if()`, but my gut feeling is that it would help readability -= and for parsers, it should not matter much. If the parser expects to see = a port, it will always be `[]`, so no variations.
=

To view, visit change 870. To unsubscribe, or for help writing mail filters,= visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia58cff107d14e29e51df0a988e8= 337cbb70ebfbb
Gerrit-Change-Number: 870
Gerrit-PatchSet: 1
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: mrbff <marco@...2726...&g= t;
Gerrit-Comment-Date: Fri, 17 Jan 2025 10:38:37= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--IRV+g6FyLzo=--