From: "its_Giaan (Code Review)" Date: Thu, 9 Jan 2025 13:50:19 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <2d183f4e1711b101f869147b7032078a412fcd74-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="uYQtlYRakC8="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move generic event handling code in dedicated files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , flichtenheld , plaisthos , openvpn-devel --uYQtlYRakC8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/763?usp=3Demail ) Change subject: multiproto: move generic event handling code in dedicated f= iles ...................................................................... Patch Set 11: (14 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/3cd77970_c262e6d2 : PS10, Line 4926: struct link_socket *sock) > I agree that we might want to make this uniform across the whole code - t= hat is, change all occurenc [=E2=80=A6] Done File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/8fab14f7_8836c8e6 : PS10, Line 165: multi_tcp_context(struct multi_context *m, struct multi_ins= tance *mi) > we lost the `inline` bit here by making it a global function. Maybe move= it to mtcp. [=E2=80=A6] made this static inline again and moved to multi_io.h where it gets used, a= lso renamed this 'multi_get_context' since it's what it does. File src/openvpn/mudp.h: http://gerrit.openvpn.net/c/openvpn/+/763/comment/1ee1261f_36899e3a : PS10, Line 66: struct = link_socket *sock); > see other comment, please move pure `ls/sock` renaming to a different pat= ch Done File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/8f0f41f9_ca89d73c : PS10, Line 189: struct link_socket *sock) > and here... without the renaming, there wouldn't be a change to `mudp. [= =E2=80=A6] Done File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/763/comment/18a4cbd0_54aa4b1c : PS10, Line 178: struct multi_protocol *multi_io; /**< State specifi= c to OpenVPN using TCP > If it's still `specific to TCP` (as the comment says), why rename it to `= multi_protocol`? This is c [=E2=80=A6] It gets used also by UDP, the comment was a leftover. http://gerrit.openvpn.net/c/openvpn/+/763/comment/048d18f2_978d730d : PS10, Line 280: struct link_so= cket *sock); > this Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/bd02fcba_e322ec4d : PS10, Line 295: struct link_socket *sock); > and that Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/9169a686_317e9b71 : PS10, Line 363: struct link_socket *sock); > and yet another one Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/763/comment/d56445cb_e795fd77 : PS10, Line 754: struct link_socket *sock) > another rename Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/a0585c59_7f074ee2 : PS10, Line 777: inherit_context_child(&mi->context, &m->top, sock); > and this Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/aa433935_03f4722e : PS10, Line 3129: struct link_socket *sock) > here Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/d202b209_59ae6a8b : PS10, Line 3185: mi->context.c2.link_sockets[0] =3D sock; > and there Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/78a7791f_6b0bda67 : PS10, Line 3335: const unsigned int mpp_flags, = struct link_socket *sock) > and here... Done http://gerrit.openvpn.net/c/openvpn/+/763/comment/4849bfa6_a38eaef1 : PS10, Line 3356: multi_set_pending(m, multi_get_create_instance_udp= (m, &floated, sock)); > this gets a bit boring Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/763?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1e5a84969988e4f027a18658d4ab268c13fbf929 Gerrit-Change-Number: 763 Gerrit-PatchSet: 11 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 09 Jan 2025 13:50:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --uYQtlYRakC8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

View C= hange

14 comments:

  • File src/openvpn/init.c:

  • File= src/openvpn/mtcp.c:

    • Patch Set #10, Line 165: multi_tcp_context(struct multi_context *m, struct multi_instance *mi)

      we lost the `inline` bit here by making it a global fu= nction. Maybe move it to mtcp. [=E2=80=A6]

      made this static inline again a= nd moved to multi_io.h where it gets used, also renamed this 'multi_get= _context' since it's what it does.

  • File src/openvpn/mudp.h:

    To view, visit change 763. To unsubscribe, or for help writing mail= filters, visit settings= .

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I1e5a84969988e4f027a18658d4a= b268c13fbf929
    Gerrit-Change-Number: 763
    Gerrit-PatchSet: 11
    Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: cron2 <gert@...1296...>= ;
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Thu, 09 Jan 2025 13:50:19= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: cron2 <gert@...1296...= >
    Gerrit-MessageType: comment
    --uYQtlYRakC8=--