From: Dinh Nguyen Date: Thu, 14 Feb 2019 09:37:13 -0600 Subject: [U-Boot] [PATCH] arm: socfpga: move gen5 SDR driver to DM In-Reply-To: References: <20190207212309.27559-1-simon.k.r.goldschmidt@gmail.com> Message-ID: <2d4a246d-87fa-f38d-4e70-97aec2211897@kernel.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On 2/9/19 4:01 AM, Marek Vasut wrote: > On 2/7/19 10:23 PM, Simon Goldschmidt wrote: >> To clean up reset handling for socfpga gen5, let's move the code snippet >> taking the DDR controller out of reset from SPL to the DDR driver. >> >> While at it, port the ddr driver to UCLASS_RAM and use dts. >> >> Signed-off-by: Simon Goldschmidt >> --- >> >> This is an RFC to show what the SDRAM driver moved to DM (UCLASS_RAM) would >> look like. It's RFC both because Dinh did not seem too fond of changing the >> register address of the SDR in devicetree to include what the undocumented >> registers 'sequencer.c' uses as well as because of my observed code growth. > > Dinh, if the SDRAM controller spans some addresses, it should be > described like so in the DT. Whether those registers are documented or > not does not matter, DT is a hardware description and should describe > hardware accurately. Yes, I agree with above statement. I'll wait for this patch to land here and will take the DTS patch to sync up Linux and U-Boot DTS. Dinh