From: =?UTF-8?Q?Nicolai_H=c3=a4hnle?= Subject: Re: [PATCH 1/2] drm/amdgpu: fix race in GEM VA map IOCTL Date: Mon, 30 Jan 2017 18:41:58 +0100 Message-ID: <2d7d579e-53be-30b2-30d6-4e4894edf0b0@gmail.com> References: <1485769533-2100-1-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1485769533-2100-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMzAuMDEuMjAxNyAxMDo0NSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBGcm9tOiBDaHJp c3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4KPiBTb21lYm9keSBjb3Vs ZCB0cnkgdG8gZnJlZSB0aGUgYm9fdmEgYmV0d2VlbiBtYXBwaW5nIGFuZCB1cGRhdGluZyBpdC4K Pgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1k LmNvbT4KCk5pY2UgY2F0Y2ghIEJvdGggcGF0Y2hlczoKClJldmlld2VkLWJ5OiBOaWNvbGFpIEjD pGhubGUgPG5pY29sYWkuaGFlaG5sZUBhbWQuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jIHwgNDUgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAzMSBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2Vt LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMKPiBpbmRleCA3YTI2 NWQ5Li5lYzViMTg0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nZW0u Ywo+IEBAIC00ODksNjcgKzQ4OSw1MCBAQCBzdGF0aWMgaW50IGFtZGdwdV9nZW1fdmFfY2hlY2so dm9pZCAqcGFyYW0sIHN0cnVjdCBhbWRncHVfYm8gKmJvKQo+ICAgKgo+ICAgKiBAYWRldjogYW1k Z3B1X2RldmljZSBwb2ludGVyCj4gICAqIEBib192YTogYm9fdmEgdG8gdXBkYXRlCj4gKyAqIEBs aXN0OiB2YWxpZGF0aW9uIGxpc3QKPiArICogb3ByYXRpb246IG1hcCBvciB1bm1hcAo+ICAgKgo+ ICAgKiBVcGRhdGUgdGhlIGJvX3ZhIGRpcmVjdGx5IGFmdGVyIHNldHRpbmcgaXQncyBhZGRyZXNz LiBFcnJvcnMgYXJlIG5vdAo+ICAgKiB2aXRhbCBoZXJlLCBzbyB0aGV5IGFyZSBub3QgcmVwb3J0 ZWQgYmFjayB0byB1c2Vyc3BhY2UuCj4gICAqLwo+ICBzdGF0aWMgdm9pZCBhbWRncHVfZ2VtX3Zh X3VwZGF0ZV92bShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCQkJCSAgICBzdHJ1Y3Qg YW1kZ3B1X2JvX3ZhICpib192YSwKPiArCQkJCSAgICBzdHJ1Y3QgbGlzdF9oZWFkICpsaXN0LAo+ ICAJCQkJICAgIHVpbnQzMl90IG9wZXJhdGlvbikKPiAgewo+IC0Jc3RydWN0IHR0bV92YWxpZGF0 ZV9idWZmZXIgdHYsICplbnRyeTsKPiAtCXN0cnVjdCBhbWRncHVfYm9fbGlzdF9lbnRyeSB2bV9w ZDsKPiAtCXN0cnVjdCB3d19hY3F1aXJlX2N0eCB0aWNrZXQ7Cj4gLQlzdHJ1Y3QgbGlzdF9oZWFk IGxpc3QsIGR1cGxpY2F0ZXM7Cj4gLQlpbnQgcjsKPiAtCj4gLQlJTklUX0xJU1RfSEVBRCgmbGlz dCk7Cj4gLQlJTklUX0xJU1RfSEVBRCgmZHVwbGljYXRlcyk7Cj4gLQo+IC0JdHYuYm8gPSAmYm9f dmEtPmJvLT50Ym87Cj4gLQl0di5zaGFyZWQgPSB0cnVlOwo+IC0JbGlzdF9hZGQoJnR2LmhlYWQs ICZsaXN0KTsKPiAtCj4gLQlhbWRncHVfdm1fZ2V0X3BkX2JvKGJvX3ZhLT52bSwgJmxpc3QsICZ2 bV9wZCk7Cj4gLQo+IC0JLyogUHJvdmlkZSBkdXBsaWNhdGVzIHRvIGF2b2lkIC1FQUxSRUFEWSAq Lwo+IC0JciA9IHR0bV9ldV9yZXNlcnZlX2J1ZmZlcnMoJnRpY2tldCwgJmxpc3QsIHRydWUsICZk dXBsaWNhdGVzKTsKPiAtCWlmIChyKQo+IC0JCWdvdG8gZXJyb3JfcHJpbnQ7Cj4gKwlzdHJ1Y3Qg dHRtX3ZhbGlkYXRlX2J1ZmZlciAqZW50cnk7Cj4gKwlpbnQgciA9IC1FUkVTVEFSVFNZUzsKPgo+ IC0JbGlzdF9mb3JfZWFjaF9lbnRyeShlbnRyeSwgJmxpc3QsIGhlYWQpIHsKPiArCWxpc3RfZm9y X2VhY2hfZW50cnkoZW50cnksIGxpc3QsIGhlYWQpIHsKPiAgCQlzdHJ1Y3QgYW1kZ3B1X2JvICpi byA9Cj4gIAkJCWNvbnRhaW5lcl9vZihlbnRyeS0+Ym8sIHN0cnVjdCBhbWRncHVfYm8sIHRibyk7 Cj4KPiAgCQkvKiBpZiBhbnl0aGluZyBpcyBzd2FwcGVkIG91dCBkb24ndCBzd2FwIGl0IGluIGhl cmUsCj4gIAkJICAganVzdCBhYm9ydCBhbmQgd2FpdCBmb3IgdGhlIG5leHQgQ1MgKi8KPiAgCQlp ZiAoIWFtZGdwdV9ib19ncHVfYWNjZXNzaWJsZShibykpCj4gLQkJCWdvdG8gZXJyb3JfdW5yZXNl cnZlOwo+ICsJCQlnb3RvIGVycm9yOwo+Cj4gIAkJaWYgKGJvLT5zaGFkb3cgJiYgIWFtZGdwdV9i b19ncHVfYWNjZXNzaWJsZShiby0+c2hhZG93KSkKPiAtCQkJZ290byBlcnJvcl91bnJlc2VydmU7 Cj4gKwkJCWdvdG8gZXJyb3I7Cj4gIAl9Cj4KPiAgCXIgPSBhbWRncHVfdm1fdmFsaWRhdGVfcHRf Ym9zKGFkZXYsIGJvX3ZhLT52bSwgYW1kZ3B1X2dlbV92YV9jaGVjaywKPiAgCQkJCSAgICAgIE5V TEwpOwo+ICAJaWYgKHIpCj4gLQkJZ290byBlcnJvcl91bnJlc2VydmU7Cj4gKwkJZ290byBlcnJv cjsKPgo+ICAJciA9IGFtZGdwdV92bV91cGRhdGVfcGFnZV9kaXJlY3RvcnkoYWRldiwgYm9fdmEt PnZtKTsKPiAgCWlmIChyKQo+IC0JCWdvdG8gZXJyb3JfdW5yZXNlcnZlOwo+ICsJCWdvdG8gZXJy b3I7Cj4KPiAgCXIgPSBhbWRncHVfdm1fY2xlYXJfZnJlZWQoYWRldiwgYm9fdmEtPnZtKTsKPiAg CWlmIChyKQo+IC0JCWdvdG8gZXJyb3JfdW5yZXNlcnZlOwo+ICsJCWdvdG8gZXJyb3I7Cj4KPiAg CWlmIChvcGVyYXRpb24gPT0gQU1ER1BVX1ZBX09QX01BUCkKPiAgCQlyID0gYW1kZ3B1X3ZtX2Jv X3VwZGF0ZShhZGV2LCBib192YSwgZmFsc2UpOwo+Cj4gLWVycm9yX3VucmVzZXJ2ZToKPiAtCXR0 bV9ldV9iYWNrb2ZmX3Jlc2VydmF0aW9uKCZ0aWNrZXQsICZsaXN0KTsKPiAtCj4gLWVycm9yX3By aW50Ogo+ICtlcnJvcjoKPiAgCWlmIChyICYmIHIgIT0gLUVSRVNUQVJUU1lTKQo+ICAJCURSTV9F UlJPUigiQ291bGRuJ3QgdXBkYXRlIEJPX1ZBICglZClcbiIsIHIpOwo+ICB9Cj4gQEAgLTY0Miwx MCArNjI1LDEwIEBAIGludCBhbWRncHVfZ2VtX3ZhX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsCj4gIAlkZWZhdWx0Ogo+ICAJCWJyZWFrOwo+ICAJfQo+IC0JdHRtX2V1 X2JhY2tvZmZfcmVzZXJ2YXRpb24oJnRpY2tldCwgJmxpc3QpOwo+ICAJaWYgKCFyICYmICEoYXJn cy0+ZmxhZ3MgJiBBTURHUFVfVk1fREVMQVlfVVBEQVRFKSAmJgo+ICAJICAgICFhbWRncHVfdm1f ZGVidWcpCj4gLQkJYW1kZ3B1X2dlbV92YV91cGRhdGVfdm0oYWRldiwgYm9fdmEsIGFyZ3MtPm9w ZXJhdGlvbik7Cj4gKwkJYW1kZ3B1X2dlbV92YV91cGRhdGVfdm0oYWRldiwgYm9fdmEsICZsaXN0 LCBhcmdzLT5vcGVyYXRpb24pOwo+ICsJdHRtX2V1X2JhY2tvZmZfcmVzZXJ2YXRpb24oJnRpY2tl dCwgJmxpc3QpOwo+Cj4gIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZV91bmxvY2tlZChnb2Jq KTsKPiAgCXJldHVybiByOwo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngK