Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oMCJP-0006Au-1z for mharc-grub-devel@gnu.org; Thu, 11 Aug 2022 13:49:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMCJN-00066z-Ir for grub-devel@gnu.org; Thu, 11 Aug 2022 13:49:37 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:34558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMCJK-0005nY-Ro for grub-devel@gnu.org; Thu, 11 Aug 2022 13:49:37 -0400 Received: by mail-qv1-xf30.google.com with SMTP id u8so13892366qvv.1 for ; Thu, 11 Aug 2022 10:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=rWSeDPOMKIuoa8ueZJfLEACshHVqa+7DpeWXExkQWSg=; b=qP0nMt1YpZqGNZEh6ABveHjVATx6LZQQAW99gPPn9xjMObO7wmlhXzDpgyCKHbJLX+ R1w0+z26ZLKOr4so5WfV8NSJ2EDTF4OU51cTaTB1BTx5yvYl9zSBA/oOoRjrq66NedMQ Wa60dCBqbb44hjH8zainELh+u8fAU0ubVFhpS+nDtESpDniLSG59ISeZR4YW5YEi6wtG UMCQe0wmLoEXdS4KNnWWkqq0SfSSnvIMX7SNgacumhZDoZpfokP0FXrffzy5eznDTESr V1pWYwBfGNPjDgsd+tuZh+BWvJb7moRTY7Z5RJCr+dHJ/dXa9ferojWQUXtfwa1mvk+h yXIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=rWSeDPOMKIuoa8ueZJfLEACshHVqa+7DpeWXExkQWSg=; b=5DylItGFtOlkMyCO4Ob7ogkpmTmofJqkA5lFHnqTAYb24bDsJ/Y71zznc0mD345wNe /T0ZhDlbZXu/pbHlErEVvR6j6qNMZiS5T8mXdTFY/L52pShJFgPN/tyaeNGm7q8CpWb8 tEzTMZEO+nJPW27ejyoP2F8tjmB7+ckIZokpl4marGTmc/JgmhO6m+d3yFxJtiQ+4yAD xkZousDGo8JRR7QM3GABnk7zugiRAyTjKJtGxll6hmt2afkaYeD/jWicrvM44GLhr0os /g2GQLKLRl17jumFFgqyCmDSBWI7amE5MQDHKoGlZB3oh8zbkAy+O0AesXGnvmBtE1vx R/Ow== X-Gm-Message-State: ACgBeo0AX5CIaiOmw+8f3tsSFlROAuBrpwP1qayISinditF1EEr19w+A u8Aq22ErTdvxNaL7xpQKSuf1UWqhyXEzD+QF X-Google-Smtp-Source: AA6agR7okqru/yUNpcYhI4/czY7LVhhWKplucWA8CZSUApZrEPkA1oEtmFwMkpvd3SSKfZ7bnfIxuA== X-Received: by 2002:a05:6214:1c8c:b0:473:408f:ddd6 with SMTP id ib12-20020a0562141c8c00b00473408fddd6mr277772qvb.74.1660240172821; Thu, 11 Aug 2022 10:49:32 -0700 (PDT) Received: from localhost.localdomain ([199.58.83.12]) by smtp.gmail.com with ESMTPSA id s11-20020a05620a0bcb00b006b5c061844fsm2584657qki.49.2022.08.11.10.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 10:49:32 -0700 (PDT) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Patrick Steinhardt , Glenn Washburn Subject: [PATCH v5 1/2] misc: Add cast in grub_strncasecmp() to drop sign when calling grub_tolower() Date: Thu, 11 Aug 2022 12:48:42 -0500 Message-Id: <2e1f2bb38b3525373c8ac84c32e8de47c315ef70.1659560233.git.development@efficientek.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f30; envelope-from=development@efficientek.com; helo=mail-qv1-xf30.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2022 17:49:38 -0000 Note this cast was fixed in grub_strcasecmp() in commit ce41ab7aab (* grub-core/kern/misc.c (grub_strcmp): Use unsigned comparison as per common usage and preffered in several parts of code.), but this commit omitted fixing it in grub_strncasecmp(). Signed-off-by: Glenn Washburn --- include/grub/misc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/grub/misc.h b/include/grub/misc.h index 776dbf8af..1c25c1767 100644 --- a/include/grub/misc.h +++ b/include/grub/misc.h @@ -232,7 +232,8 @@ grub_strncasecmp (const char *s1, const char *s2, grub_size_t n) while (*s1 && *s2 && --n) { - if (grub_tolower (*s1) != grub_tolower (*s2)) + if (grub_tolower ((grub_uint8_t) *s1) + != grub_tolower ((grub_uint8_t) *s2)) break; s1++; -- 2.34.1