From: "flichtenheld (Code Review)" Date: Wed, 20 Dec 2023 11:57:07 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <2e3e89e8b8455f9fd6874e83aa986000f06d3736-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="G46NY3FXThM="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: cron2 , openvpn-devel --G46NY3FXThM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/466?usp=3Demail ) Change subject: Implement the --tls-export-cert feature ...................................................................... Patch Set 6: -Code-Review (1 comment) File src/openvpn/ssl_verify.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/2e6bc2d2_f0a6cbd6 : PS6, Line 734: if (opt->export_peer_cert_dir) > Something is not right here. [=E2=80=A6] So I tried to understand why it seemed to work in my testing. It turns out = that I only ever looked at the cert indicated by $depth argument to the hoo= k. So indeed all the certs are exported correctly, but the problem is that = after the depth 1 hook is run the file indicated by peer_cert_1 is deleted = already. So the behavior is not very useful. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 6 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Wed, 20 Dec 2023 11:57:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --G46NY3FXThM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, plaisthos.

Patch set 6:-Code-Review

<= p>View Ch= ange

1 comment:

    File src/openvpn/ssl_verify.c:

  • Patch Set #6, Line 734: if (opt->export_p= eer_cert_dir)

    Something is not right here. [=E2=80=A6= ]

    change 466. To unsubscribe, or for help writing mail filters, visit= settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b= 4cebd0bf19ce2
    Gerrit-Change-Number: 466
    Gerrit-PatchSet: 6
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: cron2 <gert@...1296...>= ;
    Gerrit-Comment-Date: Wed, 20 Dec 2023 11:57:07= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: cron2 <gert@...1296...= >
    Gerrit-MessageType: comment
    --G46NY3FXThM=--