Message-ID: <2e42dffe-ebbe-bf6c-95e3-aa5c7d7eac9a@...1227...> Date: Thu, 28 Jul 2022 14:46:46 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220728034508.15180-1-selva.nair@...277...> From: Arne Schwabe In-Reply-To: <20220728034508.15180-1-selva.nair@...277...> Subject: Re: [Openvpn-devel] [PATCH 1/2] Do not skip ERROR:/SUCCESS: response from management interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: selva.nair@...277..., openvpn-devel@lists.sourceforge.net Am 28.07.22 um 05:45 schrieb selva.nair@...277...: > From: Selva Nair > > Generally we expect a response of SUCCESS: or ERROR: to every > command sent to the management interface. But, while in > the management-hold state, sending "signal foo" returns only > the following reply (with foo = SIGHUP, SIGUSR1 etc.): > >> HOLD:Waiting for hold release:0 > > Fix by always responding > > ERROR: signal 'foo' is currently ignored" > followed by the above line. > > Though this is seldom seen in practice[*], such violation of the > protocol could stall clients like the GUI. So fix it. > > [*] One way this happens is with SIGHUP sent before the daemon > is on hold state which it enters before the SIGHUP is received. > Acked-By: Arne Schwabe