From: "flichtenheld (Code Review)" Date: Tue, 21 Jan 2025 14:53:17 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <2e552775d2fd1b6c07bd90a3d4dd765fee2e810e-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="TnWVor3DcE4="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Print warnings/errors when numerical parameters cannot be parsed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --TnWVor3DcE4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/873?usp=3Demail ) Change subject: Print warnings/errors when numerical parameters cannot be p= arsed ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: LGTM, but would be a good opportunity to move the code to options_util.c an= d add unittests? File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/873/comment/299b83cd_d792bac7 : PS1, Line 4939: if (i < 0 || endptr || i > INT_MAX) > Should probably be *endptr? Basically we want to check that it is \0, rig= ht? [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/873?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de Gerrit-Change-Number: 873 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 21 Jan 2025 14:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --TnWVor3DcE4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 2:Code-Review -1=

Vi= ew Change

2 comments:

  • Patchset:

    • Patch Set #2:

      LGTM, but would be a good opportunity to move= the code to options_util.c and add unittests?

  • File src/openvpn/options.c:

    • Patch Set #1, Line 4939: if (i < 0 || endptr || i &= gt; INT_MAX)

      Should probably be *endptr? Basically we= want to check that it is \0, right? [=E2=80=A6]

      Done

  • <= /ul>

    To view, visit change 873. To unsubscribe, or for help writing mail filte= rs, visit settings.

    <= div itemscope itemtype=3D"http://schema.org/EmailMessage">
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8= edd77ee2be4de
    Gerrit-Change-Number: 873
    Gerrit-PatchSet: 2
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Tue, 21 Jan 2025 14:53:17= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
    Gerrit-MessageType: comment
    --TnWVor3DcE4=--