Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nRhGO-0006Dw-8A for mharc-grub-devel@gnu.org; Tue, 08 Mar 2022 16:21:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRhGM-00066x-2T for grub-devel@gnu.org; Tue, 08 Mar 2022 16:20:58 -0500 Received: from [2607:f8b0:4864:20::82a] (port=44836 helo=mail-qt1-x82a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRhGK-0006f9-JO for grub-devel@gnu.org; Tue, 08 Mar 2022 16:20:57 -0500 Received: by mail-qt1-x82a.google.com with SMTP id v3so257442qta.11 for ; Tue, 08 Mar 2022 13:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iKul1hgPOSpyFjaC+oM6uqaGhCKDwHyJHQVgrklyeiE=; b=yGz8naXryDF5P01x56HUI4nsegDZr2aR8bkioknhP0Q1lRQSuE84ybo72JSJZ2Pqfj CmaMrtW9J3KK40xJ3CJozHYjNV+v1WTAzk0HXbxTFb7Y434j4GkEhhMfOZIpD0SHQHT1 NXo2k1mU7WK2giEwME3BeoEz9OGfFaP9EL1YgUalYAtREa1kjPUDioq2QOyyAl7ab9nd 7nXcJyZ8AG66XJBaGX6XunJ5eCxr/aJWEDBjXkR0XW+wqii42TM+8AjdpQXGK7vtcaPG d+CBI6F8PkQofvFAHzCnCFdsToCH3cdq5RG/Af1cTvxmVy9UfLsET9Y0tRWsEFyJCkzP Rfsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iKul1hgPOSpyFjaC+oM6uqaGhCKDwHyJHQVgrklyeiE=; b=iwwLsJzPPKU4KZxpsXBMD/NqG0ViQJghFHiTbuoieBHpyGpAV6G5zeKa4CGNO5z0Hs OL0VJmQfH30jUKxcvD/QTDMoM9Jjbe+eV9uCTkTeu/0yOffIGRXC3tQ8lWzJsjLsky/k dUezsN1n1gtqI8usj9E9/IpYAq2FcYnxoW9eMoVV6zbLL94ExPuhyObqLiH4CrphZkhn QQoD5fkaBxXWqb0Y0ShI2xSu30jvNPEwTiskvyb+NLFL0aKMcNN4WpF0/W7KXAXZ00f1 YFfkocn8AHN4uqgS3L8COeBY63inkUUZiRKKA6m+bhq3TzJ/TQQragHFX2Yh0Z40EzkJ XLjA== X-Gm-Message-State: AOAM5312zWG8N9gPxf2lxIbY7BRPk1EjZV/CI+y3l7hxgxrOhOX4MaN8 f5fiwTC4iHJGgtymGcP4OLAkNA== X-Google-Smtp-Source: ABdhPJyGTIlVSj4I//jpZbvlEEMDImHKjonuWW6zOErgNXcn6cW9965gBmafTCJZY5OvqpDHNLkPLQ== X-Received: by 2002:ac8:7f51:0:b0:2dd:dbca:1f40 with SMTP id g17-20020ac87f51000000b002dddbca1f40mr14954646qtk.463.1646774455634; Tue, 08 Mar 2022 13:20:55 -0800 (PST) Received: from localhost.localdomain (garza.riseup.net. [198.252.153.109]) by smtp.gmail.com with ESMTPSA id w17-20020ac857d1000000b002e19feda592sm38088qta.85.2022.03.08.13.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 13:20:55 -0800 (PST) From: Glenn Washburn To: Daniel Kiper , grub-devel@gnu.org Cc: Glenn Washburn Subject: [PATCH 2/3] net: Avoid unnecessary calls to grub_net_tcp_retransmit Date: Tue, 8 Mar 2022 15:20:19 -0600 Message-Id: <2e55f210c74f37f998f320060194efe223a3a529.1646679955.git.development@efficientek.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::82a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::82a; envelope-from=development@efficientek.com; helo=mail-qt1-x82a.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 21:20:58 -0000 In grub_net_poll_cards_idle_real, only call grub_net_tcp_retransmit if there are network cards found. If there are no network card found, there can be no tcp sockets to transmit on. Signed-off-by: Glenn Washburn --- grub-core/net/net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grub-core/net/net.c b/grub-core/net/net.c index 563dea9ec8..e208b84019 100644 --- a/grub-core/net/net.c +++ b/grub-core/net/net.c @@ -1580,7 +1580,8 @@ grub_net_poll_cards_idle_real (void) || ctime >= card->last_poll + card->idle_poll_delay_ms) receive_packets (card, 0); } - grub_net_tcp_retransmit (); + if (grub_net_cards) + grub_net_tcp_retransmit (); } /* Read from the packets list*/ -- 2.27.0