From: Michel Thierry Subject: Re: [PATCH 4/9] drm/i915/tdr: Add support for per engine reset recovery Date: Sun, 18 Dec 2016 21:02:33 -0800 Message-ID: <2e64469d-2db6-7f17-e76c-baf788f9c1a8@intel.com> References: <20161216202010.7983-1-michel.thierry@intel.com> <20161216202010.7983-5-michel.thierry@intel.com> <20161216204521.GG29871@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 341306E3A0 for ; Mon, 19 Dec 2016 05:02:34 +0000 (UTC) In-Reply-To: <20161216204521.GG29871@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMi8xNi8yMDE2IDEyOjQ1IFBNLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gRnJpLCBE ZWMgMTYsIDIwMTYgYXQgMTI6MjA6MDVQTSAtMDgwMCwgTWljaGVsIFRoaWVycnkgd3JvdGU6Cj4+ IEZyb206IEFydW4gU2lsdXZlcnkgPGFydW4uc2lsdXZlcnlAbGludXguaW50ZWwuY29tPgo+Pgo+ PiBUaGlzIGNoYW5nZSBpbXBsZW1lbnRzIHN1cHBvcnQgZm9yIHBlci1lbmdpbmUgcmVzZXQgYXMg YW4gaW5pdGlhbCwgbGVzcwo+PiBpbnRydXNpdmUgaGFuZyByZWNvdmVyeSBvcHRpb24gdG8gYmUg YXR0ZW1wdGVkIGJlZm9yZSBmYWxsaW5nIGJhY2sgdG8gdGhlCj4+IGxlZ2FjeSBmdWxsIEdQVSBy ZXNldCByZWNvdmVyeSBtb2RlIGlmIG5lY2Vzc2FyeS4gVGhpcyBpcyBvbmx5IHN1cHBvcnRlZAo+ PiBmcm9tIEdlbjggb253YXJkcy4KPj4KPj4gSGFuZ2NoZWNrZXIgZGV0ZXJtaW5lcyB3aGljaCBl bmdpbmVzIGFyZSBodW5nIGFuZCBpbnZva2VzIGVycm9yIGhhbmRsZXIgdG8KPj4gcmVjb3ZlciBm cm9tIGl0LiBFcnJvciBoYW5kbGVyIHNjaGVkdWxlcyByZWNvdmVyeSBmb3IgZWFjaCBvZiB0aG9z ZSBlbmdpbmVzCj4+IHRoYXQgYXJlIGh1bmcuIFRoZSByZWNvdmVyeSBwcm9jZWR1cmUgaXMgYXMg Zm9sbG93cywKPj4gIC0gaWRlbnRpZmllcyB0aGUgcmVxdWVzdCB0aGF0IGNhdXNlZCB0aGUgaGFu ZyBhbmQgaXQgaXMgZHJvcHBlZAo+PiAgLSBmb3JjZSBlbmdpbmUgdG8gaWRsZTogdGhpcyBpcyBk b25lIGJ5IGlzc3VpbmcgYSByZXNldCByZXF1ZXN0Cj4+ICAtIHJlc2V0IGFuZCByZS1pbml0IGVu Z2luZQo+PiAgLSByZXN0YXJ0IHN1Ym1pc3Npb25zIHRvIHRoZSBlbmdpbmUKPj4KPj4gSWYgZW5n aW5lIHJlc2V0IGZhaWxzIHRoZW4gd2UgZmFsbCBiYWNrIHRvIGhlYXZ5IHdlaWdodCBmdWxsIGdw dSByZXNldAo+PiB3aGljaCByZXNldHMgYWxsIGVuZ2luZXMgYW5kIHJlaW5pdGlhemVzIGNvbXBs ZXRlIHN0YXRlIG9mIEhXIGFuZCBTVy4KPj4KPj4gdjI6IFJlYmFzZS4KPj4KPj4gQ2M6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiBDYzogTWlrYSBLdW9wcGFsYSA8 bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IFRvbWFzIEVs ZiA8dG9tYXMuZWxmQGludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogQXJ1biBTaWx1dmVyeSA8 YXJ1bi5zaWx1dmVyeUBsaW51eC5pbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IE1pY2hlbCBU aGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAgfCA1NiArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICB8ICAzICsr Cj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgICB8ICAyICstCj4+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICB8IDEyICsrKysrKysrCj4+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaCAgICB8ICAxICsKPj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VuY29yZS5jIHwgNDEgKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4+ICA2 IGZpbGVzIGNoYW5nZWQsIDEwOCBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmMKPj4gaW5kZXggZTU2ODhlZGQ2MmNkLi5hMDM0NzkzYmMyNDYg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+PiBAQCAtMTgzMCwxOCArMTgzMCw3MCBA QCB2b2lkIGk5MTVfcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAg ICoKPj4gICAqIFJlc2V0IGEgc3BlY2lmaWMgR1BVIGVuZ2luZS4gVXNlZnVsIGlmIGEgaGFuZyBp cyBkZXRlY3RlZC4KPj4gICAqIFJldHVybnMgemVybyBvbiBzdWNjZXNzZnVsIHJlc2V0IG9yIG90 aGVyd2lzZSBhbiBlcnJvciBjb2RlLgo+PiArICoKPj4gKyAqIFByb2NlZHVyZSBpcyBmYWlybHkg c2ltcGxlOgo+PiArICogIC0gaWRlbnRpZmllcyB0aGUgcmVxdWVzdCB0aGF0IGNhdXNlZCB0aGUg aGFuZyBhbmQgaXQgaXMgZHJvcHBlZAo+PiArICogIC0gZm9yY2UgZW5naW5lIHRvIGlkbGU6IHRo aXMgaXMgZG9uZSBieSBpc3N1aW5nIGEgcmVzZXQgcmVxdWVzdAo+PiArICogIC0gcmVzZXQgZW5n aW5lCj4+ICsgKiAgLSByZXN0YXJ0IHN1Ym1pc3Npb25zIHRvIHRoZSBlbmdpbmUKPj4gICAqLwo+ PiAgaW50IGk5MTVfcmVzZXRfZW5naW5lKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkK Pgo+IFdoYXQncyB0aGUgc2VyaWFsaXNhdGlvbiBiZXR3ZWVuIHBvdGVudGlhbCBjYWxsZXJzIG9m Cj4gaTkxNV9yZXNldF9lbmdpbmUoKT8KPgoKSSBoYXZlbid0IHNlZW4gc2ltdWx0YW5lb3VzIGNh bGxzIGhhcHBlbmluZyB5ZXQsIHdvdWxkIGEgCnJlc2V0X2VuZ2luZS1zcGVjaWZpYyBtdXRleCBi ZSBlbm91Z2g/Cgo+PiAgewo+PiAgCWludCByZXQ7Cj4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+Pgo+PiAtCS8qIEZJWE1FOiByZXBsYWNlIG1l IHdpdGggZW5naW5lIHJlc2V0IHNlcXVlbmNlICovCj4+IC0JcmV0ID0gLUVOT0RFVjsKPj4gKwkv Kgo+PiArCSAqIFdlIG5lZWQgdG8gZmlyc3QgaWRsZSB0aGUgZW5naW5lIGJ5IGlzc3VpbmcgYSBy ZXNldCByZXF1ZXN0LAo+PiArCSAqIHRoZW4gcGVyZm9ybSBzb2Z0IHJlc2V0IGFuZCByZS1pbml0 aWFsaXplIGh3IHN0YXRlLCBmb3IgYWxsIG9mCj4+ICsJICogdGhpcyBHVCBwb3dlciBuZWVkIHRv IGJlIGF3YWtlIHNvIGVuc3VyZSBpdCBkb2VzIHRocm91Z2hvdXQgdGhlCj4+ICsJICogcHJvY2Vz cwo+PiArCSAqLwo+PiArCWludGVsX3VuY29yZV9mb3JjZXdha2VfZ2V0KGRldl9wcml2LCBGT1JD RVdBS0VfQUxMKTsKPj4gKwo+PiArCS8qCj4+ICsJICogdGhlIHJlcXVlc3QgdGhhdCBjYXVzZWQg dGhlIGhhbmcgaXMgc3R1Y2sgb24gZWxzcCwgaWRlbnRpZnkgdGhlCj4+ICsJICogYWN0aXZlIHJl cXVlc3QgYW5kIGRyb3AgaXQsIGFkanVzdCBoZWFkIHRvIHNraXAgdGhlIG9mZmVuZGluZwo+PiAr CSAqIHJlcXVlc3QgdG8gcmVzdW1lIGV4ZWN1dGluZyByZW1haW5pbmcgcmVxdWVzdHMgaW4gdGhl IHF1ZXVlLgo+PiArCSAqLwo+PiArCWk5MTVfZ2VtX3Jlc2V0X2VuZ2luZShlbmdpbmUpOwo+Cj4g TXVzdCBmcmVlemUgdGhlIGVuZ2luZSBhbmQgaXJxcyBmaXJzdCwgYmVmb3JlIGNhbGxpbmcKPiBp OTE1X2dlbV9yZXNldF9lbmdpbmUoKSAoaS5lLiBzb21ldGhpbmcgbGlrZSBkaXNhYmxlX2VuZ2lu ZXNfaXJxLAo+IGNhbmNlbGxpbmcgdGFza2xldCkKPgpXaWxsIGRvLgoKPiBFZWVrIG5vdGUgdGhh dCB0aGUgY3VycmVudCBpOTE1X2dlbV9yZXNldF9lbmdpbmUoKSBpcyBsYWNraW5nIGEKPiBzcGlu bG9jay4KPgoKVGhlIG5ldyBtdXRleCAoZm9yIGk5MTVfcmVzZXRfZW5naW5lKSBzaG91bGQgY292 ZXIgdGhpcy4KCj4+ICsKPj4gKwlyZXQgPSBpbnRlbF9lbmdpbmVfcmVzZXRfYmVnaW4oZW5naW5l KTsKPj4gKwlpZiAocmV0KSB7Cj4+ICsJCURSTV9FUlJPUigiRmFpbGVkIHRvIGRpc2FibGUgJXNc biIsIGVuZ2luZS0+bmFtZSk7Cj4+ICsJCWdvdG8gZXJyb3I7Cj4+ICsJfQo+PiArCj4+ICsJcmV0 ID0gaW50ZWxfZ3B1X3Jlc2V0KGRldl9wcml2LCBpbnRlbF9lbmdpbmVfZmxhZyhlbmdpbmUpKTsK Pj4gKwlpZiAocmV0KSB7Cj4+ICsJCURSTV9FUlJPUigiRmFpbGVkIHRvIHJlc2V0ICVzLCByZXQ9 JWRcbiIsIGVuZ2luZS0+bmFtZSwgcmV0KTsKPj4gKwkJaW50ZWxfZW5naW5lX3Jlc2V0X2NhbmNl bChlbmdpbmUpOwo+PiArCQlnb3RvIGVycm9yOwo+PiArCX0KPj4gKwo+PiArCXJldCA9IGVuZ2lu ZS0+aW5pdF9odyhlbmdpbmUpOwo+PiArCWlmIChyZXQpCj4+ICsJCWdvdG8gZXJyb3I7Cj4+Cj4+ ICsJaW50ZWxfZW5naW5lX3Jlc2V0X2NhbmNlbChlbmdpbmUpOwo+PiArCWludGVsX2V4ZWNsaXN0 c19yZXN0YXJ0X3N1Ym1pc3Npb24oZW5naW5lKTsKPgo+IGVuZ2luZS0+aW5pdF9odyhlbmdpbmUp ICppcyogaW50ZWxfZXhlY2xpc3RzX3Jlc3RhcnRfc3VibWlzc2lvbi4KPgoKSSdsbCBtYWtlIHRo ZXNlIGNoYW5nZXMsClRoYW5rcy4KCj4+ICsKPj4gKwlpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3B1 dChkZXZfcHJpdiwgRk9SQ0VXQUtFX0FMTCk7Cj4+ICsJcmV0dXJuIDA7Cj4+ICsKPj4gK2Vycm9y Ogo+PiAgCS8qIHVzZSBmdWxsIGdwdSByZXNldCB0byByZWNvdmVyIG9uIGVycm9yICovCj4+ICAJ c2V0X2JpdChJOTE1X1JFU0VUX0lOX1BST0dSRVNTLCAmZGV2X3ByaXYtPmdwdV9lcnJvci5mbGFn cyk7Cj4+Cj4+ICsJLyogRW5naW5lIHJlc2V0IGlzIHBlcmZvcm1lZCB3aXRob3V0IHRha2luZyBz dHJ1Y3RfbXV0ZXgsIHNpbmNlIGl0Cj4+ICsJICogZmFpbGVkIHdlIG5vdyBmYWxsYmFjayB0byBm dWxsIGdwdSByZXNldC4gV2FrZXVwIGFueSB3YWl0ZXJzCj4+ICsJICogd2hpY2ggc2hvdWxkIG5v dyBzZWUgdGhlIHJlc2V0X2luX3Byb2dyZXNzIGFuZCByZWxlYXNlCj4+ICsJICogc3RydWN0X211 dGV4IGZvciB1cyB0byBjb250aW51ZSByZWNvdmVyeS4KPj4gKwkgKi8KPj4gKwlyY3VfcmVhZF9s b2NrKCk7Cj4+ICsJaW50ZWxfZW5naW5lX3dha2V1cChlbmdpbmUpOwo+PiArCXJjdV9yZWFkX3Vu bG9jaygpOwo+PiArCj4+ICsJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIEZP UkNFV0FLRV9BTEwpOwo+PiAgCXJldHVybiByZXQ7Cj4+ICB9Cj4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==