From: "cron2 (Code Review)" Date: Thu, 9 Jan 2025 14:56:37 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., samuli@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <2e7171e9a6ec3de8612a3c87bb8597fd01034b27-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="MtwRqlQ3VSA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: flichtenheld , plaisthos , openvpn-devel --MtwRqlQ3VSA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/811?usp=3Demail ) Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 8: Code-Review-1 (1 comment) Patchset: PS8: What is the point of backgrounding stuff from an `--up` script that waits o= n an (unrelated) foreground process to then kill the openvpn process from w= ithin the script? This looks very... weird, also `ps axwu |grep fping` is = a very good way to find arbitrary processes running on the system, but not = *your* fping. The `--up` script should do what an up script does well - save the IP addre= ss. The `wait for fping to terminate` already happens, by nature of a sync= hronous call, in `ping_lwip_clients()` - so killing the processes should be= done from there, when the *correct* fping test is done. There's more comments inline... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 8 Gerrit-Owner: mattock Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mattock Gerrit-Comment-Date: Thu, 09 Jan 2025 14:56:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --MtwRqlQ3VSA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mattock, plaisthos.

Patch set 8:Code-Review -1=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #8:

      What is the point of backgrounding stuff from = an `--up` script that waits on an (unrelated) foreground process to then ki= ll the openvpn process from within the script? This looks very... weird, a= lso `ps axwu |grep fping` is a very good way to find arbitrary processes ru= nning on the system, but not *your* fping.

      The `--up` script should do what an up script= does well - save the IP address. The `wait for fping to terminate` alread= y happens, by nature of a synchronous call, in `ping_lwip_clients()` - so k= illing the processes should be done from there, when the *correct* fping te= st is done.

      T= here's more comments inline...

To view, visit= change 8= 11. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca= 6b8c029f0d250
Gerrit-Change-Number: 811
Gerrit-PatchSet: 8
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mattock <samuli@...515...= >
Gerrit-Comment-Date: Thu, 09 Jan 2025 14:56:37= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--MtwRqlQ3VSA=--