Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iP8oJ-0003c0-Bm for mharc-grub-devel@gnu.org; Mon, 28 Oct 2019 13:28:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49536) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP8oG-0003Zc-QG for grub-devel@gnu.org; Mon, 28 Oct 2019 13:28:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iP8oF-0001YR-Pb for grub-devel@gnu.org; Mon, 28 Oct 2019 13:28:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34718) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iP8oF-0001Xz-Jv for grub-devel@gnu.org; Mon, 28 Oct 2019 13:28:03 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6E0478535C for ; Mon, 28 Oct 2019 17:28:02 +0000 (UTC) Received: by mail-wm1-f69.google.com with SMTP id b10so4492874wmh.6 for ; Mon, 28 Oct 2019 10:28:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f8YYK8DtaQhte6EbJGutAccTiqPlE9A6EZQ8ao1bRnA=; b=kKTcc7FzVRS6SyJuYUJCuWtizebPUyP1Q96hcITeEFpc9e0RFp30FbQSvtyDBCsctd 8cYMYJr3Pl2umHGU6SNvf+DWJSMPeudn6sMsvErJNIlvn1etGcS7PJTq5jc3vtx/qDcm 9Ontp9MKyzDhFdkLmDBHZgQv1VIDkqdmxhBBg89O67LYslEMdoH2n/rgMQMRjH+rO1E2 5+1cjLl9XQn+xkXyeok+lPuOWOfo5sz1GrF32qWewVdt7B8rMLv0VnTb3woB0wrMh9kn xgU1pgGlvXgisOBhmB1/6sOKtmD4PukZLUrAeZkF2zrqyzi9hES3YY1xmr1iAaSC67Fb Jwlw== X-Gm-Message-State: APjAAAW7+/OKP6JD+uBLuEWoLkjEXoXQzws/NHl8CwNmtp5X7/v2cAiL znryuxzvOkCc7wOtF2k9/IUZQXUwfXMjKL54cT6WMuVqyLWnngSHJSLxl/ajydCGQ+S9A8EgFnN vM0gJw1ADluw= X-Received: by 2002:adf:f2d1:: with SMTP id d17mr15408013wrp.353.1572283681241; Mon, 28 Oct 2019 10:28:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8xtdUpS/v6ef9+3EpwCXJ0l/fnVH5OY6hTP8rM038UIalhnMU+88rNktVaLfXjlOzah6wMQ== X-Received: by 2002:adf:f2d1:: with SMTP id d17mr15407995wrp.353.1572283681048; Mon, 28 Oct 2019 10:28:01 -0700 (PDT) Received: from [192.168.1.13] ([90.168.169.92]) by smtp.gmail.com with ESMTPSA id q14sm14210063wre.27.2019.10.28.10.28.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2019 10:28:00 -0700 (PDT) Subject: Re: [PATCH v2 2/2] Make editenv chase symlinks including those across devices To: Daniel Kiper Cc: grub-devel@gnu.org, Peter Jones , Jonathan Lebon , Adam Jackson References: <20191028131110.17464-1-javierm@redhat.com> <20191028131110.17464-2-javierm@redhat.com> <20191028161240.kf6ljjdr5bs3rjdz@tomti.i.net-space.pl> From: Javier Martinez Canillas Message-ID: <2e76d0d7-86fb-5aba-ef74-2ba77abdd268@redhat.com> Date: Mon, 28 Oct 2019 18:27:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191028161240.kf6ljjdr5bs3rjdz@tomti.i.net-space.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2019 17:28:06 -0000 Hello Daniel, Thanks a lot for pointing out these issues. I'll fix them in v2. >> + >> + linkbuf = xmalloc (size+1); > > Please check for NULL here. And "size + 1". In general I will not accept > any patch which does not check for NULL for malloc() et consortes. > Yes, I'll be more careful when reviewing our downstream patches before posting. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat