From: Oscar Mateo Lozano Subject: Re: [PATCH v4 1/3] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads Date: Fri, 18 May 2018 16:22:02 -0700 Message-ID: <2e88cf43-7ec6-8b13-ac4b-7907764eb05e@intel.com> References: <1526681090-22483-1-git-send-email-yunwei.zhang@intel.com> <1526683197-24656-1-git-send-email-yunwei.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5D226EF5E for ; Fri, 18 May 2018 23:24:04 +0000 (UTC) In-Reply-To: <1526683197-24656-1-git-send-email-yunwei.zhang@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Yunwei Zhang , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA1LzE4LzIwMTggMzozOSBQTSwgWXVud2VpIFpoYW5nIHdyb3RlOgo+IFdhUHJvZ3JhbU1n c3JGb3JDb3JyZWN0U2xpY2VTcGVjaWZpY01taW9SZWFkcyBkaWN0YXRlIHRoYXQgYmVmb3JlIGFu eSBNTUlPCj4gcmVhZCBpbnRvIFNsaWNlL1N1YnNsaWNlIHNwZWNpZmljIHJlZ2lzdGVycywgTUNS IHBhY2tldCBjb250cm9sCj4gcmVnaXN0ZXIoMHhGREMpIG5lZWRzIHRvIGJlIHByb2dyYW1tZWQg dG8gcG9pbnQgdG8gYW55IGVuYWJsZWQKPiBzbGljZS9zdWJzbGljZSBwYWlyLiBPdGhlcndpc2Us IGluY29ycmVjdCB2YWx1ZSB3aWxsIGJlIHJldHVybmVkLgo+Cj4gSG93ZXZlciwgdGhhdCBtZWFu cyBlYWNoIHN1YnNlcXVlbnQgTU1JTyByZWFkIHdpbGwgYmUgZm9yd2FyZGVkIHRvIGEKPiBzcGVj aWZpYyBzbGljZS9zdWJzbGljZSBjb21iaW5hdGlvbiBhcyByZWFkIGlzIHVuaWNhc3QuIFRoaXMg aXMgT0sgc2luY2UKPiBzbGljZS9zdWJzbGljZSBzcGVjaWZpYyByZWdpc3RlciB2YWx1ZXMgYXJl IGNvbnNpc3RlbnQgaW4gYWxtb3N0IGFsbCBjYXNlcwo+IGFjcm9zcyBzbGljZS9zdWJzbGljZS4g VGhlcmUgYXJlIHJhcmUgb2NjYXNpb25zIHN1Y2ggYXMgSU5TVERPTkUgdGhhdCB0aGlzCj4gdmFs dWUgd2lsbCBiZSBkZXBlbmRlbnQgb24gc2xpY2Uvc3Vic2xpY2UgY29tYm8sIGluIHN1Y2ggY2Fz ZXMsIHdlIG5lZWQgdG8KPiBwcm9ncmFtIDB4RkRDIGFuZCByZWNvdmVyIHRoaXMgYWZ0ZXIuIFRo aXMgaXMgYWxyZWFkeSBjb3ZlcmVkIGJ5Cj4gcmVhZF9zdWJzbGljZV9yZWcuCj4KPiBBbHNvLCAw eEZEQyB3aWxsIGxvc2UgaXRzIGluZm9ybWF0aW9uIGFmdGVyIFREUi9lbmdpbmUgcmVzZXQvcG93 ZXIgc3RhdGUKPiBjaGFuZ2UuCj4KPiBSZWZlcmVuY2VzOiBIU0QjMTQwNTU4Njg0MCwgQlNJRCMw NTc1Cj4KPiB2MjoKPiAgIC0gdXNlIGZscygpIGluc3RlYWQgb2YgZmluZF9sYXN0X2JpdCgpIChD aHJpcykKPiAgIC0gYWRkZWQgSU5URUxfU1NFVSB0byBleHRyYWN0IHNzZXUgZnJvbSBkZXZpY2Ug aW5mby4gKENocmlzKQo+IHYzOgo+ICAgLSByZWJhc2Ugb24gbGF0ZXN0IHRpcAo+IHY1Ogo+ICAg LSBBZGRlZCByZWZlcmVuY2VzIChNaWthKQo+ICAgLSBDaGFuZ2UgdGhlIG9yZGVyZWQgb2YgcGFz c2luZyBhcmd1bWVudHMgYW5kIGV0Yy4gKFVyc3VsaW4pCj4gdjc6Cj4gICAtIE1vdmVkIFdBIGV4 cGxhbmF0aW9uIENvbW1lbnRzKE9zY2FyKQo+ICAgLSBSZWJhc2VkLgo+IHY4Ogo+ICAgLSBSZW5h bWVkIHNhbml0aXplX21jciB0byBjYWxjdWxhdGVfc19zc19zZWxlY3QuIChPc2NhcikKPiAgIC0g Y2FsY3VsYXRlIHMvc3Mgc2VsZWN0b3IgaW5zdGVhZCBvZiB3aG9sZSBtY3IuIChPc2NhcikKPiB2 OToKPiAgIC0gVXBkYXRlZCBmdW5jdGlvbiBuYW1lIChPc2NhcikKPiAgIC0gUmVtb3ZlIHJlZHVu ZGFudCB2YXJpYWJsZXMgKE9zY2FyKQo+IHYxMDoKPiAgIC0gU2VwYXJhdGUgcHJlLUdFTjEwIGFu ZCBHRU4xMSBtYXNrLiAoT3NjYXIpCj4KPiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGlu dGVsLmNvbT4KPiBDYzogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4K PiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+ IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBL dW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1 bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogWXVu d2VpIFpoYW5nIDx5dW53ZWkuemhhbmdAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IE9zY2FyIE1h dGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaCAgICAgICAgICB8ICAyICsrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9lbmdpbmVfY3MuYyAgIHwgMzAgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kcy5jIHwgMjcgKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4gICAzIGZpbGVzIGNoYW5nZWQsIDU0IGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCBlMzNjMzgw Li4zYjhhMDQ3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTI3NDQsNiArMjc0 NCw4IEBAIGludCB2bHZfZm9yY2VfZ2Z4X2Nsb2NrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwgYm9vbCBvbik7Cj4gICBpbnQgaW50ZWxfZW5naW5lc19pbml0X21taW8oc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIGludCBpbnRlbF9lbmdpbmVzX2luaXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIAo+ICt1MzIgaW50ZWxfY2Fs Y3VsYXRlX21jcl9zX3NzX3NlbGVjdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Owo+ICsKPiAgIC8qIGludGVsX2hvdHBsdWcuYyAqLwo+ICAgdm9pZCBpbnRlbF9ocGRfaXJxX2hh bmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCQkJICAgdTMyIHBp bl9tYXNrLCB1MzIgbG9uZ19tYXNrKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVf Y3MuYwo+IGluZGV4IDI2ZjlmOGEuLjgzMjQxOWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9lbmdpbmVfY3MuYwo+IEBAIC04MTksMTIgKzgxOSwyOSBAQCBjb25zdCBjaGFyICppOTE1 X2NhY2hlX2xldmVsX3N0cihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgaW50IHR5cGUp Cj4gICAJfQo+ICAgfQo+ICAgCj4gK3UzMiBpbnRlbF9jYWxjdWxhdGVfbWNyX3Nfc3Nfc2VsZWN0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJY29uc3Qgc3RydWN0 IHNzZXVfZGV2X2luZm8gKnNzZXUgPSAmKElOVEVMX0lORk8oZGV2X3ByaXYpLT5zc2V1KTsKPiAr CXUzMiBtY3Jfc19zc19zZWxlY3Q7Cj4gKwl1MzIgc2xpY2UgPSBmbHMoc3NldS0+c2xpY2VfbWFz ayk7Cj4gKwl1MzIgc3Vic2xpY2UgPSBmbHMoc3NldS0+c3Vic2xpY2VfbWFza1tzbGljZV0pOwo+ ICsKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID09IDEwKQo+ICsJCW1jcl9zX3NzX3NlbGVj dCA9IEdFTjhfTUNSX1NMSUNFKHNsaWNlKSB8Cj4gKwkJCQkgIEdFTjhfTUNSX1NVQlNMSUNFKHN1 YnNsaWNlKTsKPiArCWVsc2UKPiArCQltY3Jfc19zc19zZWxlY3QgPSAwOwo+ICsKPiArCXJldHVy biBtY3Jfc19zc19zZWxlY3Q7Cj4gK30KPiArCj4gICBzdGF0aWMgaW5saW5lIHVpbnQzMl90Cj4g ICByZWFkX3N1YnNsaWNlX3JlZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGlu dCBzbGljZSwKPiAgIAkJICBpbnQgc3Vic2xpY2UsIGk5MTVfcmVnX3QgcmVnKQo+ICAgewo+ICAg CXVpbnQzMl90IG1jcl9zbGljZV9zdWJzbGljZV9tYXNrOwo+ICAgCXVpbnQzMl90IG1jcl9zbGlj ZV9zdWJzbGljZV9zZWxlY3Q7Cj4gKwl1aW50MzJfdCBkZWZhdWx0X21jcl9zX3NzX3NlbGVjdDsK PiAgIAl1aW50MzJfdCBtY3I7Cj4gICAJdWludDMyX3QgcmV0Owo+ICAgCWVudW0gZm9yY2V3YWtl X2RvbWFpbnMgZndfZG9tYWluczsKPiBAQCAtODQxLDYgKzg1OCw4IEBAIHJlYWRfc3Vic2xpY2Vf cmVnKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IHNsaWNlLAo+ICAgCQkJ CQkgICAgR0VOOF9NQ1JfU1VCU0xJQ0Uoc3Vic2xpY2UpOwo+ICAgCX0KPiAgIAo+ICsJZGVmYXVs dF9tY3Jfc19zc19zZWxlY3QgPSBpbnRlbF9jYWxjdWxhdGVfbWNyX3Nfc3Nfc2VsZWN0KGRldl9w cml2KTsKPiArCj4gICAJZndfZG9tYWlucyA9IGludGVsX3VuY29yZV9mb3JjZXdha2VfZm9yX3Jl ZyhkZXZfcHJpdiwgcmVnLAo+ICAgCQkJCQkJICAgIEZXX1JFR19SRUFEKTsKPiAgIAlmd19kb21h aW5zIHw9IGludGVsX3VuY29yZV9mb3JjZXdha2VfZm9yX3JlZyhkZXZfcHJpdiwKPiBAQCAtODUx LDExICs4NzAsMTAgQEAgcmVhZF9zdWJzbGljZV9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCBpbnQgc2xpY2UsCj4gICAJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXRfX2xv Y2tlZChkZXZfcHJpdiwgZndfZG9tYWlucyk7Cj4gICAKPiAgIAltY3IgPSBJOTE1X1JFQURfRlco R0VOOF9NQ1JfU0VMRUNUT1IpOwo+IC0JLyoKPiAtCSAqIFRoZSBIVyBleHBlY3RzIHRoZSBzbGlj ZSBhbmQgc3VibGljZSBzZWxlY3RvcnMgdG8gYmUgcmVzZXQgdG8gMAo+IC0JICogYWZ0ZXIgcmVh ZGluZyBvdXQgdGhlIHJlZ2lzdGVycy4KPiAtCSAqLwo+IC0JV0FSTl9PTl9PTkNFKG1jciAmIG1j cl9zbGljZV9zdWJzbGljZV9tYXNrKTsKPiArCj4gKwlXQVJOX09OX09OQ0UoKG1jciAmIG1jcl9z bGljZV9zdWJzbGljZV9tYXNrKSAhPQo+ICsJCSAgICAgZGVmYXVsdF9tY3Jfc19zc19zZWxlY3Qp Owo+ICsKPiAgIAltY3IgJj0gfm1jcl9zbGljZV9zdWJzbGljZV9tYXNrOwo+ICAgCW1jciB8PSBt Y3Jfc2xpY2Vfc3Vic2xpY2Vfc2VsZWN0Owo+ICAgCUk5MTVfV1JJVEVfRlcoR0VOOF9NQ1JfU0VM RUNUT1IsIG1jcik7Cj4gQEAgLTg2Myw2ICs4ODEsOCBAQCByZWFkX3N1YnNsaWNlX3JlZyhzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCBzbGljZSwKPiAgIAlyZXQgPSBJOTE1 X1JFQURfRlcocmVnKTsKPiAgIAo+ICAgCW1jciAmPSB+bWNyX3NsaWNlX3N1YnNsaWNlX21hc2s7 Cj4gKwltY3IgfD0gZGVmYXVsdF9tY3Jfc19zc19zZWxlY3Q7Cj4gKwo+ICAgCUk5MTVfV1JJVEVf RlcoR0VOOF9NQ1JfU0VMRUNUT1IsIG1jcik7Cj4gICAKPiAgIAlpbnRlbF91bmNvcmVfZm9yY2V3 YWtlX3B1dF9fbG9ja2VkKGRldl9wcml2LCBmd19kb21haW5zKTsKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHMuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3dvcmthcm91bmRzLmMKPiBpbmRleCAyZGYzNTM4Li43MjBkODYzIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kcy5jCj4gQEAgLTY3Miw4ICs2NzIs MzUgQEAgc3RhdGljIHZvaWQgY2ZsX2d0X3dvcmthcm91bmRzX2FwcGx5KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAkJICAgR0FNVF9FQ09fRU5BQkxFX0lOX1BMQUNFX0RF Q09NUFJFU1MpOwo+ICAgfQo+ICAgCj4gK3N0YXRpYyB2b2lkIHdhX2luaXRfbWNyKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJdTMyIG1jcjsKPiArCXUzMiBtY3Jf c2xpY2Vfc3Vic2xpY2VfbWFzazsKPiArCj4gKwltY3IgPSBJOTE1X1JFQUQoR0VOOF9NQ1JfU0VM RUNUT1IpOwo+ICsKPiArCW1jcl9zbGljZV9zdWJzbGljZV9tYXNrID0gR0VOOF9NQ1JfU0xJQ0Vf TUFTSyB8Cj4gKwkJCQkgIEdFTjhfTUNSX1NVQlNMSUNFX01BU0s7Cj4gKwkvKgo+ICsJICogV2FQ cm9ncmFtTWdzckZvckNvcnJlY3RTbGljZVNwZWNpZmljTW1pb1JlYWRzOmNubAo+ICsJICogQmVm b3JlIGFueSBNTUlPIHJlYWQgaW50byBzbGljZS9zdWJzbGljZSBzcGVjaWZpYyByZWdpc3RlcnMs IE1DUgo+ICsJICogcGFja2V0IGNvbnRyb2wgcmVnaXN0ZXIgbmVlZHMgdG8gYmUgcHJvZ3JhbW1l ZCB0byBwb2ludCB0byBhbnkKPiArCSAqIGVuYWJsZWQgcy9zcyBwYWlyLiBPdGhlcndpc2UsIGlu Y29ycmVjdCB2YWx1ZXMgd2lsbCBiZSByZXR1cm5lZC4KPiArCSAqIFRoaXMgbWVhbnMgZWFjaCBz dWJzZXF1ZW50IE1NSU8gcmVhZCB3aWxsIGJlIGZvcndhcmRlZCB0byBhbgo+ICsJICogc3BlY2lm aWMgcy9zcyBjb21iaW5hdGlvbiwgYnV0IHRoaXMgaXMgT0sgc2luY2UgdGhlc2UgcmVnaXN0ZXJz Cj4gKwkgKiBhcmUgY29uc2lzdGVudCBhY3Jvc3Mgcy9zcyBpbiBhbG1vc3QgYWxsIGNhc2VzLiBJ biB0aGUgcmFyZQo+ICsJICogb2NjYXNpb25zLCBzdWNoIGFzIElOU1RET05FLCB3aGVyZSB0aGlz IHZhbHVlIGlzIGRlcGVuZGVudAo+ICsJICogb24gcy9zcyBjb21ibywgdGhlIHJlYWQgc2hvdWxk IGJlIGRvbmUgd2l0aCByZWFkX3N1YnNsaWNlX3JlZy4KPiArCSAqLwo+ICsJbWNyICY9IH5tY3Jf c2xpY2Vfc3Vic2xpY2VfbWFzazsKPiArCW1jciB8PSBpbnRlbF9jYWxjdWxhdGVfbWNyX3Nfc3Nf c2VsZWN0KGRldl9wcml2KTsKPiArCUk5MTVfV1JJVEUoR0VOOF9NQ1JfU0VMRUNUT1IsIG1jcik7 Cj4gK30KPiArCj4gICBzdGF0aWMgdm9pZCBjbmxfZ3Rfd29ya2Fyb3VuZHNfYXBwbHkoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgewo+ICsJd2FfaW5pdF9tY3IoZGV2X3By aXYpOwo+ICsKPiAgIAkvKiBXYURpc2FibGVJMm1DeWNsZU9uV1JQb3J0OmNubCAocHJlLXByb2Qp ICovCj4gICAJaWYgKElTX0NOTF9SRVZJRChkZXZfcHJpdiwgQ05MX1JFVklEX0IwLCBDTkxfUkVW SURfQjApKQo+ICAgCQlJOTE1X1dSSVRFKEdBTVRfQ0hLTl9CSVRfUkVHLAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==