Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DD61C433EF for ; Tue, 22 Mar 2022 01:00:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BAE098395A; Tue, 22 Mar 2022 02:00:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UBDYXsQz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 40BAC8396F; Tue, 22 Mar 2022 02:00:44 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 032E0804F9 for ; Tue, 22 Mar 2022 02:00:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id jo24so5261376qvb.5 for ; Mon, 21 Mar 2022 18:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iOEJ0tMTMITTYzY9/SwVQX4eTXXUiwlK1jDbIAS5RpQ=; b=UBDYXsQzAed5f1aITmnXEboM6vOzSLI/maQshZ0TVgSg+I7tt+yS7wDmhq0YaoNyrT mQZQB8gPMe0yyFsT6OZPXLCINkUIu0yHZH26d6voK1GlEEwV32znxiWvL5g/t/1PgYEv J0JVGUe83vm/uhOEFXTktYx3tr6raclU2sV7uHRMSVQVzV6NS5xFfuk4aXa3lxW33Ucs hede96r/3xQjO7pzglmLdZKfz7l+1WYOqEfxXCexqTKYPQVKXgHKGVY9OStWkvxZPyjD 4z7gh99DahShE9uv3nSqEmCiS86UmglD5cnfexaJMSIk9iv2dZ81E1jAev5H2DXOn+ZC OXtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iOEJ0tMTMITTYzY9/SwVQX4eTXXUiwlK1jDbIAS5RpQ=; b=2H1gEjbMaSbbipUw8YGx/yf/LIh0PbydFlUBFjVTcx/4ytvMor26Od5Gx7K0uNgTb8 Y1tZx4CSCZtYdkCk+bquxjMeOIyAwCeJ7QqU3GZmtjyoxAuKv/Q2V/xwD9XNXFWsxT8u 9NgcqUnpBJ2zUkc8nBUqo5qlCDVB2R+5BYVzcMZvf181hiXP3CWaR2QSdbBgyK0Fn3YB cVR8J4ZMOrFJTVXii4TMxogeRPfTM376JSnBSjrUxUociGI2WatsyK0ukG3kAv7PUwZM Yod2ZIscUaQKU07nN76jYajDDNNDRYKfC3XgUmAFhKIKnO4D5P1p9BcFn2uYOXj9ypdh AKjA== X-Gm-Message-State: AOAM531rQT6vJ8IINGIqB34KwKzvbX1j7aj7ipGxn6c4ANpvlqnQQ+WV f+4BM4/ic71E6JD+C1r39tk= X-Google-Smtp-Source: ABdhPJyOD0zZS8TYwzp4cWVNP/JdHoJvf/YcI/pmWGQqRbqgq7NudavyBaA3r5DhRZV1jgEciZeURA== X-Received: by 2002:a05:6214:d4a:b0:440:ea86:ce64 with SMTP id 10-20020a0562140d4a00b00440ea86ce64mr16533238qvr.128.1647910839775; Mon, 21 Mar 2022 18:00:39 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id i18-20020ac85c12000000b002e1ce74f1a8sm12803240qti.27.2022.03.21.18.00.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 18:00:39 -0700 (PDT) Subject: Re: [PATCH v2 1/3] Add valgrind headers to U-Boot To: Simon Glass , Tom Rini Cc: U-Boot Mailing List , Heinrich Schuchardt References: <20210505200821.2104070-1-seanga2@gmail.com> <20210505200821.2104070-2-seanga2@gmail.com> <20210517211826.GA11532@bill-the-cat> <20210518013936.GJ17669@bill-the-cat> From: Sean Anderson Message-ID: <2f59742a-6ff1-a8cd-7576-180364bb1397@gmail.com> Date: Mon, 21 Mar 2022 21:00:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/21/22 2:06 PM, Simon Glass wrote: > Hi Sean, > > On Mon, 17 May 2021 at 19:39, Tom Rini wrote: >> >> On Mon, May 17, 2021 at 09:36:10PM -0400, Sean Anderson wrote: >>> >>> On 5/17/21 5:18 PM, Tom Rini wrote: >>>> On Wed, May 05, 2021 at 04:08:18PM -0400, Sean Anderson wrote: >>>> >>>>> Valgrind uses magic code sequences to define an ABI that the client may use >>>>> to request behavior from the host. In particular, this may be used to >>>>> inform valgrind about custom allocators, such as the one used in U-Boot. >>>>> >>>>> This adds headers defining these sequences to U-Boot. It also adds a config >>>>> option to disable emission of these sequences entirely, in the (likely) >>>>> event that the user does not wish to use valgrind. Note that this option >>>>> was originally called NVALGRIND, but was renamed (and inverted) to >>>>> CONFIG_VALGRIND. >>>>> >>>>> These headers were copied from valgrind 3.16.1-4 as distributed in Arch >>>>> Linux. They are licensed with the bzip2 1.16 license. This appears to be a >>>>> BSD license with some clauses from Zlib. >>>>> >>>>> Signed-off-by: Sean Anderson >>>>> Reviewed-by: Simon Glass >>>> >>>> I'm not sure which part of the series breaks building without valgrind >>>> installed for everything, but some part of this does, please re-test. >>>> Thanks. >>>> >>> >>> Is this due to warnings? I noticed that compiling without >>> CONFIG_VALGRIND set resulted in a bunch of "This statement has no >>> effect" warnings after I had sent out this series. If this is it, I can >>> investigate for v4. >> >> Yes, those warnings. CI builds with -Werror on. > > Did this patch get resent in the end? No. I can have another look at this series later this week. --Sean