From: "cron2 (Code Review)" Date: Mon, 29 Jan 2024 13:55:25 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <2f7c95aa683c0ea563bf7f0e21b7645037e81803-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="/ucj5vZoB8Y="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: test_user_pass: Add UTs for character filtering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --/ucj5vZoB8Y= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/47= 3?usp=3Demail ) Change subject: test_user_pass: Add UTs for character filtering ...................................................................... test_user_pass: Add UTs for character filtering For simplicity I implemented them only with the inline method, but they actually apply to all methods. Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Acked-by: Gert Doering Message-Id: <20240129105358.11161-1-gert@...1296...> URL: https://www.mail-archive.com/search?l=3Dmid&q=3D20240129105358.11161-1= -gert@...1296... Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 23 insertions(+), 0 deletions(-) diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index ab4dfe4..277cb1d 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -141,6 +141,29 @@ reset_user_pass(&up); + /* Test various valid characters */ + /*FIXME: query_user_exec() called even though nothing queued */ + will_return(query_user_exec_builtin, true); + /* FIXME? content after first two lines just ignored */ + assert_true(get_user_pass_cr(&up, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B= =88=ED=8B=B0\n//ipassw=C3=B6rd!\nsome other content\nnot relevant", "UT", f= lags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B= =88=ED=8B=B0"); + assert_string_equal(up.password, "//ipassw=C3=B6rd!"); + + reset_user_pass(&up); + + /* Test various invalid characters */ + /*FIXME: query_user_exec() called even though nothing queued */ + will_return(query_user_exec_builtin, true); + /*FIXME? allows arbitrary crap if c > 127 */ + /*FIXME? silently removes control characters */ + assert_true(get_user_pass_cr(&up, "\tiuser\r\nipass\xffwo\x1erd", "UT"= , flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "iuser"); + assert_string_equal(up.password, "ipass\xffword"); + + reset_user_pass(&up); + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Password:"); will_return(query_user_exec_builtin, "cpassword"); will_return(query_user_exec_builtin, true); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/473?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db Gerrit-Change-Number: 473 Gerrit-PatchSet: 7 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --/ucj5vZoB8Y= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

test_user_pass: Add UTs for character filterin=
g

For simplicity I implemented them only with the
inline method, = but they actually apply to all methods.

Change-Id: Ie8d2d5f6f58679ba= af5eb817a7e2ca1afcb8c4db
Signed-off-by: Frank Lichtenheld <frank@...1665...= 641...>
Acked-by: Arne Schwabe <arne-openvpn@...1227...>
Ack= ed-by: Gert Doering <gert@...1296...>
Message-Id: <202401291053= 58.11161-1-gert@...1296...>
URL: https://www.mail-archive.com/search?= l=3Dmid&q=3D20240129105358.11161-1-gert@...1296...
Signed-off-by: Ge= rt Doering <gert@...1296...>
---
M tests/unit_tests/openvpn/tes= t_user_pass.c
1 file changed, 23 insertions(+), 0 deletions(-)

diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_test=
s/openvpn/test_user_pass.c
index ab4dfe4..277cb1d 100644
--- a/tests/unit_tests/openvpn/test_user_pass.c
+++ b/tests/unit_tests/openvpn/test_user_pass.c

@@ -141,= 6 +141,29 @@

reset_user_pass(&up= );

= + /* Test various valid characters */
+ /*FIXME: query_user_exec() called even though noth= ing queued */
+ wi= ll_return(query_user_exec_builtin, true);
+ /* FIXME? content after first two lines just igno= red */
+ assert_tr= ue(get_user_pass_cr(&up, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B=88= =ED=8B=B0\n//ipassw=C3=B6rd!\nsome other content\nnot relevant", "= ;UT", flags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "#iuser and =EC=BB= =A4=EB=AE=A4=EB=8B=88=ED=8B=B0");
+ assert_string_equal(up.password, "//ipassw=C3= =B6rd!");
+
+ reset_user_pass(&= ;up);
+
+ /* Test various invalid chara= cters */

+ /*FIXME= : query_user_exec() called even though nothing queued */
+ will_return(query_user_exec_builti= n, true);
+ /*FIXM= E? allows arbitrary crap if c > 127 */
+ /*FIXME? silently removes control characters */
+ assert_true(get_u= ser_pass_cr(&up, "\tiuser\r\nipass\xffwo\x1erd", "UT&quo= t;, flags, NULL));
+ = assert_true(up.defined);
+ assert_string_equal(up.username, "iuser");
= + assert_string_equal(up.pas= sword, "ipass\xffword");
+
+ = reset_user_pass(&up);
+
expect_string(query_user_exec_builtin, query_us= er[i].prompt, "Enter UT Password:");
will_re= turn(query_user_exec_builtin, "cpassword");
= will_return(query_user_exec_builtin, true);

To view, visit change 473. To unsubscribe, or for help writing mail filters= , visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d2d5f6f58679baaf5eb817a7e= 2ca1afcb8c4db
Gerrit-Change-Number: 473
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--/ucj5vZoB8Y=--