From: "flichtenheld (Code Review)"
Date: Tue, 9 Jul 2024 16:13:27 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, gert@...1296...
Message-ID: <2fbf58744b4bb144f83214b82b8def9765720b17-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="W61rbczFV4w="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Allow trailing \r
and \n in control channel message
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: cron2 , openvpn-devel
--W61rbczFV4w=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/672?usp=3Demail )
Change subject: Allow trailing \r and \n in control channel message
......................................................................
Patch Set 3: Code-Review-1
(4 comments)
Patchset:
PS2:
> I must say that I would feel better if we had a UT covering all this. [=
=E2=80=A6]
Done
Patchset:
PS3:
Thanks, addresses my concerns. However, does not actually build currently ;)
File src/openvpn/forward.c:
http://gerrit.openvpn.net/c/openvpn/+/672/comment/5483cbeb_14179e53 :
PS2, Line 318: format_hex(BPTR(&buf), BLEN(&cmdbuf)=
, 256, &gc));
> It is "not wrong today", but this sort of booby trap will come back and b=
ite us later - so this shou [=E2=80=A6]
Done
File src/openvpn/forward.c:
http://gerrit.openvpn.net/c/openvpn/+/672/comment/2df6966e_2cf72181 :
PS3, Line 295: struct buffer cmdbuf =3D extract_command_buffer(=
buf, &gc);
&buf
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e
Gerrit-Change-Number: 672
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Comment-Date: Tue, 09 Jul 2024 16:13:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--W61rbczFV4w=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, plaisthos.
Patch set 3:Code-Review -1=
Vi=
ew Change
4 comments:
Patchset:
Patch Set #2:
I must say that I=
would feel better if we had a UT covering all this. [=E2=80=A6]
Done
=
li>Patchset:
File src/openvpn/forward.c:
Patch Set #2, Line 318: format_hex(BPTR(&=
amp;buf), BLEN(&cmdbuf), 256, &gc));
It is &q=
uot;not wrong today", but this sort of booby trap will come back and b=
ite us later - so this shou [=E2=80=A6]
Done
File src/openvpn/forward.c:
- <=
p style=3D"margin-bottom: 4px;">Patch Set #3, Line 295:
struct buffer cmdbuf =3D =
extract_command_buffer(buf, &gc);&buf
To view,=
visit ch=
ange 672. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f72=
0cf50dc1fbe3e
Gerrit-Change-Number: 672
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Comment-Date: Tue, 09 Jul 2024 16:13:27=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--W61rbczFV4w=--