From: "plaisthos (Code Review)"
Date: Fri, 5 Jan 2024 12:25:08 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., gert@...1296..., a@...2181...
Message-ID: <302d54fb3ab1278548dc321b29c0f4a0be644dd4-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="tw+4cCVSsso="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Make it more
explicit and visible when pkg-config is not found
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: cron2 , flichtenheld , openvpn-devel
--tw+4cCVSsso=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, ordex.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/465?usp=3Demail )
Change subject: Make it more explicit and visible when pkg-config is not fo=
und
......................................................................
Patch Set 4:
(2 comments)
File configure.ac:
http://gerrit.openvpn.net/c/openvpn/+/465/comment/dcc958e2_10a99171 :
PS3, Line 385: pkg_config_found=3D"(not found)"
> am I wrong or there is some indentation havoc here? The line above uses 8=
blanks tab, but the lines b [=E2=80=A6]
Done
http://gerrit.openvpn.net/c/openvpn/+/465/comment/2097ad6b_aaa8c8c1 :
PS3, Line 387: pkg_config_found=3D"(using ${PKG_CONFIG})"
> many error messages already contain 'using pkg-config', therefore the tex=
t above will lead to 'using [=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/465?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229cbfc08a3d8854a
Gerrit-Change-Number: 465
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: ordex
Gerrit-CC: openvpn-devel
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Fri, 05 Jan 2024 12:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--tw+4cCVSsso=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, ordex.
View C=
hange
2 comments:
Done<=
/p>
Patch Set #3, Line 387: pkg_config_found=3D"(using ${PKG_CONFIG})"
many error messages already contain 'using pkg-confi=
g', therefore the text above will lead to 'using [=E2=80=A6]Done=
p>
To view, visit change 465. To unsubscribe, or for help =
writing mail filters, visit =
settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iebaa35a23e217a4cd7739af229c=
bfc08a3d8854a
Gerrit-Change-Number: 465
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: ordex <a@...2181...> =
div>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <a@...2181...> <=
/div>
Gerrit-Comment-Date: Fri, 05 Jan 2024 12:25:08=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <a@...2181...>=
;
Gerrit-MessageType: comment
--tw+4cCVSsso=--