From: Heiko Hund Date: Tue, 05 Jul 2022 14:32:25 +0200 Message-ID: <30400821.xTBbKaCY6X@...2664...> In-Reply-To: <20220624083809.23487-24-a@...2181...> References: <20220624083809.23487-1-a@...2181...> <20220624083809.23487-24-a@...2181...> MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH 23/25] dco-win: implement ovpn-dco support in P2P Windows code path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net On Freitag, 24. Juni 2022 10:38:07 CEST Antonio Quartulli wrote: > + if (!is_windco(c->c1.tuntap)) [...] > + if ((options->windows_driver == > WINDOWS_DRIVER_WINTUN || options->windows_driver == WINDOWS_DRIVER_WINDCO) [...] > +create_socket_windco(struct context *c, struct link_socket *sock, Thinking "_dco_win" would be a better suffix for consistency. > - status = WSAGetLastError(); > + if (sock->info.dco_installed) > + { > + status = GetLastError(); > + } > + else > + { > + status = WSAGetLastError(); > + } Small wrapper would be good as this construct appears twice.