Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B144C636D4 for ; Wed, 15 Feb 2023 13:18:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D64256B0072; Wed, 15 Feb 2023 08:18:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D143E6B0073; Wed, 15 Feb 2023 08:18:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03C46B0074; Wed, 15 Feb 2023 08:18:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B39CB6B0072 for ; Wed, 15 Feb 2023 08:18:08 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 793C21C6171 for ; Wed, 15 Feb 2023 13:18:08 +0000 (UTC) X-FDA: 80469579456.05.DE0F138 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 66CEB1A001F for ; Wed, 15 Feb 2023 13:18:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B7K9N9Uy; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676467085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2VI9LQ93QCS9/VaDCzNyslbiwpgq4KQbuN5xAQtK3uM=; b=HNBv+DNwbAF3+VDrZceFyModoas3VFalYAS3sJldG55snH2thJHKE7Y+IkA5qr8JhgXei2 TBLo03ACAP2BMPX0Ne/Y0KIEef+QRNtkHnaQhtRn2F9ySyj1Cuw7lJXYeHe1zjhuvYWqkl cL0L6abkZ690sKdNPH90DTYtL4ppiUk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=B7K9N9Uy; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676467085; a=rsa-sha256; cv=none; b=XVixJXRqq7BSdCoZ2j3sPJCPSwlCoiiHYGCvUPAplHuAbfPn1xxLP0dmLYvwN1/lZ9oVQO yOUP2kAJPZqyOQFfmcZG3NXyvFlc9tPJUWe4ZZ9vU7cdUvqQBp+de3K+rnBUsqrIEyWFAb n6pd6YlN+RA/V4m5FbakXURyZxWk8fk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676467084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2VI9LQ93QCS9/VaDCzNyslbiwpgq4KQbuN5xAQtK3uM=; b=B7K9N9UyNrMfVQq33Hpr4aEk/1ydumtGT0SAfCtIKODcFIC5jqK2tj3ks+/hUOS8lMDIIa xsDA9XgpL/EWK+cVBiopw8CW5zGIkexH+heNYFRPZvwunvX1/NB/Iqj53GY/EMVszhZSm2 3b43hVNXBh+vhKEkd8o3EE5pzfquJJA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-417-4hfXO2ydNASLc3T-rKl-Qg-1; Wed, 15 Feb 2023 08:18:02 -0500 X-MC-Unique: 4hfXO2ydNASLc3T-rKl-Qg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0020C28004E9; Wed, 15 Feb 2023 13:18:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 016712026D4B; Wed, 15 Feb 2023 13:17:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230209102954.528942-1-dhowells@redhat.com> <20230209102954.528942-2-dhowells@redhat.com> <909202.1675959337@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Matthew Wilcox , Jens Axboe , Al Viro , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzbot+a440341a59e3b7142895@syzkaller.appspotmail.com, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v14 01/12] splice: Fix O_DIRECT file read splice to avoid reversion of ITER_PIPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 15 Feb 2023 13:17:56 +0000 Message-ID: <3057147.1676467076@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 6i75t8oqfurydrhgohjzsem4hsfigedi X-Rspamd-Queue-Id: 66CEB1A001F X-HE-Tag: 1676467085-7773 X-HE-Meta: U2FsdGVkX19A9r7NuR+XBQygZCeC852nBvg8OTaqoefZeFh7ufaFT5IZEIq0nE/UdDEvleE1PcTHv3JX23CUFeNkMXEx0KSAEieVFA3xbx5NeGSnpqqNTFc5jO2FRmIxKl6jh7bXA3wDLWTrpIia9vm27QKl1jhK2mS/nZLiORx9m9BUmpoguCkRRWrmW07mZUpD37+q/gpwcgBSHJtUbwcR+hjyxPXYCnMsz/MDqtWL58/b7eeEy7NyDECVIC9hiF0o/bTsJ4J0tqIOnZp5IDixdiX2KpmjWRvgslG73RUEkfSyIDCF0PwEUchoxa9/vZ+U8sYwXxxZxnNgZjNjheHWv3FWh03gSlA1+9EeuvI19eJ7ioRxI6ur5hR+T1xgGeEcqMMCX3GtTZXcQCOKOM8ZhC6dwXqwqUlvkwCpMSb28dINkPf31mQWLqAGRsJx8a/LP67B7aKV82JAGqbaygaKQfUQM07+ui9+iio6N6u+1P8iWknGcj6SLk1jSv7AVz/0LqRdgu6x+kzFF3+zhyUoi/Ax3ybSbEIoikxTOkX5DjWOW1HKQs2DNtstpw2b0RwkA+FwLFQ2OsNtwrPdsKuL/hscuPa2hM+Nis1APHVy6wj/r7O2q/lqeNLkxTjAVnLGQZBiZUbXzji48h/jt7JHyiL8YPS+mkXD6MH0Z4s2B5dpDBly5rHCBYXqTCxwa4X65XZf1UNJLwRJTHO0zKc7D06DB+RneO4NU3HG3XmGbnnnL24vDUIzS9zAWuJ8eFn5FuexokI1y+m3NYLzx/95EjXDR7zgj5Er/yXwKAHYjq4ZyizHAXTVEfQB0uWhjb/Ie+HzIRv6IiyM4BV2+JqZnhyqVwypL/nCfVg8lwjgzY1XCc0QdQH1GzY2ovMmNK/gKjpOXdN8LkSEsUOvy6k4K0SUb8AM07gZe96NrRZKXMNZ0cUqkj8dq0DbmChV86mXZYzO03nFw4maFeI jXZg8URP WA7btVeguvcoyLtKwekPsXyVRLcccLG3ehwOL6fia11dxS67DfbxEI+bjLykhFAZoN/O4vjzgvWM4pnUc3GphuHCC8krIzGKAE/Pnct/oIUFKBK6nwmIJXafKpLPsltEeZKtwYRNyqtxpLbfN8x8TPbk4j1J7suKibuOLOVGaTceoHDWjw7xFj+ENm3c1mSYv+OLKYmRfop+NDDWrdUU0kwBDMPv9MiPaO9wl/XFjrPd2cOLn+S55t0qPUl7binl+hRvwju8Yp1S0SzmHhGds6Tq+2s91AEXym8NtsadfDHspXcXmaMVFi0IgtE5W+ERQ2Y+s/974zONZsMuchYBS/mOke06FTVWYVY7OBbeHJsCx2tBKNYjTdF5niA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > > + pages =3D (void *)(bv + npages); >=20 > I think this cast should be to struct page **=E2=80=A6 not void *. Yeah. Doesn't change anything functionally, though, I think. > > + /* Free any pages that didn't get touched at all. */ > > + reclaim /=3D PAGE_SIZE; >=20 > Any reason not to keep reclaim in PAGE_SIZE units to start with? Probably not, but I don't want to fiddle with that right now. I can send a follow up patch for it. David