Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB7EC7EE23 for ; Tue, 23 May 2023 20:43:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E80D6B0074; Tue, 23 May 2023 16:43:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37147900003; Tue, 23 May 2023 16:43:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EC3A900002; Tue, 23 May 2023 16:43:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0BBD66B0074 for ; Tue, 23 May 2023 16:43:26 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD0E0C0556 for ; Tue, 23 May 2023 20:43:25 +0000 (UTC) X-FDA: 80822695170.11.7DBD734 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id BE52EC0014 for ; Tue, 23 May 2023 20:43:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ue9nkrBi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684874604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2AXwrxmIeNRwbgPUcfTuA7DYIUBj+3M4SsEiMK2Pk9Y=; b=mO6k2Br5k68DwU7BCLejgFvLkOKs9wuJDRDLCniaFV3w1wWVsEwnNwPruP1/HPV916qCKp ndYdXh6odyZMfxu33cMXnPFXzg3BBeoYJ2imJ7OJJZVGRIcMunK8wBkgwx7hM2CeD1DVjC ef2IKmUZ/nax/J4k9lBDlVDXDuuu9zQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ue9nkrBi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684874604; a=rsa-sha256; cv=none; b=aYMC1Yt9l/CpAXB7bhix45usgDscv5eUfGiNMdut87FgJpubDBUxP2HhWp8Qn+bh0B7U5K k/tPCdBLaGbiMAsDhtts3o6HGKB0U7c2MPDr2I+oL43zzpJEttQjuM7SMP/WSSGJNpwAyz kv8fkG6RSw4POP8VpEf2LePVV6elPZw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684874602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2AXwrxmIeNRwbgPUcfTuA7DYIUBj+3M4SsEiMK2Pk9Y=; b=Ue9nkrBiarg1I97vJ+U3gTTD7e/D5DPikJg2cBHHMsbXXflVz+7V+MPQEDZg53jEzWy8PH kvS02ClznL7r+0MvIFYN/Pro0wjEmrqTfDCnM+T3tdNYB3YtFo561mxjLO7q2exhgTnDjt 8owTraLhDkpGlfVuRkHiphN91HsMEDE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-19-l3glK4kQPEiT2-OmO-TScA-1; Tue, 23 May 2023 16:43:19 -0400 X-MC-Unique: l3glK4kQPEiT2-OmO-TScA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59C3B185A78B; Tue, 23 May 2023 20:43:18 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6DC2A492B0A; Tue, 23 May 2023 20:43:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <12153db1-20af-040b-ded0-31286b5bafca@kernel.org> References: <12153db1-20af-040b-ded0-31286b5bafca@kernel.org> <20230522135018.2742245-1-dhowells@redhat.com> <20230522135018.2742245-26-dhowells@redhat.com> To: Damien Le Moal Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH v22 25/31] zonefs: Provide a splice-read wrapper MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3071147.1684874594.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 23 May 2023 21:43:14 +0100 Message-ID: <3071148.1684874594@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BE52EC0014 X-Stat-Signature: y9m1b1pe9kb8z1o6hu4auaa1h944h1hm X-Rspam-User: X-HE-Tag: 1684874603-441921 X-HE-Meta: U2FsdGVkX1+KxiVt0NK34e7cN4vOuKTbZD3bZzW1N3vK8AD2a0EXCsLm9y2bw1jVzLStc5J68g9HudWHscxKkEKW1g3a42prqmrlGs51F2+AHPN6osgIsw4trOu72Wjrjp/EzV2BWo/kpKqOWcIFFoR4/g++D16/2DCzQBrvXdKA7GitAsHfe8rwngOKomvbko0jb0X3Xi/C5SOeZjRFqqN1+QdoUVsGzPhRNc4c2EpqR+iPeJIwO2SWoGq0cBBb3J6ca6Vvq9KjXtLXa7Q6HeaeOGm1dY6t703pwjYt755xu69Kti/nWCWQKqQbZ8Ed81+zuN3Cpy0GbxhaBYcMrA7GufkcQijkmD1yceYwWhOji0idV3bqRcw+hq7JrC9XRrQDTP6IxSw8cdZrcD5bOVOwe1u0nyKqiYr2ti8RS2IYR/irs+cy6jKUhnempiPF1wJKy9mTwRGAZ9leR29XZ6ZhqqBNVioHTlzfml0wqmhFYaRVtcNZ8MMFZps6rbvHr/C489hhqk8Gu2rkVvTka02v3FYFasfULhVcLw4WaiXaj8uSiR/rqs7QFh8E4LOqLKpsIl2BAtSElvS0uCJCNujgoAGYDrHenaBxu9vXodBaAci8RTRcBAJpZP/wRrIaglwo8h7A5yYkv+6k0tRLI58fnLGPGIwrj9pQgVwrHg8Zswp/Ud+ut2C/UJGEf9OjFXnGegeKLOLX7MidTim9T4jjb6BsiGRCXs3rWwwcIeXRmrg//atjuVrArccJTCNM67DlSmV3fcvMVi9lqbn0IrVhcv5OviYJDKmGWz1X8Nbl14Uf8TKdllFgxvvs6BJGUcKGZnps2F+VJSIo6ra7f2hE9Lz206lHlQePW3xCimSX92Z3K70+UI6bnArJ6MVmkPxRHR5Lb25CI5EN0C+sZwYK6PM3RMdkWI4V2L7CzMY6EC7jqBbTyYb6pZhUO7pQApZKsHaX8kjMknL/gdI 3jshcvi9 t01pHtzl0B8rxllfcFr97f2iY3LSw2l7nqjUOvuongswQepshO9WdSLt4XNEBw/TkCKPgmbN02gjSbxI0jIsJ2ttKMREmlNrvHp5WyYMMnB1qjXmlhlMVW+3OGw0Ea4sjT0MfatJvAxVApTbvc82QhN/3uSKNtmOkpsn7jL3ASPk2HpWV1hsNwrQeVStv3eWmuRHtGaoTOl4sj8/DmbHyaVPg4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Damien Le Moal wrote: > > + if (len > 0) { > > + ret =3D filemap_splice_read(in, ppos, pipe, len, flags); > > + if (ret =3D=3D -EIO) > = > Is -EIO the only error that filemap_splice_read() may return ? There are= other > IO error codes that we could get from the block layer, e.g. -ETIMEDOUT e= tc. So > "if (ret < 0)" may be better here ? It can return -ENOMEM, -EINTR and -EAGAIN at least, none of which really c= ount as I/O errors. I based the splice function on what zonefs_file_read_iter(= ) does: } else { ret =3D generic_file_read_iter(iocb, to); if (ret =3D=3D -EIO) zonefs_io_error(inode, false); } David