From: David Hildenbrand Subject: Re: [kvm-unit-tests PATCH v2 3/6] s390x: copy sclp.h and sclp-ascii.c from QEMU Date: Fri, 19 May 2017 14:48:43 +0200 Message-ID: <310254c8-8620-e375-7737-1ed098bfd444@redhat.com> References: <20170518113427.18387-1-david@redhat.com> <20170518113427.18387-4-david@redhat.com> <018f5cce-d975-f9c9-9c6a-3c003dfcf205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Christian Borntraeger , Cornelia Huck To: Thomas Huth , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46482 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755638AbdESMsq (ORCPT ); Fri, 19 May 2017 08:48:46 -0400 In-Reply-To: <018f5cce-d975-f9c9-9c6a-3c003dfcf205@redhat.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 19.05.2017 11:32, Thomas Huth wrote: > On 18.05.2017 13:34, David Hildenbrand wrote: >> The s390x-ccw pcbios already has what we need to print to the sclp >> console. Let's copy the files and adjust them to our needs later. >> >> Signed-off-by: David Hildenbrand >> --- >> lib/s390x/sclp-ascii.c | 82 +++++++++++++++++++++++++++++++++++++ >> lib/s390x/sclp.h | 107 +++++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 189 insertions(+) >> create mode 100644 lib/s390x/sclp-ascii.c >> create mode 100644 lib/s390x/sclp.h >> >> diff --git a/lib/s390x/sclp-ascii.c b/lib/s390x/sclp-ascii.c >> new file mode 100644 >> index 0000000..dc1c3e4 >> --- /dev/null >> +++ b/lib/s390x/sclp-ascii.c > > Looks like the file has been renamed to sclp.c in recent QEMU master ... > maybe we should use that name here, too? > At the time I copied it, it was called sclp-ascii.c, so this should be fine I think. Also, if we ever add new code related to sclp, we will rather put it into a new file, which could then become sclp.c > Thomas > Thanks -- Thanks, David