From: "flichtenheld (Code Review)" Date: Thu, 11 Jul 2024 10:26:37 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <3137c792f24ab402a48f13b168f7ac754ffffcd7-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="zScaMOs8nUM="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Switch to C11 by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --zScaMOs8nUM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/673?usp=3Demail to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by plaisthos The change is no longer submittable: Code-Review and checks~ChecksSubmitRul= e are unsatisfied now. Change subject: configure: Switch to C11 by default ...................................................................... configure: Switch to C11 by default Mostly so we can use anonymous structs without jumping through hoops or relying on unofficial support. Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 Signed-off-by: Frank Lichtenheld --- M CMakeLists.txt M Changes.rst M configure.ac 3 files changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/73/673/3 diff --git a/CMakeLists.txt b/CMakeLists.txt index 096837d..ad620fa 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -119,7 +119,7 @@ set(OPENVPN_VERSION_PATCH ${PRODUCT_VERSION_PATCH}) set(OPENVPN_VERSION_RESOURCE ${PRODUCT_VERSION_RESOURCE}) -set(CMAKE_C_STANDARD 99) +set(CMAKE_C_STANDARD 11) # Set the various defines for config.h.cmake.in if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux") diff --git a/Changes.rst b/Changes.rst index 439352a..0a26dca 100644 --- a/Changes.rst +++ b/Changes.rst @@ -42,6 +42,12 @@ ``--topology net30`` to the config should fix the problem. By default ``--topology`` is pushed from server to client. +Default C standard to follow was updated to C11. + The work-around for compilers that do not support anonymous unions was + removed. All currently supported versions of our target platforms shou= ld + have compilers that can handle C11. The platform that got support + most recently seems to be OpenBSD (default gcc). + OpenSSL 1.0.2 support Support for building with OpenSSL 1.0.2 has been removed. The minimum supported OpenSSL version is now 1.1.0. diff --git a/configure.ac b/configure.ac index 1f03f90..dcc46e2 100644 --- a/configure.ac +++ b/configure.ac @@ -421,10 +421,10 @@ AC_CHECK_PROGS([RST2HTML], [rst2html rst2html.py]) AM_CONDITIONAL([HAVE_PYDOCUTILS], [test "${RST2MAN}" -a "${RST2HTML}"]) -# Set -std=3Dc99 unless user already specified a -std=3D +# Set -std=3Dc11 unless user already specified a -std=3D case "${CFLAGS}" in *-std=3D*) ;; - *) CFLAGS=3D"${CFLAGS} -std=3Dc99" ;; + *) CFLAGS=3D"${CFLAGS} -std=3Dc11" ;; esac # -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/673?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 Gerrit-Change-Number: 673 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newpatchset --zScaMOs8nUM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

flichtenheld uploaded patch set #3 to this change.

<= p>View Ch= ange

The following approvals got outdated and were removed: Code-Review+2 by plaisthos

The change is no longer submittable: Code-= Review and checks~ChecksSubmitRule are unsatisfied now.

configure: Switch t=
o C11 by default

Mostly so we can use anonymous structs without jump= ing through
hoops or relying on unofficial support.

Change-Id: I7= 2934e747d1ad68a7e3675afbeb1b63df7941186
Signed-off-by: Frank Lichtenheld= <frank@...2641...>
---
M CMakeLists.txt
M Changes.rst
M = configure.ac
3 files changed, 9 insertions(+), 3 deletions(-)

=
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/73/673/3
=
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 09683= 7d..ad620fa 100644
--- a/CMakeLists.txt
+++= b/CMakeLists.txt
@@ -119,7 +119,7 @@
set(= OPENVPN_VERSION_PATCH ${PRODUCT_VERSION_PATCH})
set(OPENVP= N_VERSION_RESOURCE ${PRODUCT_VERSION_RESOURCE})
-set(CMAKE_C_STANDARD 99)=
+set(CMAKE_C_STANDARD 11)

# Set the various defines for config.h.cm= ake.in
if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux"= )
diff --git a/Changes.rst b/Changes.rst
in= dex 439352a..0a26dca 100644
--- a/Changes.rst
+++ b/Changes.rst

@@ -42,6 +42,12 @@
= ``--topology net30`` to the config should fix the problem.
By default ``--topology`` is pushed from server to client.
+Default C s= tandard to follow was updated to C11.
+ The work-around for compilers that do not support ano= nymous unions was
+ = removed. All currently supported versions of our target platforms should<= /span>
+ have compilers t= hat can handle C11. The platform that got support
+ most recently seems to be OpenBSD (defaul= t gcc).
+
<= span> OpenSSL 1.0.2 support

Support for building with = OpenSSL 1.0.2 has been removed. The minimum
supported = OpenSSL version is now 1.1.0.
diff --git a/configure.ac b/c= onfigure.ac
index 1f03f90..dcc46e2 100644
-= -- a/configure.ac
+++ b/configure.ac
@@ -42= 1,10 +421,10 @@
AC_CHECK_PROGS([RST2HTML], [rst2html rst2h= tml.py])
AM_CONDITIONAL([HAVE_PYDOCUTILS], [test "${R= ST2MAN}" -a "${RST2HTML}"])

-# Set -std=3Dc99 unless user already= specified a -std=3D
= +# Set -std=3Dc11 unless user already specified a -std=3D
= case "${CFLAGS}" in
*-std=3D*) ;;
- *) CFLAGS=3D"${CFLAGS= } -std=3Dc99" ;;
+ *) CFLAGS=3D"${CFLAGS} -std=3Dc11" ;;
= esac

#

=

To view, visit change 673. To unsubscribe, or for help writing mail filters,= visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I72934e747d1ad68a7e3675afbeb= 1b63df7941186
Gerrit-Change-Number: 673
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newpatchset
--zScaMOs8nUM=--