Message-ID: <31402838-162e-4e41-84df-49e6109a2e41@nvidia.com>
Date: Wed, 31 Dec 2025 14:54:34 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 07/11] gpu: nova-core: Add basic Turing HAL
To: Timur Tabi <ttabi@nvidia.com>, Danilo Krummrich <dakr@kernel.org>,
 Alexandre Courbot <acourbot@nvidia.com>,
 Joel Fernandes <joelagnelf@nvidia.com>, nouveau@lists.freedesktop.org,
 rust-for-linux@vger.kernel.org
References: <20251218032955.979623-1-ttabi@nvidia.com>
 <20251218032955.979623-8-ttabi@nvidia.com>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20251218032955.979623-8-ttabi@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cEZOeWJwbnlUdTM5ZzlESHZRY2hBUUl2UlluSjF1dHluVzg5Z045bFVRU3Jo?=
 =?utf-8?B?RWROL3V1Z1ovaTNyWDZEUUxtTVNrVWhlQjBESWl5MUtSWW9VcXdJTzFrYUZ3?=
 =?utf-8?B?QlhJczhsN0h2enI3Mk93ZG5ySVljNFh2OUE0WlNjWDRQUmg5b2RBMDhMOUxC?=
 =?utf-8?B?K3NzM3lvSDVEV3B1YTFXZ3hvRHBRSUUxR1pjbTVFcXBWVUVYVW8rbzl2SHow?=
 =?utf-8?B?YjB5MzRvMVpvamVrM254SkxaOStqdEkxdFk3eWJqRkFsRVNBT1l2c1FXT2lO?=
 =?utf-8?B?Zmk5WE1NbW5nMGc0TEV3cCt2MXkzMEVTTHZXQ280UWtSWktWNmZpMHgrYWcz?=
 =?utf-8?B?Vmh3VnMraTIrN01vU0lWZGJzZVZBMnJ6L2s5NkgzdUdibWVZa0pYUStyOHI4?=
 =?utf-8?B?anp5SDFxM2ZFTllncmd6YUhLM1ZxK29GN3pqSE5EYkVpZ3pKd2Zpb0g2djdx?=
 =?utf-8?B?UngwVWs4VUdrZWh1QXBKT1lZUHRqdXJIUVJqV3Jyc205aG5xaUsrZVpYZXpv?=
 =?utf-8?B?aHc4RXNaV0RiU2o1ekxWZ1JFeHZ2YmxWQnFURkJpUi83MkpKOHplRDlTeFJo?=
 =?utf-8?B?dUp1QmF5czdUWmNHQU5WdVFjMnl6SHA3Um1RdjVGeFd5YTJyRGF0UXV6RGdD?=
 =?utf-8?B?ZmwwZEFIN0hVTlpLVEpSSHhvaksyUHRDM0hyQnpzQ2p0QVJnZjF6aDI2SE5T?=
 =?utf-8?B?ZjQ5RmhkL1BObmhnRFB1VWVhb0VuS21rUjgyOXFnblRRVHRlMkhpU09HelFq?=
 =?utf-8?B?TktPemdBcHRxanRpSXBzSGZXRDdtV2VEZUdpTnZ4TVdTYTdtOFQ2ZG01UzNy?=
 =?utf-8?B?WTlzK21VblR1Q2g4TWRsaWxLWEdlU1Z2ZVRqdGQ0TDczWGtRQ0krNmt1M3Zr?=
 =?utf-8?B?QkxVK3hDMUlmQzUvQTh0U2xRRnc0MDJyTE1ONWlSRGtMaTE1QzBpT25LM2to?=
 =?utf-8?B?aFRCQVFQNVR6VnBTamJ0R3NlRDdOZjNMRUFCU2xjemFaNG41ejNZNC96cmhv?=
 =?utf-8?B?UDNDRHdUOXNTdERLNElhb2hOVmJ0cVNiRXZNMStPd0VwRStpZVZ0c3M1SzhK?=
 =?utf-8?B?a3EwM3pmejkzbzNVOWlxSDZmUElQc3RpTGJjOXNXcVRwM1M0cXg0L29KTzB2?=
 =?utf-8?B?MDl1bjNhaHR5Rmw2SEFOZGVVTzBoQ2pTUUJmWCtWdjRNVUUxcmRXQitQbnJR?=
 =?utf-8?B?eDcwNWdoa3lWWGxZN2dQMFdYS3FKQ1lFc2hLSVM5NExBZ0c5TkpQdGJBS2Nv?=
 =?utf-8?B?emlQVHNLc0tDODd6OVFFTWJiTmhMb1RKaDArdXRYRXpoUUJpdGZFSlp1Q3Vz?=
 =?utf-8?B?elhXRlREU3B6d1V0dllKbFowWFNqNWUzZ0lncGoxcVcvSGtrd1UySEc2V3Nr?=
 =?utf-8?B?eU92TDRQUjNTcmowaE55R1A3R1dPcnNpbnFFSThBKzI4eFVTd0pMakpxMTVL?=
 =?utf-8?B?L1k1ek0wajVpbW1paWlHTi9wbG5qSzhNc0lmUTRaSlozci9ldVl2QWlYZG1y?=
 =?utf-8?B?b1UwZlh0MjM1RTc2S0wwVGZGMkxJN2p5c3FjTlY2djdsZWhvTC9zaXU0TkIx?=
 =?utf-8?B?M2FSSXpnQ0Nzckdmck52OEJsYklQbWEwYXhaU0hQODdOaWRBSk8rR1IrSG5o?=
 =?utf-8?B?eHJYUFR1ZnRvRVM1Wlo2RTdTSFAwc3dxejhnRi9lcDE0dm9sVXZFWUxJek9Z?=
 =?utf-8?B?Q3RZMS9DTW80RnFoRXVSTnlBaDM5RlU5M0s5TVJJZFNqS3NvR3k5S1NqMmJl?=
 =?utf-8?B?WDJYOXNHYzBFK1lqWnM4bnpCYzIxSVROSkhMcG1SbmJQRWcvYWR2S1F0WWEr?=
 =?utf-8?B?RUxXMk1zS2lkWC9MdkgyV1AwQ2huRzlZZlovR203OWRHR3ErRVNrVUdvN043?=
 =?utf-8?B?MWJGWm9oamVQWXdjREhmdldpY1F1UmYycSs3SldNeGozemI5WUJ4SFFvUGVB?=
 =?utf-8?B?SU1UbTNLdVBES0lXekI5a24vUzFUS2NKaFI3clZQdGZBT3dJb2NqaWplV29t?=
 =?utf-8?B?YzhDMW93MEtXWHluVVFYdjJKQnZtWG1INXJFRmFWSWxpTDlja1lRdXFIVUFO?=
 =?utf-8?B?eFZHR1R5Mnc5a1VJNEx1ODNqemp5RXFDQnVZQTRJYTI0SlhxZkVmRGlnOVNv?=
 =?utf-8?B?ZFhoajlSS2hhWlhTL0xNbXdtazI5YlFSdUMxWjFqclRua0hzajkzQk1mVUox?=
 =?utf-8?B?b0xwdkE2RW8vK2dObHVyMkkvbUpES3R1VGlXbWZnWitHM1FWa3VqVWpIeXo2?=
 =?utf-8?B?YWJWcUxheEJ3QlhlanJNbmdoL0xIQ25mZjJsd2VOdU9jQXJkTGdBRHBieG5O?=
 =?utf-8?B?RXdzSnRZZUlRQlBZWitWTU5jMDRlRnAyTnFrM2xObFBwR1I1dkZ3UT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe21dcd-41ef-4fac-ac7a-08de48bf9e8e
X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2025 22:54:57.1735
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cj5GsPl17EWkzERVKxeivpUrNFTiHo0huJBij88Tr6N8XEbh/Pr1/KZ5AoIrgN5cqiYEaobBeRmctgP5LeMZMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5753

On 12/17/25 7:29 PM, Timur Tabi wrote:
> Add the basic HAL for recognizing Turing GPUs.  This isn't enough
> to support booting GSP-RM on Turing, but it's a start.
> 
> Note that GA100, which boots using the same method as Turing, is not
> supported yet.
> 
> Signed-off-by: Timur Tabi <ttabi@nvidia.com>
> ---
>  drivers/gpu/nova-core/falcon/hal.rs       |  4 ++
>  drivers/gpu/nova-core/falcon/hal/tu102.rs | 73 +++++++++++++++++++++++
>  drivers/gpu/nova-core/regs.rs             | 14 +++++
>  3 files changed, 91 insertions(+)
>  create mode 100644 drivers/gpu/nova-core/falcon/hal/tu102.rs
> 
> diff --git a/drivers/gpu/nova-core/falcon/hal.rs b/drivers/gpu/nova-core/falcon/hal.rs
> index c77a1568ea96..c886ba03d1f6 100644
> --- a/drivers/gpu/nova-core/falcon/hal.rs
> +++ b/drivers/gpu/nova-core/falcon/hal.rs
> @@ -13,6 +13,7 @@
>  };
>  
>  mod ga102;
> +mod tu102;
>  
>  /// Hardware Abstraction Layer for Falcon cores.
>  ///
> @@ -60,6 +61,9 @@ pub(super) fn falcon_hal<E: FalconEngine + 'static>(
>      use Chipset::*;
>  
>      let hal = match chipset {
> +        TU102 | TU104 | TU106 | TU116 | TU117 => {
> +            KBox::new(tu102::Tu102::<E>::new(), GFP_KERNEL)? as KBox<dyn FalconHal<E>>
> +        }
>          GA102 | GA103 | GA104 | GA106 | GA107 | AD102 | AD103 | AD104 | AD106 | AD107 => {
>              KBox::new(ga102::Ga102::<E>::new(), GFP_KERNEL)? as KBox<dyn FalconHal<E>>
>          }
> diff --git a/drivers/gpu/nova-core/falcon/hal/tu102.rs b/drivers/gpu/nova-core/falcon/hal/tu102.rs
> new file mode 100644
> index 000000000000..ac8f58ef6789
> --- /dev/null
> +++ b/drivers/gpu/nova-core/falcon/hal/tu102.rs
> @@ -0,0 +1,73 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +use core::marker::PhantomData;
> +
> +use kernel::{
> +    io::poll::read_poll_timeout,
> +    prelude::*,
> +    time::delay::fsleep,
> +    time::Delta, //
> +};
> +
> +use crate::driver::Bar0;
> +use crate::falcon::{Falcon, FalconBromParams, FalconEngine};
> +use crate::regs;

This needs to be formatted like this:

use crate::{
    driver::Bar0,
    falcon::{
        Falcon,
        FalconBromParams,
        FalconEngine, //
    },
    regs, //
};


With that applied, please feel free to add:


Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard


> +
> +use super::FalconHal;
> +
> +pub(super) struct Tu102<E: FalconEngine>(PhantomData<E>);
> +
> +impl<E: FalconEngine> Tu102<E> {
> +    pub(super) fn new() -> Self {
> +        Self(PhantomData)
> +    }
> +}
> +
> +impl<E: FalconEngine> FalconHal<E> for Tu102<E> {
> +    fn select_core(&self, _falcon: &Falcon<E>, _bar: &Bar0) -> Result {
> +        Ok(())
> +    }
> +
> +    fn signature_reg_fuse_version(
> +        &self,
> +        _falcon: &Falcon<E>,
> +        _bar: &Bar0,
> +        _engine_id_mask: u16,
> +        _ucode_id: u8,
> +    ) -> Result<u32> {
> +        Ok(0)
> +    }
> +
> +    fn program_brom(&self, _falcon: &Falcon<E>, _bar: &Bar0, _params: &FalconBromParams) -> Result {
> +        Ok(())
> +    }
> +
> +    fn is_riscv_active(&self, bar: &Bar0) -> bool {
> +        let cpuctl = regs::NV_PRISCV_RISCV_CORE_SWITCH_RISCV_STATUS::read(bar, &E::ID);
> +        cpuctl.active_stat()
> +    }
> +
> +    fn reset_wait_mem_scrubbing(&self, bar: &Bar0) -> Result {
> +        // TIMEOUT: memory scrubbing should complete in less than 10ms.
> +        read_poll_timeout(
> +            || Ok(regs::NV_PFALCON_FALCON_DMACTL::read(bar, &E::ID)),
> +            |r| r.mem_scrubbing_done(),
> +            Delta::ZERO,
> +            Delta::from_millis(10),
> +        )
> +        .map(|_| ())
> +    }
> +
> +    fn reset_eng(&self, bar: &Bar0) -> Result {
> +        regs::NV_PFALCON_FALCON_ENGINE::update(bar, &E::ID, |v| v.set_reset(true));
> +
> +        // TIMEOUT: falcon engine should not take more than 10us to reset.
> +        fsleep(Delta::from_micros(10));
> +
> +        regs::NV_PFALCON_FALCON_ENGINE::update(bar, &E::ID, |v| v.set_reset(false));
> +
> +        self.reset_wait_mem_scrubbing(bar)?;
> +
> +        Ok(())
> +    }
> +}
> diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
> index c049f5aaf2f2..8188a566e1ae 100644
> --- a/drivers/gpu/nova-core/regs.rs
> +++ b/drivers/gpu/nova-core/regs.rs
> @@ -307,6 +307,13 @@ pub(crate) fn mem_scrubbing_done(self) -> bool {
>      7:7     secure_stat as bool;
>  });
>  
> +impl NV_PFALCON_FALCON_DMACTL {
> +    /// Returns `true` if memory scrubbing is completed.
> +    pub(crate) fn mem_scrubbing_done(self) -> bool {
> +        !self.dmem_scrubbing() && !self.imem_scrubbing()
> +    }
> +}
> +
>  register!(NV_PFALCON_FALCON_DMATRFBASE @ PFalconBase[0x00000110] {
>      31:0    base as u32;
>  });
> @@ -389,6 +396,13 @@ pub(crate) fn with_falcon_mem(self, mem: FalconMem) -> Self {
>  
>  // PRISCV
>  
> +// RISC-V status register for debug (Turing and GA100 only).
> +// Reflects current RISC-V core status.
> +register!(NV_PRISCV_RISCV_CORE_SWITCH_RISCV_STATUS @ PFalcon2Base[0x00000240] {
> +    0:0     active_stat as bool, "RISC-V core active/inactive status";
> +});
> +
> +// GA102 and later
>  register!(NV_PRISCV_RISCV_CPUCTL @ PFalcon2Base[0x00000388] {
>      0:0     halted as bool;
>      7:7     active_stat as bool;