From: "cron2 (Code Review)" Date: Thu, 15 Jan 2026 09:28:50 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <3152b9a5e4ebfa6d7959316c5f152b15700a29c3-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="DZ9FUw5vFiI="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: port-share: Check return value of fork() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --DZ9FUw5vFiI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.o= penvpn.net/c/openvpn/+/1470?usp=3Demail ) Change subject: port-share: Check return value of fork() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/ps.c: http://gerrit.openvpn.net/c/openvpn/+/1470/comment/15ae06d2_c91866a0?usp=3D= email : PS1, Line 814: { why this extra bracket level? To ensure scoping for "status"? Not sure I = find this a good change... since we try to get rid of these constructs else= where it's confusing me, at least. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1470?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5eac1b31ae40eb957e2c12ca6c37b491fef32847 Gerrit-Change-Number: 1470 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 15 Jan 2026 09:28:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --DZ9FUw5vFiI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 1:Code-Review -1=

V= iew Change

1 comment:

  • File src/openvpn/ps.c:

    • Patch Set #1, = Line 814: {<= /p>

      why this extra bracket level? To ensure scoping for "status"= ? Not sure I find this a good change... since we try to get rid of these c= onstructs elsewhere it's confusing me, at least.

  • To view, visit change 1470. To unsubscribe, or for help writing mail filter= s, visit setting= s.

    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I5eac1b31ae40eb957e2c12ca6c3= 7b491fef32847
    Gerrit-Change-Number: 1470
    Gerrit-PatchSet: 1
    Gerrit-Owner: flichtenheld <frank@...2723...= .>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 09:28:50= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    = --DZ9FUw5vFiI=--