From: Laurent Pinchart Subject: Re: [PATCH] gpu: anx7808: fix a missing check of return value Date: Fri, 21 Dec 2018 07:02:11 +0200 Message-ID: <3157460.hcpWlpvoCn@avalon> References: <20181220074116.40546-1-kjlu@umn.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 39D5A6EB03 for ; Fri, 21 Dec 2018 05:01:18 +0000 (UTC) In-Reply-To: <20181220074116.40546-1-kjlu@umn.edu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kangjie Lu Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pakki001@umn.edu List-Id: dri-devel@lists.freedesktop.org SGkgS2FuZ2ppZSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVGh1cnNkYXksIDIwIERl Y2VtYmVyIDIwMTggMDk6NDE6MTYgRUVUIEthbmdqaWUgTHUgd3JvdGU6Cj4gQm90aCBhbng3OHh4 X3NldF9iaXRzKCkgYW5kIGFueDc4eHhfY2xlYXJfYml0cygpIGluIHRoZSBwb3dlcm9uIHByb2Nl c3MKPiBtYXkgZmFpbC4gVGhlIGZpeCBpbnNlcnRzIGNoZWNrcyBmb3IgdGhlaXIgcmV0dXJuIHZh bHVlcy4gSWYgdGhlIHBvd2Vyb24KPiBwcm9jZXNzIGZhaWxzLCBpdCBjYWxscyBhbng3OHh4X3Bv d2Vyb2ZmKCkuCj4gCj4gU2lnbmVkLW9mZi1ieTogS2FuZ2ppZSBMdSA8a2psdUB1bW4uZWR1Pgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4LWFueDc4eHguYyB8IDI2ICsr KysrKysrKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCsp LCA4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L2FuYWxvZ2l4LWFueDc4eHguYwo+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC1h bng3OHh4LmMgaW5kZXgKPiBmODQzM2M5M2Y0NjMuLmE1NzEwNGM3MTczOSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4LWFueDc4eHguYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgtYW54Nzh4eC5jCj4gQEAgLTYxMCwyMCArNjEwLDIw IEBAIHN0YXRpYyBpbnQgYW54Nzh4eF9lbmFibGVfaW50ZXJydXB0cyhzdHJ1Y3QgYW54Nzh4eAo+ ICphbng3OHh4KSByZXR1cm4gMDsKPiAgfQo+IAo+IC1zdGF0aWMgdm9pZCBhbng3OHh4X3Bvd2Vy b24oc3RydWN0IGFueDc4eHggKmFueDc4eHgpCj4gK3N0YXRpYyBpbnQgYW54Nzh4eF9wb3dlcm9u KHN0cnVjdCBhbng3OHh4ICphbng3OHh4KQo+ICB7Cj4gIAlzdHJ1Y3QgYW54Nzh4eF9wbGF0Zm9y bV9kYXRhICpwZGF0YSA9ICZhbng3OHh4LT5wZGF0YTsKPiAtCWludCBlcnI7Cj4gKwlpbnQgZXJy ID0gMDsKPiAKPiAgCWlmIChXQVJOX09OKGFueDc4eHgtPnBvd2VyZWQpKQo+IC0JCXJldHVybjsK PiArCQlyZXR1cm4gZXJyOwoKWW91IGNhbiByZXR1cm4gMCBoZXJlLgoKPiAKPiAgCWlmIChwZGF0 YS0+ZHZkZDEwKSB7Cj4gIAkJZXJyID0gcmVndWxhdG9yX2VuYWJsZShwZGF0YS0+ZHZkZDEwKTsK PiAgCQlpZiAoZXJyKSB7Cj4gIAkJCURSTV9FUlJPUigiRmFpbGVkIHRvIGVuYWJsZSBEVkREMTAg cmVndWxhdG9yOiAlZFxuIiwKPiAgCQkJCSAgZXJyKTsKPiAtCQkJcmV0dXJuOwo+ICsJCQlyZXR1 cm4gZXJyOwo+ICAJCX0KPiAKPiAgCQl1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7Cj4gQEAgLTYz OCwxMiArNjM4LDE4IEBAIHN0YXRpYyB2b2lkIGFueDc4eHhfcG93ZXJvbihzdHJ1Y3QgYW54Nzh4 eCAqYW54Nzh4eCkKPiAgCWdwaW9kX3NldF92YWx1ZV9jYW5zbGVlcChwZGF0YS0+Z3Bpb2RfcmVz ZXQsIDApOwo+IAo+ICAJLyogUG93ZXIgb24gcmVnaXN0ZXJzIG1vZHVsZSAqLwo+IC0JYW54Nzh4 eF9zZXRfYml0cyhhbng3OHh4LT5tYXBbSTJDX0lEWF9UWF9QMl0sIFNQX1BPV0VSRE9XTl9DVFJM X1JFRywKPiArCWVyciA9IGFueDc4eHhfc2V0X2JpdHMoYW54Nzh4eC0+bWFwW0kyQ19JRFhfVFhf UDJdLCBTUF9QT1dFUkRPV05fQ1RSTF9SRUcsCj4gU1BfSERDUF9QRCB8IFNQX0FVRElPX1BEIHwg U1BfVklERU9fUEQgfCBTUF9MSU5LX1BEKTsKPiAtCWFueDc4eHhfY2xlYXJfYml0cyhhbng3OHh4 LT5tYXBbSTJDX0lEWF9UWF9QMl0sIFNQX1BPV0VSRE9XTl9DVFJMX1JFRywKPiArCWVyciB8PSBh bng3OHh4X2NsZWFyX2JpdHMoYW54Nzh4eC0+bWFwW0kyQ19JRFhfVFhfUDJdLAo+IFNQX1BPV0VS RE9XTl9DVFJMX1JFRywgU1BfUkVHSVNURVJfUEQgfCBTUF9UT1RBTF9QRCk7CgpJZiBib3RoIGZ1 bmN0aW9ucyBmYWlsIHdpdGggYSBkaWZmZXJlbnQgZXJyb3IgY29kZSwgdGhpcyBtYXkgcmVzdWx0 IGluIGEgCm1lYW5pbmdsZXNzIGVycm9yIGJlaW5nIHJldHVybmVkLiBPbmUgb3B0aW9uIGlzIHRv IGRvCgoJZXJyID0gYW54Nzh4eF9zZXRfYml0cyguLi4pOwoJaWYgKCFlcnIpCgkJZXJyID0gYW54 Nzh4eF9jbGVhcl9iaXRzKC4uLik7CgpUaGUgY29uc3RydWN0IGdldHMgcXVpY2tseSB1Z2x5IHRo b3VnaCwgc28gSSBzb21ldGltZXMgZGVmaW5lIHJlZ2lzdGVyIAphY2Nlc3NvcnMgYXMgdGFraW5n IGFuIGludCAqIGZvciB0aGUgZXJyb3IgY29kZSBpbnN0ZWFkIG9mIHJldHVybmluZyBpdC4KCnZv aWQgd3JpdGUoLi4uLCBpbnQgKnN0YXR1cykKewoJaWYgKCpzdGF0dXMpCgkJcmV0dXJuOwoKCSpz dGF0dXMgPSByZWFsX3dyaXRlKC4uLik7Cn0KCmFuZCB0aGVuIHVzZSBpdCBhcwoKCWludCBzdGF0 dXMgPSAwOwoKCXdyaXRlKC4uLiwgJnN0YXR1cyk7Cgl3cml0ZSguLi4sICZzdGF0dXMpOwoJd3Jp dGUoLi4uLCAmc3RhdHVzKTsKCXdyaXRlKC4uLiwgJnN0YXR1cyk7Cgl3cml0ZSguLi4sICZzdGF0 dXMpOwoKCXJldHVybiBzdGF0dXM7CgpUaGlzIG1heSBiZSBvdmVya2lsbCBoZXJlLgoKPiArCWlm IChlcnIpIHsKPiArCQlhbng3OHh4X3Bvd2Vyb2ZmKGFueDc4eHgpOwo+ICsJCXJldHVybiBlcnI7 Cj4gKwl9Cj4gCj4gIAlhbng3OHh4LT5wb3dlcmVkID0gdHJ1ZTsKPiArCj4gKwlyZXR1cm4gZXJy OwoKQW5kIHJldHVybiAwIGhlcmUgdG9vLCByZW1vdmluZyB0aGUgbmVlZCB0byBpbml0aWFsaXpl IHRoZSBlcnIgdmFyaWFibGUgdG8gMC4KCj4gIH0KPiAKPiAgc3RhdGljIHZvaWQgYW54Nzh4eF9w b3dlcm9mZihzdHJ1Y3QgYW54Nzh4eCAqYW54Nzh4eCkKPiBAQCAtMTE0NCw3ICsxMTUwLDkgQEAg c3RhdGljIGlycXJldHVybl90IGFueDc4eHhfaHBkX3RocmVhZGVkX2hhbmRsZXIoaW50Cj4gaXJx LCB2b2lkICpkYXRhKSBtdXRleF9sb2NrKCZhbng3OHh4LT5sb2NrKTsKPiAKPiAgCS8qIENhYmxl IGlzIHB1bGxlZCwgcG93ZXIgb24gdGhlIGNoaXAgKi8KPiAtCWFueDc4eHhfcG93ZXJvbihhbng3 OHh4KTsKPiArCWVyciA9IGFueDc4eHhfcG93ZXJvbihhbng3OHh4KTsKPiArCWlmIChlcnIpCj4g KwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcG93ZXIgb24gdGhlIGNoaXA6ICVkXG4iLCBlcnIpOwoK V291bGRuJ3QgaXQgYmUgYmV0dGVyIHRvIG1vdmUgdGhlIGVycm9yIG1lc3NhZ2UgdG8gdGhlIGFu Nzh4eF9wb3dlcm9uKCkgCmZ1bmN0aW9uID8gVGhhdCB3YXkgaXQgd291bGQgYWxzbyBiZSBwcmlu dGVkIGluIHRoZSBwcm9iZSgpIHBhdGguCgo+ICAJZXJyID0gYW54Nzh4eF9lbmFibGVfaW50ZXJy dXB0cyhhbng3OHh4KTsKPiAgCWlmIChlcnIpCj4gQEAgLTEzNzksNyArMTM4Nyw5IEBAIHN0YXRp YyBpbnQgYW54Nzh4eF9pMmNfcHJvYmUoc3RydWN0IGkyY19jbGllbnQKPiAqY2xpZW50LCB9Cj4g Cj4gIAkvKiBMb29rIGZvciBzdXBwb3J0ZWQgY2hpcCBJRCAqLwo+IC0JYW54Nzh4eF9wb3dlcm9u KGFueDc4eHgpOwo+ICsJZXJyID0gYW54Nzh4eF9wb3dlcm9uKGFueDc4eHgpOwo+ICsJaWYgKGVy cikKPiArCQlnb3RvIGVycl9wb3dlcm9mZjsKCklmIHBvd2Vyb24gZmFpbHMsIGRvZXNuJ3QgaXQg Y2xlYW4gdXAgYWZ0ZXIgaXRzZWxmID8gRG8geW91IG5lZWQgdG8gY2FsbCAKcG93ZXJvZmYgaGVy ZSA/Cgo+ICAJZXJyID0gcmVnbWFwX3JlYWQoYW54Nzh4eC0+bWFwW0kyQ19JRFhfVFhfUDJdLCBT UF9ERVZJQ0VfSURMX1JFRywKPiAgCQkJICAmaWRsKTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQ aW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK