From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/5] drm/amdgpu: add ring soft recovery v2 Date: Fri, 24 Aug 2018 09:28:53 +0200 Message-ID: <317843c5-39dc-5936-9dac-a868f3cfcf70@gmail.com> References: <20180822100531.52863-1-christian.koenig@amd.com> <20180822100531.52863-2-christian.koenig@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: Alex Deucher , amd-gfx mailing list QW0gMjMuMDguMjAxOCB1bSAyMjoyMSBzY2hyaWViIE1hcmVrIE9sxaHDoWs6Cj4gT24gVGh1LCBB dWcgMjMsIDIwMTggYXQgMjo1MSBBTSBDaHJpc3RpYW4gS8O2bmlnCj4gPGNrb2VuaWcubGVpY2h0 enVtZXJrZW5AZ21haWwuY29tPiB3cm90ZToKPj4gQW0gMjIuMDguMjAxOCB1bSAyMTozMiBzY2hy aWViIE1hcmVrIE9sxaHDoWs6Cj4+PiBPbiBXZWQsIEF1ZyAyMiwgMjAxOCBhdCAxMjo1NiBQTSBB bGV4IERldWNoZXIgPGFsZXhkZXVjaGVyQGdtYWlsLmNvbT4gd3JvdGU6Cj4+Pj4gT24gV2VkLCBB dWcgMjIsIDIwMTggYXQgNjowNSBBTSBDaHJpc3RpYW4gS8O2bmlnCj4+Pj4gPGNrb2VuaWcubGVp Y2h0enVtZXJrZW5AZ21haWwuY29tPiB3cm90ZToKPj4+Pj4gSW5zdGVhZCBvZiBoYW1tZXJpbmcg aGFyZCBvbiB0aGUgR1BVIHRyeSBhIHNvZnQgcmVjb3ZlcnkgZmlyc3QuCj4+Pj4+Cj4+Pj4+IHYy OiByZW9yZGVyIGNvZGUgYSBiaXQKPj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFu IEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+Pj4+PiAtLS0KPj4+Pj4gICAgZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jICB8ICA2ICsrKysrKwo+Pj4+PiAg ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5jIHwgMjQgKysrKysrKysr KysrKysrKysrKysrKysrCj4+Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9yaW5nLmggfCAgNCArKysrCj4+Pj4+ICAgIDMgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9u cygrKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X2pvYi5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jCj4+ Pj4+IGluZGV4IDI2NWZmOTBmNGUwMS4uZDkzZTMxYTVjNGU3IDEwMDY0NAo+Pj4+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfam9iLmMKPj4+Pj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2pvYi5jCj4+Pj4+IEBAIC0zMyw2ICszMywxMiBA QCBzdGF0aWMgdm9pZCBhbWRncHVfam9iX3RpbWVkb3V0KHN0cnVjdCBkcm1fc2NoZWRfam9iICpz X2pvYikKPj4+Pj4gICAgICAgICAgIHN0cnVjdCBhbWRncHVfcmluZyAqcmluZyA9IHRvX2FtZGdw dV9yaW5nKHNfam9iLT5zY2hlZCk7Cj4+Pj4+ICAgICAgICAgICBzdHJ1Y3QgYW1kZ3B1X2pvYiAq am9iID0gdG9fYW1kZ3B1X2pvYihzX2pvYik7Cj4+Pj4+Cj4+Pj4+ICsgICAgICAgaWYgKGFtZGdw dV9yaW5nX3NvZnRfcmVjb3ZlcnkocmluZywgam9iLT52bWlkLCBzX2pvYi0+c19mZW5jZS0+cGFy ZW50KSkgewo+Pj4+PiArICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJyaW5nICVzIHRpbWVvdXQs IGJ1dCBzb2Z0IHJlY292ZXJlZFxuIiwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICBz X2pvYi0+c2NoZWQtPm5hbWUpOwo+Pj4+PiArICAgICAgICAgICAgICAgcmV0dXJuOwo+Pj4+PiAr ICAgICAgIH0KPj4+PiBJIHRoaW5rIHdlIHNob3VsZCBzdGlsbCBidWJibGUgdXAgdGhlIGVycm9y IHRvIHVzZXJzcGFjZSBldmVuIGlmIHdlCj4+Pj4gY2FuIHJlY292ZXIuICBEYXRhIGlzIGxvc3Qg d2hlbiB0aGUgd2F2ZSBpcyBraWxsZWQuICBXZSBzaG91bGQgdHJlYXQKPj4+PiBpdCBsaWtlIGEg R1BVIHJlc2V0Lgo+Pj4gWWVzLCBwbGVhc2UgaW5jcmVtZW50IGdwdV9yZXNldF9jb3VudGVyLCBz byB0aGF0IHdlIGFyZSBjb21wbGlhbnQgd2l0aAo+Pj4gT3BlbkdMLiBCZWluZyBhYmxlIHRvIHJl Y292ZXIgZnJvbSBpbmZpbml0ZSBsb29wcyBpcyBncmVhdCwgYnV0IHRlc3QKPj4+IHN1aXRlcyBh bHNvIGV4cGVjdCB0aGlzIHRvIGJlIHByb3Blcmx5IHJlcG9ydGVkIHRvIHVzZXJzcGFjZSB2aWEg dGhlCj4+PiBwZXItY29udGV4dCBxdWVyeS4KPj4gU3VyZSB0aGF0IHNob3VsZG4ndCBiZSBhIHBy b2JsZW0uCj4+Cj4+PiBBbHNvIHBsZWFzZSBidW1wIHRoZSBkZWFkbGluZSB0byAxIHNlY29uZC4g RXZlbiB5b3UgaWYgeW91IGtpbGwgYWxsCj4+PiBzaGFkZXJzLCB0aGUgSUIgY2FuIGFsc28gY29u dGFpbiBDUCBETUEsIHdoaWNoIG1heSB0YWtlIGxvbmdlciB0aGFuIDEKPj4+IG1zLgo+PiBJcyB0 aGVyZSBhbnkgd2F5IHdlIGNhbiBnZXQgYSBmZWVkYmFjayBmcm9tIHRoZSBTUSBpZiB0aGUga2ls bCB3YXMKPj4gc3VjY2Vzc2Z1bGx5Pwo+IEkgZG9uJ3QgdGhpbmsgc28uIFRoZSBraWxsIHNob3Vs ZCBiZSBmaW5pc2hlZCBwcmV0dHkgcXVpY2tseSwgYnV0IG1vcmUKPiB3YXZlcyB3aXRoIGluZmlu aXRlIGxvb3BzIG1heSBiZSB3YWl0aW5nIHRvIGJlIGxhdW5jaGVkLCBzbyB5b3Ugc3RpbGwKPiBu ZWVkIHRvIHJlcGVhdCB0aGUga2lsbCBjb21tYW5kLiBBbmQgd2Ugc2hvdWxkIGlkZWFsbHkgcmVw ZWF0IGl0IGZvciAxCj4gc2Vjb25kLgo+Cj4gVGhlIHJlYXNvbiBpcyB0aGF0IHZlcnRleCBzaGFk ZXIgd2F2ZXMgdGFrZSBhIGxvdCBvZiB0aW1lIHRvIGxhdW5jaC4gQQo+IHZlcnkgdmVyeSB2ZXJ5 IGxhcmdlIGRyYXcgY2FsbCBjYW4ga2VlcCBsYXVuY2hpbmcgbmV3IHdhdmVzIGZvciAxCj4gc2Vj b25kIHdpdGggdGhlIHNhbWUgaW5maW5pdGUgbG9vcC4gWW91IHdvdWxkIGhhdmUgdG8gc29mdC1y ZXNldCBhbGwKPiBWR1RzIHRvIHN0b3AgdGhhdC4KPgo+PiAxIHNlY29uZCBpcyB3YXkgdG8gbG9u Zywgc2luY2UgaW4gdGhlIGNhc2Ugb2YgYSBibG9ja2VkIE1DIHdlIG5lZWQgdG8KPj4gc3RhcnQg dXAgaGFyZCByZXNldCByZWxhdGl2ZSBmYXN0Lgo+IDEwIHNlY29uZHMgaGF2ZSBhbHJlYWR5IHBh c3NlZC4KClRoYXQgaXMgYSBnb29kIGFyZ3VtZW50LCBidXQgSSBzdGlsbCBmaW5kIDEgc2Vjb25k IHdheSB0byBsb25nLgoKS2VlcCBpbiBtaW5kIHRoYXQgd2UgaGFtbWVyIG9uIHRoZSBTUSBoZXJl IHRvIGtpbGwgdGhlIHdhdmVzIGFzIHNvb24gYXMgCnRoZXkgYXJlIGxhdW5jaGVkLgoKPiBJIHRo aW5rIHRoYXQgc29tZSBoYW5ncyBmcm9tIGNvcnJ1cHRlZCBkZXNjcmlwdG9ycyBtYXkgc3RpbGwg YmUKPiByZWNvdmVyYWJsZSBqdXN0IGJ5IGtpbGxpbmcgd2F2ZXMuCgpBZ3JlZWQsIGVzcGVjaWFs bHkgc2luY2UgVmVnYTEwIHRoZSBtZW1vcnkgcGF0aHMgYmVjYW1lIG11Y2ggbW9yZSByb2J1c3Qg CnRvIGVycm9yIGhhbmRsaW5nLgoKQ2hyaXN0aWFuLgoKPgo+IE1hcmVrCj4KPj4gUmVnYXJkcywK Pj4gQ2hyaXN0aWFuLgo+Pgo+Pj4gTWFyZWsKPj4+Cj4+PiBNYXJlawo+Pj4KPj4+PiBBbGV4Cj4+ Pj4KPj4+Pj4gKwo+Pj4+PiAgICAgICAgICAgRFJNX0VSUk9SKCJyaW5nICVzIHRpbWVvdXQsIHNp Z25hbGVkIHNlcT0ldSwgZW1pdHRlZCBzZXE9JXVcbiIsCj4+Pj4+ICAgICAgICAgICAgICAgICAg ICAgam9iLT5iYXNlLnNjaGVkLT5uYW1lLCBhdG9taWNfcmVhZCgmcmluZy0+ZmVuY2VfZHJ2Lmxh c3Rfc2VxKSwKPj4+Pj4gICAgICAgICAgICAgICAgICAgICByaW5nLT5mZW5jZV9kcnYuc3luY19z ZXEpOwo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3JpbmcuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmMKPj4+Pj4g aW5kZXggNWRmZDI2YmUxZWVjLi5jMDQ1YTRlMzhhZDEgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmMKPj4+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3JpbmcuYwo+Pj4+PiBAQCAtMzgzLDYgKzM4MywzMCBA QCB2b2lkIGFtZGdwdV9yaW5nX2VtaXRfcmVnX3dyaXRlX3JlZ193YWl0X2hlbHBlcihzdHJ1Y3Qg YW1kZ3B1X3JpbmcgKnJpbmcsCj4+Pj4+ICAgICAgICAgICBhbWRncHVfcmluZ19lbWl0X3JlZ193 YWl0KHJpbmcsIHJlZzEsIG1hc2ssIG1hc2spOwo+Pj4+PiAgICB9Cj4+Pj4+Cj4+Pj4+ICsvKioK Pj4+Pj4gKyAqIGFtZGdwdV9yaW5nX3NvZnRfcmVjb3ZlcnkgLSB0cnkgdG8gc29mdCByZWNvdmVy IGEgcmluZyBsb2NrdXAKPj4+Pj4gKyAqCj4+Pj4+ICsgKiBAcmluZzogcmluZyB0byB0cnkgdGhl IHJlY292ZXJ5IG9uCj4+Pj4+ICsgKiBAdm1pZDogVk1JRCB3ZSB0cnkgdG8gZ2V0IGdvaW5nIGFn YWluCj4+Pj4+ICsgKiBAZmVuY2U6IHRpbWVkb3V0IGZlbmNlCj4+Pj4+ICsgKgo+Pj4+PiArICog VHJpZXMgdG8gZ2V0IGEgcmluZyBwcm9jZWVkaW5nIGFnYWluIHdoZW4gaXQgaXMgc3R1Y2suCj4+ Pj4+ICsgKi8KPj4+Pj4gK2Jvb2wgYW1kZ3B1X3Jpbmdfc29mdF9yZWNvdmVyeShzdHJ1Y3QgYW1k Z3B1X3JpbmcgKnJpbmcsIHVuc2lnbmVkIGludCB2bWlkLAo+Pj4+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RydWN0IGRtYV9mZW5jZSAqZmVuY2UpCj4+Pj4+ICt7Cj4+Pj4+ICsg ICAgICAga3RpbWVfdCBkZWFkbGluZSA9IGt0aW1lX2FkZF91cyhrdGltZV9nZXQoKSwgMTAwMCk7 Cj4+Pj4+ICsKPj4+Pj4gKyAgICAgICBpZiAoIXJpbmctPmZ1bmNzLT5zb2Z0X3JlY292ZXJ5KQo+ Pj4+PiArICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+Pj4+PiArCj4+Pj4+ICsgICAgICAg d2hpbGUgKCFkbWFfZmVuY2VfaXNfc2lnbmFsZWQoZmVuY2UpICYmCj4+Pj4+ICsgICAgICAgICAg ICAgIGt0aW1lX3RvX25zKGt0aW1lX3N1YihkZWFkbGluZSwga3RpbWVfZ2V0KCkpKSA+IDApCj4+ Pj4+ICsgICAgICAgICAgICAgICByaW5nLT5mdW5jcy0+c29mdF9yZWNvdmVyeShyaW5nLCB2bWlk KTsKPj4+Pj4gKwo+Pj4+PiArICAgICAgIHJldHVybiBkbWFfZmVuY2VfaXNfc2lnbmFsZWQoZmVu Y2UpOwo+Pj4+PiArfQo+Pj4+PiArCj4+Pj4+ICAgIC8qCj4+Pj4+ICAgICAqIERlYnVnZnMgaW5m bwo+Pj4+PiAgICAgKi8KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9yaW5nLmggYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmlu Zy5oCj4+Pj4+IGluZGV4IDQwOWZkZDliOTcxMC4uOWNjMjM5OTY4ZTQwIDEwMDY0NAo+Pj4+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcmluZy5oCj4+Pj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9yaW5nLmgKPj4+Pj4gQEAgLTE2OCw2 ICsxNjgsOCBAQCBzdHJ1Y3QgYW1kZ3B1X3JpbmdfZnVuY3Mgewo+Pj4+PiAgICAgICAgICAgLyog cHJpb3JpdHkgZnVuY3Rpb25zICovCj4+Pj4+ICAgICAgICAgICB2b2lkICgqc2V0X3ByaW9yaXR5 KSAoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nLAo+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGVudW0gZHJtX3NjaGVkX3ByaW9yaXR5IHByaW9yaXR5KTsKPj4+Pj4gKyAgICAg ICAvKiBUcnkgdG8gc29mdCByZWNvdmVyIHRoZSByaW5nIHRvIG1ha2UgdGhlIGZlbmNlIHNpZ25h bCAqLwo+Pj4+PiArICAgICAgIHZvaWQgKCpzb2Z0X3JlY292ZXJ5KShzdHJ1Y3QgYW1kZ3B1X3Jp bmcgKnJpbmcsIHVuc2lnbmVkIHZtaWQpOwo+Pj4+PiAgICB9Owo+Pj4+Pgo+Pj4+PiAgICBzdHJ1 Y3QgYW1kZ3B1X3Jpbmcgewo+Pj4+PiBAQCAtMjYwLDYgKzI2Miw4IEBAIHZvaWQgYW1kZ3B1X3Jp bmdfZmluaShzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJpbmcpOwo+Pj4+PiAgICB2b2lkIGFtZGdwdV9y aW5nX2VtaXRfcmVnX3dyaXRlX3JlZ193YWl0X2hlbHBlcihzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJp bmcsCj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdWludDMyX3QgcmVnMCwgdWludDMyX3QgdmFsMCwKPj4+Pj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCByZWcxLCB1aW50MzJfdCB2 YWwxKTsKPj4+Pj4gK2Jvb2wgYW1kZ3B1X3Jpbmdfc29mdF9yZWNvdmVyeShzdHJ1Y3QgYW1kZ3B1 X3JpbmcgKnJpbmcsIHVuc2lnbmVkIGludCB2bWlkLAo+Pj4+PiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc3RydWN0IGRtYV9mZW5jZSAqZmVuY2UpOwo+Pj4+Pgo+Pj4+PiAgICBzdGF0 aWMgaW5saW5lIHZvaWQgYW1kZ3B1X3JpbmdfY2xlYXJfcmluZyhzdHJ1Y3QgYW1kZ3B1X3Jpbmcg KnJpbmcpCj4+Pj4+ICAgIHsKPj4+Pj4gLS0KPj4+Pj4gMi4xNC4xCj4+Pj4+Cj4+Pj4+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+Pj4+IGFtZC1nZngg bWFpbGluZyBsaXN0Cj4+Pj4+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+Pj4+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+Pj4+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+Pj4gYW1k LWdmeCBtYWlsaW5nIGxpc3QKPj4+PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+Pj4+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gYW1kLWdm eCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==