From: Oscar Mateo Subject: Re: [PATCH 4/5] drm/i915/icl/huc: Correctly authenticate the HuC for Icelake Date: Tue, 8 May 2018 14:36:51 -0700 Message-ID: <317917f4-9c6b-8197-3206-45ffec032504@intel.com> References: <1525287804-2071-1-git-send-email-oscar.mateo@intel.com> <1525287804-2071-5-git-send-email-oscar.mateo@intel.com> <1525472778.3618.13.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C18916EBAF for ; Tue, 8 May 2018 21:36:44 +0000 (UTC) In-Reply-To: <1525472778.3618.13.camel@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Spotswood , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwNS8wNC8yMDE4IDAzOjI2IFBNLCBKb2huIFNwb3Rzd29vZCB3cm90ZToKPiBPbiBXZWQs IDIwMTgtMDUtMDIgYXQgMTI6MDMgLTA3MDAsIE9zY2FyIE1hdGVvIHdyb3RlOgo+PiBUaGUgcmVn aXN0ZXIgdG8gY2hlY2sgZm9yIGNvcnJlY3QgSHVDIGF1dGhlbnRpY2F0aW9uIGJ5IHRoZSBHdUMK Pj4gaGFzIGNoYW5nZWQgaW4gSWNlbGFrZS4gTG9vayBpbnRvIHRoZSByaWdodCByZWdpc3RlciAm IGJpdC4KPj4KPj4gdjI6IHJlYmFzZWQuCj4+IHYzOiByZWJhc2VkLgo+PiB2NDogRml4IEk5MTVf UEFSQU1fSFVDX1NUQVRVUyBhcyB3ZWxsIChUb255KQo+PiB2NTogRml4IGR1cGxpY2F0ZSBDYwo+ Pgo+PiBCU3BlYzogMTk2ODYKPj4KPj4gU2lnbmVkLW9mZi1ieTogT3NjYXIgTWF0ZW8gPG9zY2Fy Lm1hdGVvQGludGVsLmNvbT4KPj4gQ2M6IFRvbnkgWWUgPHRvbnkueWVAaW50ZWwuY29tPgo+PiBD YzogVmluYXkgQmVsZ2F1bWthciA8dmluYXkuYmVsZ2F1bWthckBpbnRlbC5jb20+Cj4+IENjOiBN aWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+PiBDYzogTWljaGFsIFdh amRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4+IENjOiBKb2huIFNwb3Rzd29v ZCA8am9obi5hLnNwb3Rzd29vZEBpbnRlbC5jb20+Cj4+IENjOiBBbnVzaGEgU3JpdmF0c2EgPGFu dXNoYS5zcml2YXRzYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgwqBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfcmVnLmggfMKgwqAzICsrKwo+PiAgwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9odWMuY8KgwqDCoMKgwqB8IDIzICsrKysrKysrKysrKysrKysrKystLS0tCj4+ICDCoDIg ZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19yZWcuaAo+PiBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19yZWcuaAo+PiBpbmRleCBkODYwODQ3Li45ZjE0Zjlm IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfcmVnLmgKPj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3JlZy5oCj4+IEBAIC03Niw2ICs3 Niw5IEBACj4+ICDCoCNkZWZpbmUgSFVDX1NUQVRVUzLCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oF9NTUlPKDB4RDNCMCkKPj4gIMKgI2RlZmluZcKgwqDCoEhVQ19GV19WRVJJRklFRMKgwqDCoMKg wqDCoMKgKDE8PDcpCj4+ICAgCj4+ICsjZGVmaW5lIEhVQ19LRVJORUxfTE9BRF9JTkZPCV9NTUlP KDB4QzFEQykKPj4gKyNkZWZpbmXCoMKgwqBIVUNfTE9BRF9TVUNDRVNTRlVMCSgxIDw8IDApCj4+ ICsKPj4gIMKgI2RlZmluZSBHVUNfV09QQ01fU0laRQkJCV9NTUlPKDB4YzA1MCkKPj4gIMKgI2Rl ZmluZcKgwqDCoEdVQ19XT1BDTV9TSVpFX0xPQ0tFRAkJwqDCoCgxPDwwKQo+PiAgwqAjZGVmaW5l wqDCoMKgR1VDX1dPUENNX1NJWkVfU0hJRlQJCTEyCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9odWMuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2h1 Yy5jCj4+IGluZGV4IDI5MTI4NTIuLmI1MDk3NTYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2h1Yy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2h1Yy5jCj4+IEBAIC00OCw5ICs0OCwxOSBAQCBpbnQgaW50ZWxfaHVjX2F1dGgoc3RydWN0IGlu dGVsX2h1YyAqaHVjKQo+PiAgwqAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSBodWNf dG9faTkxNShodWMpOwo+PiAgwqAJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gJmk5MTUtPmd1YzsK Pj4gIMKgCXN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+PiArCWk5MTVfcmVnX3Qgc3RhdHVzX3JlZzsK Pj4gIMKgCXUzMiBzdGF0dXM7Cj4+ICsJdTMyIHN0YXR1c19vazsKPj4gIMKgCWludCByZXQ7Cj4+ ICAgCj4+ICsJaWYgKElOVEVMX0dFTihpOTE1KSA+PSAxMSkgewo+PiArCQlzdGF0dXNfcmVnID0g SFVDX0tFUk5FTF9MT0FEX0lORk87Cj4+ICsJCXN0YXR1c19vayA9IEhVQ19MT0FEX1NVQ0NFU1NG VUw7Cj4+ICsJfSBlbHNlIHsKPj4gKwkJc3RhdHVzX3JlZyA9IEhVQ19TVEFUVVMyOwo+PiArCQlz dGF0dXNfb2sgPSBIVUNfRldfVkVSSUZJRUQ7Cj4+ICsJfQo+PiArCj4+ICDCoAlpZiAoaHVjLT5m dy5sb2FkX3N0YXR1cyAhPSBJTlRFTF9VQ19GSVJNV0FSRV9TVUNDRVNTKQo+PiAgwqAJCXJldHVy biAtRU5PRVhFQzsKPj4gICAKPj4gQEAgLTcyLDkgKzgyLDkgQEAgaW50IGludGVsX2h1Y19hdXRo KHN0cnVjdCBpbnRlbF9odWMgKmh1YykKPj4gICAKPj4gIMKgCS8qIENoZWNrIGF1dGhlbnRpY2F0 aW9uIHN0YXR1cywgaXQgc2hvdWxkIGJlIGRvbmUgYnkgbm93ICovCj4+ICDCoAlyZXQgPSBfX2lu dGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGk5MTUsCj4+IC0JCQkJCUhVQ19TVEFUVVMyLAo+PiAtCQkJ CQlIVUNfRldfVkVSSUZJRUQsCj4+IC0JCQkJCUhVQ19GV19WRVJJRklFRCwKPj4gKwkJCQkJc3Rh dHVzX3JlZywKPj4gKwkJCQkJc3RhdHVzX29rLAo+PiArCQkJCQlzdGF0dXNfb2ssCj4+ICDCoAkJ CQkJMiwgNTAsICZzdGF0dXMpOwo+IE1pbm9yIHF1ZXN0aW9uOiDCoFlvdSBhcmUgY2hlY2tpbmcg ZGlmZmVyZW50IHJlZ2lzdGVycyBkZXBlbmRpbmcgb24gZ2VuLgo+ICDCoFdpbGwgdGhlIGZhc3Qg YW5kIHNsb3cgdGltZW91dCB2YWx1ZXMgYXBwbHkgZXF1YWxseSB0byBib3RoIHNpdHVhdGlvbnMK PiA/CgpBRkFJQ1QsIHRoZSBwcm9jZXNzIHRvIGF1dGhlbnRpY2F0ZSB0aGUgSHVDIGhhcyBub3Qg Y2hhbmdlZCwgYW5kIHRoZSAKb25seSBkaWZmZXJlbmNlIGlzIHdoaWNoIHJlZ2lzdGVyIHRvIHVz ZSB0byBjaGVjayB0aGUgcmVzdWx0LiBJZiB0aGUgCnRpbWVvdXQgdmFsdWVzIHdlcmUgZmluZSBi ZWZvcmUsIHRoZXkgc2hvdWxkIGJlIGZpbmUgbm93Li4uCgo+Cj4+ICDCoAlpZiAocmV0KSB7Cj4+ ICDCoAkJRFJNX0VSUk9SKCJIdUM6IEZpcm13YXJlIG5vdCB2ZXJpZmllZCAlI3hcbiIsCj4+IHN0 YXR1cyk7Cj4+IEBAIC0xMTIsNyArMTIyLDEyIEBAIGludCBpbnRlbF9odWNfY2hlY2tfc3RhdHVz KHN0cnVjdCBpbnRlbF9odWMKPj4gKmh1YykKPj4gIMKgCQlyZXR1cm4gLUVOT0RFVjsKPj4gICAK Pj4gIMKgCWludGVsX3J1bnRpbWVfcG1fZ2V0KGRldl9wcml2KTsKPj4gLQlzdGF0dXMgPSBJOTE1 X1JFQUQoSFVDX1NUQVRVUzIpICYgSFVDX0ZXX1ZFUklGSUVEOwo+PiArCj4+ICsJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPj0gMTEpCj4+ICsJCXN0YXR1cyA9IEk5MTVfUkVBRChIVUNfS0VSTkVM X0xPQURfSU5GTykgJgo+PiBIVUNfTE9BRF9TVUNDRVNTRlVMOwo+PiArCWVsc2UKPj4gKwkJc3Rh dHVzID0gSTkxNV9SRUFEKEhVQ19TVEFUVVMyKSAmIEhVQ19GV19WRVJJRklFRDsKPj4gKwo+PiAg wqAJaW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+PiAgIAo+PiAgwqAJcmV0dXJuIHN0 YXR1czsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=