Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE26C433E0 for ; Tue, 16 Mar 2021 11:35:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D2B5065027 for ; Tue, 16 Mar 2021 11:35:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2B5065027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0699D6B006C; Tue, 16 Mar 2021 07:35:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 018E76B006E; Tue, 16 Mar 2021 07:34:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD4E46B0070; Tue, 16 Mar 2021 07:34:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id BD27F6B006C for ; Tue, 16 Mar 2021 07:34:59 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 83FF46C0A for ; Tue, 16 Mar 2021 11:34:59 +0000 (UTC) X-FDA: 77925530718.03.BD0EFB1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 920CF2000393 for ; Tue, 16 Mar 2021 11:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615894498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vlqsbtT9COsx+yKS+e8hs6ZYyJT5eXMndMhYe5Gjdjo=; b=R+2zHPrADmSjEV0TfZaTEpcE38N+dEVYkkbLqfHwl9f7TGVyTpKrrn9Wv7BWYOLhBc2HpK jUHvraCAsGGw8cJ9X09FwxWCCCFxXvU6CxuUSm6rCkQP8hwuReHdGp6khDm3FGEdvCaHdc 5+FheQDCyXtdRvEOFiVeY7vInC0H6Ck= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-498-Q4Hxl9DtPsqAVRmB4OjmRQ-1; Tue, 16 Mar 2021 07:34:54 -0400 X-MC-Unique: Q4Hxl9DtPsqAVRmB4OjmRQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 052CE193F561; Tue, 16 Mar 2021 11:34:52 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-152.rdu2.redhat.com [10.10.118.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 96C3C60C0F; Tue, 16 Mar 2021 11:34:45 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <161539537375.286939.16642940088716990995.stgit@warthog.procyon.org.uk> References: <161539537375.286939.16642940088716990995.stgit@warthog.procyon.org.uk> <161539526152.286939.8589700175877370401.stgit@warthog.procyon.org.uk> To: Trond Myklebust Cc: dhowells@redhat.com, Anna Schumaker , Steve French , Dominique Martinet , Jeff Layton , Matthew Wilcox , linux-mm@kvack.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, David Wysochanski , Alexander Viro , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 08/28] netfs: Provide readahead and readpage netfs helpers MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3184203.1615894484.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 16 Mar 2021 11:34:44 +0000 Message-ID: <3184204.1615894484@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 920CF2000393 X-Stat-Signature: thutmpxaaa9b4c7zf5x67azisfmqgq9k Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615894498-941368 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I'm going to make the code generate more information when warning about a subread reporting having over-read (see attached). David --- diff --git a/fs/netfs/read_helper.c b/fs/netfs/read_helper.c index ce11ca4c32e4..765e88ee132d 100644 --- a/fs/netfs/read_helper.c +++ b/fs/netfs/read_helper.c @@ -641,7 +641,10 @@ void netfs_subreq_terminated(struct netfs_read_subreq= uest *subreq, goto failed; } = - if (WARN_ON(transferred_or_error > subreq->len - subreq->transferred)) + if (WARN(transferred_or_error > subreq->len - subreq->transferred, + "R%x[%x] %zd > %zu - %zu", + rreq->debug_id, subreq->debug_index, + transferred_or_error, subreq->len, subreq->transferred)) transferred_or_error =3D subreq->len - subreq->transferred; = subreq->error =3D 0;