References: <20190403225657.8003-1-rosenp@...277...> From: Arne Schwabe Message-ID: <318a10cc-4521-232c-0909-e824b3ce9a9b@...1227...> Date: Fri, 12 Jul 2019 18:44:06 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: de-DE Subject: Re: [Openvpn-devel] [PATCHv2] openssl: Fix compilation without deprecated OpenSSL 1.1 APIs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Matthias Andree , openvpn-devel@lists.sourceforge.net Am 12.07.19 um 18:37 schrieb Matthias Andree: > Am 14.06.19 um 12:38 schrieb Arne Schwabe: >> >>> -#ifndef ENABLE_SMALL >>> +# ifndef ENABLE_SMALL >> The space between # and ifndef looks wrong. > > It's standard C. (Chapter 3.8 in the 1989/1990 standard, chapter 6.10 in > recent editions, I checked 1999 and 2017/2018, although worded in a > quite convoluted way) and I have yet to see a relevant C compiler that > would reject this. I know :). Looks "wrong" in the sense that it does not match the style we want to have in openvpn.