Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A238C433E6 for ; Thu, 11 Feb 2021 09:29:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B562664E02 for ; Thu, 11 Feb 2021 09:29:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbhBKJ31 (ORCPT ); Thu, 11 Feb 2021 04:29:27 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57936 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbhBKJ1A (ORCPT ); Thu, 11 Feb 2021 04:27:00 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 11B9CxOT006033 for ; Thu, 11 Feb 2021 04:25:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=nx8LG6uRISsryiHNA4tPMB0EHydzgThcPVm0BrBzETY=; b=HUUqZY9PEV3m9FSmWiFjerxwxR060xm4cSY8HFHzAPxfY/+DhK+HLsVxM6Uemw426Nnl apunA5gnerM48yv03YN7FrYW/k0pETgj7KA7JyPpygRIz/EqGngkvb0TiAZzVJKoEIpL 2lfW7vpFD0u8X3M33lH5doZH/EZRT9P0YlwfoAnGIEAorKnUXoofR9XJOcalsCdJ9Fdw W5f0kU0ykD/tvDSdVZqeFFMuuMWvqQYWHfbYjfVkFcETDyp6nTToPY1CyqA0IQ+6H7UK 6B1z+Ahsw0rEsz84PrpB3wUGc/PxEmQsHbfTATjvQGh0wrXU7NuszqxbdkhmMM2320v1 Ig== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 36n1rk8c12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 11 Feb 2021 04:25:48 -0500 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 11B9CtLO005908 for ; Thu, 11 Feb 2021 04:25:47 -0500 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 36n1rk8c03-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Feb 2021 04:25:47 -0500 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11B9DZSg022949; Thu, 11 Feb 2021 09:25:45 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma02fra.de.ibm.com with ESMTP id 36hjr8awug-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Feb 2021 09:25:45 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11B9PgmU42991890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Feb 2021 09:25:42 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 36EE5AE059; Thu, 11 Feb 2021 09:25:42 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C0B4CAE055; Thu, 11 Feb 2021 09:25:41 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.64.239]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 11 Feb 2021 09:25:41 +0000 (GMT) Subject: Re: [kvm-unit-tests PATCH v1 3/3] s390x: mvpg: simple test To: Claudio Imbrenda , kvm@vger.kernel.org Cc: david@redhat.com, thuth@redhat.com, cohuck@redhat.com, pmorel@linux.ibm.com, borntraeger@de.ibm.com References: <20210209185154.1037852-1-imbrenda@linux.ibm.com> <20210209185154.1037852-4-imbrenda@linux.ibm.com> From: Janosch Frank Message-ID: <31954d68-bd2c-d803-5796-20de29930eb2@linux.ibm.com> Date: Thu, 11 Feb 2021 10:25:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210209185154.1037852-4-imbrenda@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-11_05:2021-02-10,2021-02-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 adultscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102110076 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2/9/21 7:51 PM, Claudio Imbrenda wrote: > A simple unit test for the MVPG instruction. > > The timeout is set to 10 seconds because the test should complete in a > fraction of a second even on busy machines. If the test is run in VSIE > and the host of the host is not handling MVPG properly, the test will > probably hang. > > Testing MVPG behaviour in VSIE is the main motivation for this test. > > Anything related to storage keys is not tested. > > Signed-off-by: Claudio Imbrenda Acked-by: Janosch Frank > --- > s390x/Makefile | 1 + > s390x/mvpg.c | 266 ++++++++++++++++++++++++++++++++++++++++++++ > s390x/unittests.cfg | 4 + > 3 files changed, 271 insertions(+) > create mode 100644 s390x/mvpg.c > > diff --git a/s390x/Makefile b/s390x/Makefile > index 08d85c9f..770eaa0b 100644 > --- a/s390x/Makefile > +++ b/s390x/Makefile > @@ -20,6 +20,7 @@ tests += $(TEST_DIR)/sclp.elf > tests += $(TEST_DIR)/css.elf > tests += $(TEST_DIR)/uv-guest.elf > tests += $(TEST_DIR)/sie.elf > +tests += $(TEST_DIR)/mvpg.elf > > tests_binary = $(patsubst %.elf,%.bin,$(tests)) > ifneq ($(HOST_KEY_DOCUMENT),) > diff --git a/s390x/mvpg.c b/s390x/mvpg.c > new file mode 100644 > index 00000000..fe6fe80a > --- /dev/null > +++ b/s390x/mvpg.c > @@ -0,0 +1,266 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Move Page instruction tests > + * > + * Copyright (c) 2020 IBM Corp > + * > + * Authors: > + * Claudio Imbrenda > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* Used to build the appropriate test values for register 0 */ > +#define KFC(x) ((x) << 10) > +#define CCO 0x100 > + > +/* How much memory to allocate for the test */ > +#define MEM_ORDER 12 > +/* How many iterations to perform in the loops */ > +#define ITER 8 > + > +/* Used to generate the simple pattern */ > +#define MAGIC 42 > + > +static uint8_t source[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); > +static uint8_t buffer[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE))); > + > +/* Keep track of fresh memory */ > +static uint8_t *fresh; > + > +static inline int mvpg(unsigned long r0, void *dest, void *src) > +{ > + register unsigned long reg0 asm ("0") = r0; > + int cc; > + > + asm volatile(" mvpg %1,%2\n" > + " ipm %0\n" > + " srl %0,28" > + : "=&d" (cc) : "a" (dest), "a" (src), "d" (reg0) > + : "memory", "cc"); > + return cc; > +} > + > +/* > + * Initialize a page with a simple pattern > + */ > +static void init_page(uint8_t *p) > +{ > + int i; > + > + for (i = 0; i < PAGE_SIZE; i++) > + p[i] = i + MAGIC; > +} > + > +/* > + * Check if the given page contains the simple pattern > + */ > +static int page_ok(const uint8_t *p) > +{ > + int i; > + > + for (i = 0; i < PAGE_SIZE; i++) > + if (p[i] != (uint8_t)(i + MAGIC)) > + return 0; > + return 1; > +} > + > +static void test_exceptions(void) > +{ > + int i, expected; > + > + report_prefix_push("exceptions"); > + > + /* > + * Key Function Control values 4 and 5 are allowed only in supervisor > + * state, and even then, only if the move-page-and-set-key facility > + * is present (STFLE bit 149) > + */ > + report_prefix_push("privileged"); > + if (test_facility(149)) { > + expected = PGM_INT_CODE_PRIVILEGED_OPERATION; > + for (i = 4; i < 6; i++) { > + expect_pgm_int(); > + enter_pstate(); > + mvpg(KFC(i), buffer, source); > + report(is_pgm(expected), "Key Function Control value %d", i); > + } > + } else { > + report_skip("Key Function Control value %d", 4); > + report_skip("Key Function Control value %d", 5); > + i = 4; > + } > + report_prefix_pop(); > + > + /* > + * Invalid values of the Key Function Control, or setting the > + * reserved bits, should result in a specification exception > + */ > + report_prefix_push("specification"); > + expected = PGM_INT_CODE_SPECIFICATION; > + expect_pgm_int(); > + mvpg(KFC(3), buffer, source); > + report(is_pgm(expected), "Key Function Control value 3"); > + for (; i < 32; i++) { > + expect_pgm_int(); > + mvpg(KFC(i), buffer, source); > + report(is_pgm(expected), "Key Function Control value %d", i); > + } > + report_prefix_pop(); > + > + /* Operands outside memory result in addressing exceptions, as usual */ > + report_prefix_push("addressing"); > + expected = PGM_INT_CODE_ADDRESSING; > + expect_pgm_int(); > + mvpg(0, buffer, (void *)PAGE_MASK); > + report(is_pgm(expected), "Second operand outside memory"); > + > + expect_pgm_int(); > + mvpg(0, (void *)PAGE_MASK, source); > + report(is_pgm(expected), "First operand outside memory"); > + report_prefix_pop(); > + > + report_prefix_pop(); > +} > + > +static void test_success(void) > +{ > + int cc; > + > + report_prefix_push("success"); > + /* Test successful scenarios, both in supervisor and problem state */ > + cc = mvpg(0, buffer, source); > + report(page_ok(buffer) && !cc, "Supervisor state MVPG successful"); > + > + enter_pstate(); > + cc = mvpg(0, buffer, source); > + leave_pstate(); > + report(page_ok(buffer) && !cc, "Problem state MVPG successful"); > + > + report_prefix_pop(); > +} > + > +static void test_small_loop(const void *string) > +{ > + uint8_t *dest; > + int i, cc; > + > + /* Looping over cold and warm pages helps catch VSIE bugs */ > + report_prefix_push(string); > + dest = fresh; > + for (i = 0; i < ITER; i++) { > + cc = mvpg(0, fresh, source); > + report(page_ok(fresh) && !cc, "cold: %p, %p", source, fresh); > + fresh += PAGE_SIZE; > + } > + > + for (i = 0; i < ITER; i++) { > + memset(dest, 0, PAGE_SIZE); > + cc = mvpg(0, dest, source); > + report(page_ok(dest) && !cc, "warm: %p, %p", source, dest); > + dest += PAGE_SIZE; > + } > + report_prefix_pop(); > +} > + > +static void test_mmu_prot(void) > +{ > + int cc; > + > + report_prefix_push("protection"); > + report_prefix_push("cco=0"); > + > + /* MVPG should still succeed when the source is read-only */ > + protect_page(source, PAGE_ENTRY_P); > + cc = mvpg(0, fresh, source); > + report(page_ok(fresh) && !cc, "source read only"); > + unprotect_page(source, PAGE_ENTRY_P); > + fresh += PAGE_SIZE; > + > + /* > + * When the source or destination are invalid, a page translation > + * exception should be raised; when the destination is read-only, > + * a protection exception should be raised. > + */ > + protect_page(fresh, PAGE_ENTRY_P); > + expect_pgm_int(); > + mvpg(0, fresh, source); > + report(is_pgm(PGM_INT_CODE_PROTECTION), "destination read only"); > + fresh += PAGE_SIZE; > + > + protect_page(source, PAGE_ENTRY_I); > + expect_pgm_int(); > + mvpg(0, fresh, source); > + report(is_pgm(PGM_INT_CODE_PAGE_TRANSLATION), "source invalid"); > + unprotect_page(source, PAGE_ENTRY_I); > + fresh += PAGE_SIZE; > + > + protect_page(fresh, PAGE_ENTRY_I); > + expect_pgm_int(); > + mvpg(0, fresh, source); > + report(is_pgm(PGM_INT_CODE_PAGE_TRANSLATION), "destination invalid"); > + fresh += PAGE_SIZE; > + > + report_prefix_pop(); > + report_prefix_push("cco=1"); > + /* > + * Setting the CCO bit should suppress page translation exceptions, > + * but not protection exceptions. > + */ > + protect_page(fresh, PAGE_ENTRY_P); > + expect_pgm_int(); > + mvpg(CCO, fresh, source); > + report(is_pgm(PGM_INT_CODE_PROTECTION), "destination read only"); > + fresh += PAGE_SIZE; > + > + protect_page(fresh, PAGE_ENTRY_I); > + cc = mvpg(CCO, fresh, source); > + report(cc == 1, "destination invalid"); > + fresh += PAGE_SIZE; > + > + protect_page(source, PAGE_ENTRY_I); > + cc = mvpg(CCO, fresh, source); > + report(cc == 2, "source invalid"); > + fresh += PAGE_SIZE; > + > + protect_page(fresh, PAGE_ENTRY_I); > + cc = mvpg(CCO, fresh, source); > + report(cc == 2, "source and destination invalid"); > + fresh += PAGE_SIZE; > + > + unprotect_page(source, PAGE_ENTRY_I); > + report_prefix_pop(); > + report_prefix_pop(); > +} > + > +int main(void) > +{ > + report_prefix_push("mvpg"); > + > + init_page(source); > + fresh = alloc_pages_flags(MEM_ORDER, FLAG_DONTZERO | FLAG_FRESH); > + assert(fresh); > + > + test_exceptions(); > + test_success(); > + test_small_loop("nommu"); > + > + setup_vm(); > + > + test_small_loop("mmu"); > + test_mmu_prot(); > + > + report_prefix_pop(); > + return report_summary(); > +} > diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg > index 2298be6c..9f81a608 100644 > --- a/s390x/unittests.cfg > +++ b/s390x/unittests.cfg > @@ -99,3 +99,7 @@ file = uv-guest.elf > > [sie] > file = sie.elf > + > +[mvpg] > +file = mvpg.elf > +timeout = 10 >