From: "flichtenheld (Code Review)" Date: Tue, 9 Jan 2024 13:42:47 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <31a7e3d1d3b5651bc34a7f6c57bcec0f772e37ff-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="34rVijUDtWg="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: cron2 , plaisthos , openvpn-devel --34rVijUDtWg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/489?usp=3Demail ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 1: (2 comments) File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/489/comment/9ab5407d_5fbd4418 : PS1, Line 357: Push this flag to defend against the TunnelCrack attac= ks. > Agree not to explain TunnelCrack in the openvpn man page, but then refere= nces are not much of a thin [=E2=80=A6] Most terminals handle links sensibly these days. Also we publish this as HT= ML documentation. We already have existing http links in the document. So a= dding a link would probably not be a bad idea. How about: "Push this flag to protect against attacks where the attacker tries to tric= ks the client into accessing services through a public network instead of t= he VPN (See e.g. https://tunnelcrack.mathyvanhoef.com/)." File src/openvpn/win32.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/70f36809_aae74546 : PS1, Line 1225: if (ret =3D=3D false) > We need to set ret as return value anyway, so doing it before the if is m= ore readable IMHO compared [=E2=80=A6] Right, but you could just replace the "got out" with "return false" anyway. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 1 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: d12fk Gerrit-Comment-Date: Tue, 09 Jan 2024 13:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: d12fk Gerrit-MessageType: comment --34rVijUDtWg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, d12fk, plaisthos.

View C= hange

2 comments:

    =
  • File doc/man-sections/vpn-network-o= ptions.rst:

    • Patch S= et #1, Line 357: = Push this flag to defend against the TunnelCrack attacks.

      Agree not to explain TunnelCrack in the openvpn man page, but then ref= erences are not much of a thin [=E2=80=A6]

      Most terminals handle links sens= ibly these days. Also we publish this as HTML documentation. We already hav= e existing http links in the document. So adding a link would probably not = be a bad idea. How about:

      "Push this flag to protect against attacks where the atta= cker tries to tricks the client into accessing services through a public ne= twork instead of the VPN (See e.g. https://tunnelcrack.mathyvanhoef.com/).&= quot;

  • File src/op= envpn/win32.c:

    • Pa= tch Set #1, Line 1225: = if (ret =3D=3D false)

      We need to set ret as retur= n value anyway, so doing it before the if is more readable IMHO compared [= =E2=80=A6]

      Right, but you could just replace the "got out" with &= quot;return false" anyway.

To view, visit change 489<= /a>. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f= 071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Tue, 09 Jan 2024 13:42:47= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: d12fk <heiko@...515...= >
Gerrit-MessageType: comment
--34rVijUDtWg=--