Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF0DCC54FCB for ; Mon, 27 Apr 2020 15:41:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F43220656 for ; Mon, 27 Apr 2020 15:41:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F43220656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jT5s3-0007PV-UD; Mon, 27 Apr 2020 15:40:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jT5s2-0007PQ-MB for xen-devel@lists.xenproject.org; Mon, 27 Apr 2020 15:40:34 +0000 X-Inumbo-ID: 6e679fbe-889d-11ea-97b2-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6e679fbe-889d-11ea-97b2-12813bfff9fa; Mon, 27 Apr 2020 15:40:33 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7DD4DACBD; Mon, 27 Apr 2020 15:40:31 +0000 (UTC) Subject: Re: [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem To: Stefano Stabellini References: <20200402154616.16927-1-jgross@suse.com> <20200402154616.16927-9-jgross@suse.com> <19f84540-6b49-f99d-805a-e07f56330f31@suse.com> <17d65095-a51e-2e00-38ee-7c1c83d2bb99@suse.com> <51e0f0d2-f9ce-83fd-79fa-ae4805356612@suse.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <31c7f4fe-847c-96f5-e598-dba99b0bb61a@suse.com> Date: Mon, 27 Apr 2020 17:40:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <51e0f0d2-f9ce-83fd-79fa-ae4805356612@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Jan Beulich , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Stefano, On 06.04.20 14:29, Jan Beulich wrote: > On 03.04.2020 17:45, Jürgen Groß wrote: >> On 03.04.20 17:33, Jan Beulich wrote: >>> On 03.04.2020 17:12, Jürgen Groß wrote: >>>> On 03.04.20 16:31, Jan Beulich wrote: >>>>> On 02.04.2020 17:46, Juergen Gross wrote: >>>>>> --- a/xen/common/Kconfig >>>>>> +++ b/xen/common/Kconfig >>>>>> @@ -353,6 +353,16 @@ config DOM0_MEM >>>>>>           Leave empty if you are not sure what to specify. >>>>>>   +config HYPFS_CONFIG >>>>>> +    bool "Provide hypervisor .config via hypfs entry" >>>>>> +    default y >>>>> >>>>> My initial reaction was to ask for "depends on HYPFS", but then >>>>> I noticed the earlier patch doesn't introduce such. Am I >>>>> mis-remembering that it was agreed to make the whole thing >>>>> possible to disable at least in EXPERT mode? >>>> >>>> No, I don't remember that agreement. >>>> >>>> And TBH I'm not sure this is a good idea, as that would at once make the >>>> plan to replace at least some sysctl and/or domctl interfaces impossible >>>> (like e.g. the last 3 patches of the series are doing already), or at >>>> least would tie the related functionality to CONFIG_HYPFS. >>> >>> I think that would be fine - that's what config setting are for. >>> Someone caring about space may not care about runtime setting of >>> parameters. >> >> So right now it would start with a plain hypfs available or not. >> >> The next step would be in patch 12 to tell the user he will lose the >> capability of setting runtime parameters. >> >> Another planned extension would be to control per-cpupool settings, >> which would the go away (possibly functionality being unconditionally >> available today). >> >> Next would be the lack of being able to control per-domain mitigations >> like XPTI or L1TF, which I'd like to add. >> >> Another thing I wanted to add is some debugging stuff (e.g. to switch >> lock profiling using hypfs). >> >> And the list will go on. > > Understood. > >> Does it really make sense to make a central control and information >> interface conditional? > > None of the above may be of interest to e.g. embedded use cases. > >> I'd like at least a second opinion on that topic. > > Yes, further opinions would surely help. Any opinion on making hypfs configurable? It would be quite some code churn and I want to avoid it in case you see no benefit in configuring it out for embedded. Juergen