Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BA1C282C8 for ; Mon, 28 Jan 2019 14:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BC5C20449 for ; Mon, 28 Jan 2019 14:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726848AbfA1O2s (ORCPT ); Mon, 28 Jan 2019 09:28:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57074 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbfA1O2r (ORCPT ); Mon, 28 Jan 2019 09:28:47 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA941C058CB7; Mon, 28 Jan 2019 14:28:47 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-128.rdu2.redhat.com [10.10.120.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DB2B627DF; Mon, 28 Jan 2019 14:28:45 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190128140426.GA7268@kadam> References: <20190128140426.GA7268@kadam> To: Dan Carpenter Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [bug report] smack: Implement filesystem context security hooks MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32005.1548685725.1@warthog.procyon.org.uk> Date: Mon, 28 Jan 2019 14:28:45 +0000 Message-ID: <32006.1548685725@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 28 Jan 2019 14:28:47 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Dan Carpenter wrote: > 724 rc = smack_add_opt(opt, param->string, &fc->security); > 725 if (!rc) { > 726 param->string = NULL; > 727 rc = 1; > ^^^^^^ > It probably should return zero though... Yes it should. David