Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84128C433DF for ; Mon, 20 Jul 2020 11:00:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63C632064B for ; Mon, 20 Jul 2020 11:00:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63C632064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxTWn-0004yn-0G; Mon, 20 Jul 2020 11:00:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxTWl-0004yi-O4 for xen-devel@lists.xenproject.org; Mon, 20 Jul 2020 11:00:11 +0000 X-Inumbo-ID: 2d3da2dc-ca78-11ea-9f82-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2d3da2dc-ca78-11ea-9f82-12813bfff9fa; Mon, 20 Jul 2020 11:00:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 05FFCAC1D; Mon, 20 Jul 2020 11:00:15 +0000 (UTC) Subject: Re: [PATCH v2] docs: specify stability of hypfs path documentation To: George Dunlap References: <20200713140338.16172-1-jgross@suse.com> <8a96b1b9-cbcb-557a-5b82-661bbe40fe25@suse.com> <68F727A8-29B8-4846-8BE9-BD4F6E0DC60D@citrix.com> <9f5e86cc-4f64-982b-d84b-1de6b2739a2b@suse.com> <4c681c7c-be69-7e1a-4cd9-c9e05fe85372@suse.com> <2567da9b-be43-3f0d-e213-562b5454f4b7@suse.com> <757f5f78-6ec9-c740-18bf-a01105d552d7@suse.com> <041963E3-304B-4F1D-BCA0-387057DFC7FE@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <3209a519-d7b7-e77a-4abf-7a5dcd476d6d@suse.com> Date: Mon, 20 Jul 2020 13:00:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <041963E3-304B-4F1D-BCA0-387057DFC7FE@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , Paul Durrant , Andrew Cooper , Jan Beulich , Ian Jackson , "open list:X86" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 20.07.20 12:19, George Dunlap wrote: > > >> On Jul 16, 2020, at 3:34 PM, Jürgen Groß wrote: >> >> On 16.07.20 16:20, George Dunlap wrote: >>>> On Jul 16, 2020, at 12:34 PM, Jürgen Groß wrote: >>>> >>>> On 16.07.20 13:24, Jan Beulich wrote: >>>>> On 16.07.2020 12:31, Jürgen Groß wrote: >>>>>> On 16.07.20 12:11, Jan Beulich wrote: >>>>>>> On 15.07.2020 16:37, George Dunlap wrote: >>>>>>>> IT sounds like you’re saying: >>>>>>>> >>>>>>>> 1. Paths listed without conditions will always be available >>>>>>>> >>>>>>>> 2. Paths listed with conditions may be extended: i.e., a node currently listed as PV might also become available for HVM guests >>>>>>>> >>>>>>>> 3. Paths listed with conditions might have those conditions reduced, but will never entirely disappear. So something currently listed as PV might be reduced to CONFIG_HAS_FOO, but won’t be completely removed. >>>>>>>> >>>>>>>> Is that what you meant? >>>>>>> >>>>>>> I see Jürgen replied "yes" to this, but I'm not sure about 1. >>>>>>> above: I think it's quite reasonable to expect that paths without >>>>>>> condition may gain a condition. Just like paths now having a >>>>>>> condition and (perhaps temporarily) losing it shouldn't all of >>>>>>> the sudden become "always available" when they weren't meant to >>>>>>> be. >>>>>>> >>>>>>> As far a 3. goes, I'm also unsure in how far this is any better >>>>>>> stability wise (from a consumer pov) than allowing paths to >>>>>>> entirely disappear. >>>>>> >>>>>> The idea is that any user tool using hypfs can rely on paths under 1 to >>>>>> exist, while the ones under 3 might not be there due to the hypervisor >>>>>> config or the used system. >>>>>> >>>>>> A path not being allowed to entirely disappear ensures that it remains >>>>>> in the documentation, so the same path can't be reused for something >>>>>> different in future. >>>>> And then how do you deal with a condition getting dropped, and >>>>> later wanting to get re-added? Do we need a placeholder condition >>>>> like [ALWAYS] or [TRUE]? >>>> >>>> Dropping a condition has to be considered very carefully, same as >>>> introducing a new path without any condition. >>>> >>>> In worst case you can still go with [CONFIG_HYPFS]. >>> Couldn’t we just have a section of the document for dead paths that aren’t allowed to be used? >>> Alternately, we could have a tag for entries we don’t want used anymore; [DEAD] or [OBSOLETE] maybe? [DEFUNCT]? [REMOVED]? >>> So I think I’d write a separate section, like this: >>> ~~ >>> # Stability >>> Path *presence* is not stable, but path *meaning* is always stable: if a tool you write finds a path present, it can rely on behavior in future versions of the hypervisors, and in different configurations. Specifically: >>> 1. Conditions under which paths are used may be extended, restricted, or removed. For example, a path that’s always available only on ARM systems may become available on x86; or a path available on both systems may be restricted to only appearing on ARM systems. Paths may also disappear entirely. >>> 2. However, the meaning of a path will never change. If a path is present, it will always have exactly the meaning that it always had. In order to maintain this, removed paths should be retained with the tag [REMOVED]. The path may be restored *only* if the restored version of the path is compatible with the previous functionality. >>> ~~~ >>> Thoughts? >> >> Would work for me, too. > > So whose court is the ball in now? Are you going to send another patch, or would you prefer I do it? I can do it. I just hoped that maybe someone else would agree to this approach. Juergen