From: David Howells Subject: Re: [PATCH] fscache: put reference of parent's usage and n_children Date: Mon, 13 Apr 2015 13:44:24 +0100 Message-ID: <32264.1428929064@warthog.procyon.org.uk> References: <552BB530.50405@gmail.com> <5527C9A0.6030502@gmail.com> <30571.1428924822@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Kinglong Mee Return-path: In-Reply-To: <552BB530.50405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-ID: <32263.1428929063.1-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org Kinglong Mee wrote: > > Good catch. Though it might be preferable to only increment the counters if > > the list_add() is done. > > Thanks for your comments, that's great. > I will update and resend those two patch. In fact, kmem_cache_free() can be called instead of fscache_relinquish_cookie() in that case. David -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html