From: "Kuehling, Felix" Subject: Re: [PATCH] drm/amdgpu: revert calling smu msg in df callbacks Date: Fri, 18 Oct 2019 20:52:39 +0000 Message-ID: <32330969-5069-e578-2b82-1a5d04ff2ea9@amd.com> References: <20191018202856.27133-1-jonathan.kim@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191018202856.27133-1-jonathan.kim-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US Content-ID: <57A0253F5D59D74CBE1EBFA52D710DF2-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Kim, Jonathan" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" T24gMjAxOS0xMC0xOCA0OjI5IHAubS4sIEtpbSwgSm9uYXRoYW4gd3JvdGU6DQo+IHJldmVydGlu ZyB0aGUgZm9sbG93aW5nIGNoYW5nZXM6DQo+IGNvbW1pdCA3ZGQyZWIzMWZjZDUgKCJkcm0vYW1k Z3B1OiBmaXggY29tcGlsZXIgd2FybmluZ3MgZm9yIGRmIHBlcmZtb25zIikNCj4gY29tbWl0IDU0 Mjc1Y2QxNjQ5ZiAoImRybS9hbWRncHU6IGRpc2FibGUgYy1zdGF0ZXMgb24geGdtaSBwZXJmbW9u cyIpDQo+DQo+IHBlcmYgZXZlbnRzIHVzZSBzcGluLWxvY2tzLiAgZW1iZWRkZWQgc211IG1lc3Nh Z2VzIGhhdmUgcG90ZW50aWFsIGxvbmcNCj4gcmVzcG9uc2UgdGltZXMgYW5kIHBvdGVudGlhbGx5 IGRlYWRsb2NrcyB0aGUgc3lzdGVtLg0KPg0KPiBDaGFuZ2UtSWQ6IEljMzZjMzVhNjJkZWMxMTZk MGEyZjViNjljMjJhZjRkNDE0NDU4Njc5DQo+IFNpZ25lZC1vZmYtYnk6IEpvbmF0aGFuIEtpbSA8 Sm9uYXRoYW4uS2ltQGFtZC5jb20+DQoNClJldmlld2VkLWJ5OiBGZWxpeCBLdWVobGluZyA8RmVs aXguS3VlaGxpbmdAYW1kLmNvbT4NCg0KU2VlIG9uZSBtb3JlIGNvbW1lbnQgaW5saW5lIGJlbG93 IC4uLg0KDQoNCj4gLS0tDQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGZfdjNfNi5j IHwgMzggKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKyksIDM2IGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvZGZfdjNfNi5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvZGZfdjNfNi5jDQo+IGluZGV4IGUxY2Y3ZTljNjE2YS4uMTZmYmQyYmM4YWQxIDEwMDY0NA0K PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kZl92M182LmMNCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGZfdjNfNi5jDQo+IEBAIC05MywyMSArOTMsNiBAQCBj b25zdCBzdHJ1Y3QgYXR0cmlidXRlX2dyb3VwICpkZl92M182X2F0dHJfZ3JvdXBzW10gPSB7DQo+ ICAgCQlOVUxMDQo+ICAgfTsNCj4gICANCj4gLXN0YXRpYyBpbnQgZGZfdjNfNl9zZXRfZGZfY3N0 YXRlKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBpbnQgYWxsb3cpDQo+IC17DQo+IC0JaW50 IHIgPSAwOw0KPiAtDQo+IC0JaWYgKGlzX3N1cHBvcnRfc3dfc211KGFkZXYpKSB7DQo+IC0JCXIg PSBzbXVfc2V0X2RmX2NzdGF0ZSgmYWRldi0+c211LCBhbGxvdyk7DQo+IC0JfSBlbHNlIGlmIChh ZGV2LT5wb3dlcnBsYXkucHBfZnVuY3MNCj4gLQkJCSYmIGFkZXYtPnBvd2VycGxheS5wcF9mdW5j cy0+c2V0X2RmX2NzdGF0ZSkgew0KPiAtCQlyID0gYWRldi0+cG93ZXJwbGF5LnBwX2Z1bmNzLT5z ZXRfZGZfY3N0YXRlKA0KPiAtCQkJYWRldi0+cG93ZXJwbGF5LnBwX2hhbmRsZSwgYWxsb3cpOw0K PiAtCX0NCj4gLQ0KPiAtCXJldHVybiByOw0KPiAtfQ0KPiAtDQo+ICAgc3RhdGljIHVpbnQ2NF90 IGRmX3YzXzZfZ2V0X2ZpY2Eoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsDQo+ICAgCQkJCSB1 aW50MzJfdCBmaWNhYV92YWwpDQo+ICAgew0KPiBAQCAtMTE3LDkgKzEwMiw2IEBAIHN0YXRpYyB1 aW50NjRfdCBkZl92M182X2dldF9maWNhKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LA0KPiAg IAlhZGRyZXNzID0gYWRldi0+bmJpby5mdW5jcy0+Z2V0X3BjaWVfaW5kZXhfb2Zmc2V0KGFkZXYp Ow0KPiAgIAlkYXRhID0gYWRldi0+bmJpby5mdW5jcy0+Z2V0X3BjaWVfZGF0YV9vZmZzZXQoYWRl dik7DQo+ICAgDQo+IC0JaWYgKGRmX3YzXzZfc2V0X2RmX2NzdGF0ZShhZGV2LCBERl9DU1RBVEVf RElTQUxMT1cpKQ0KPiAtCQlyZXR1cm4gMHhGRkZGRkZGRkZGRkZGRkZGOw0KPiAtDQo+ICAgCXNw aW5fbG9ja19pcnFzYXZlKCZhZGV2LT5wY2llX2lkeF9sb2NrLCBmbGFncyk7DQo+ICAgCVdSRUcz MihhZGRyZXNzLCBzbW5ERl9QSUVfQU9OX0ZhYnJpY0luZGlyZWN0Q29uZmlnQWNjZXNzQWRkcmVz czMpOw0KPiAgIAlXUkVHMzIoZGF0YSwgZmljYWFfdmFsKTsNCj4gQEAgLTEzMiw4ICsxMTQsNiBA QCBzdGF0aWMgdWludDY0X3QgZGZfdjNfNl9nZXRfZmljYShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq YWRldiwNCj4gICANCj4gICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmYWRldi0+cGNpZV9pZHhf bG9jaywgZmxhZ3MpOw0KPiAgIA0KPiAtCWRmX3YzXzZfc2V0X2RmX2NzdGF0ZShhZGV2LCBERl9D U1RBVEVfQUxMT1cpOw0KPiAtDQo+ICAgCXJldHVybiAoKChmaWNhZGhfdmFsICYgMHhGRkZGRkZG RkZGRkZGRkZGKSA8PCAzMikgfCBmaWNhZGxfdmFsKTsNCj4gICB9DQo+ICAgDQo+IEBAIC0xNDUs OSArMTI1LDYgQEAgc3RhdGljIHZvaWQgZGZfdjNfNl9zZXRfZmljYShzdHJ1Y3QgYW1kZ3B1X2Rl dmljZSAqYWRldiwgdWludDMyX3QgZmljYWFfdmFsLA0KPiAgIAlhZGRyZXNzID0gYWRldi0+bmJp by5mdW5jcy0+Z2V0X3BjaWVfaW5kZXhfb2Zmc2V0KGFkZXYpOw0KPiAgIAlkYXRhID0gYWRldi0+ bmJpby5mdW5jcy0+Z2V0X3BjaWVfZGF0YV9vZmZzZXQoYWRldik7DQo+ICAgDQo+IC0JaWYgKGRm X3YzXzZfc2V0X2RmX2NzdGF0ZShhZGV2LCBERl9DU1RBVEVfRElTQUxMT1cpKQ0KPiAtCQlyZXR1 cm47DQo+IC0NCj4gICAJc3Bpbl9sb2NrX2lycXNhdmUoJmFkZXYtPnBjaWVfaWR4X2xvY2ssIGZs YWdzKTsNCj4gICAJV1JFRzMyKGFkZHJlc3MsIHNtbkRGX1BJRV9BT05fRmFicmljSW5kaXJlY3RD b25maWdBY2Nlc3NBZGRyZXNzMyk7DQo+ICAgCVdSRUczMihkYXRhLCBmaWNhYV92YWwpOw0KPiBA QCAtMTU3LDkgKzEzNCw4IEBAIHN0YXRpYyB2b2lkIGRmX3YzXzZfc2V0X2ZpY2Eoc3RydWN0IGFt ZGdwdV9kZXZpY2UgKmFkZXYsIHVpbnQzMl90IGZpY2FhX3ZhbCwNCj4gICANCj4gICAJV1JFRzMy KGFkZHJlc3MsIHNtbkRGX1BJRV9BT05fRmFicmljSW5kaXJlY3RDb25maWdBY2Nlc3NEYXRhSGkz KTsNCj4gICAJV1JFRzMyKGRhdGEsIGZpY2FkaF92YWwpOw0KPiAtCXNwaW5fdW5sb2NrX2lycXJl c3RvcmUoJmFkZXYtPnBjaWVfaWR4X2xvY2ssIGZsYWdzKTsNCj4gICANCj4gLQlkZl92M182X3Nl dF9kZl9jc3RhdGUoYWRldiwgREZfQ1NUQVRFX0FMTE9XKTsNCj4gKwlzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZhZGV2LT5wY2llX2lkeF9sb2NrLCBmbGFncyk7DQo+ICAgfQ0KPiAgIA0KPiAgIC8q DQo+IEBAIC0xNzcsMTcgKzE1MywxMiBAQCBzdGF0aWMgdm9pZCBkZl92M182X3BlcmZtb25fcnJl ZyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwNCj4gICAJYWRkcmVzcyA9IGFkZXYtPm5iaW8u ZnVuY3MtPmdldF9wY2llX2luZGV4X29mZnNldChhZGV2KTsNCj4gICAJZGF0YSA9IGFkZXYtPm5i aW8uZnVuY3MtPmdldF9wY2llX2RhdGFfb2Zmc2V0KGFkZXYpOw0KPiAgIA0KPiAtCWlmIChkZl92 M182X3NldF9kZl9jc3RhdGUoYWRldiwgREZfQ1NUQVRFX0RJU0FMTE9XKSkNCj4gLQkJcmV0dXJu Ow0KPiAtDQo+ICAgCXNwaW5fbG9ja19pcnFzYXZlKCZhZGV2LT5wY2llX2lkeF9sb2NrLCBmbGFn cyk7DQo+ICAgCVdSRUczMihhZGRyZXNzLCBsb19hZGRyKTsNCj4gICAJKmxvX3ZhbCA9IFJSRUcz MihkYXRhKTsNCj4gICAJV1JFRzMyKGFkZHJlc3MsIGhpX2FkZHIpOw0KPiAgIAkqaGlfdmFsID0g UlJFRzMyKGRhdGEpOw0KPiAgIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZhZGV2LT5wY2llX2lk eF9sb2NrLCBmbGFncyk7DQo+IC0NCj4gLQlkZl92M182X3NldF9kZl9jc3RhdGUoYWRldiwgREZf Q1NUQVRFX0FMTE9XKTsNCj4gICB9DQo+ICAgDQo+ICAgLyoNCj4gQEAgLTIwNCwxNyArMTc1LDEy IEBAIHN0YXRpYyB2b2lkIGRmX3YzXzZfcGVyZm1vbl93cmVnKHN0cnVjdCBhbWRncHVfZGV2aWNl ICphZGV2LCB1aW50MzJfdCBsb19hZGRyLA0KPiAgIAlhZGRyZXNzID0gYWRldi0+bmJpby5mdW5j cy0+Z2V0X3BjaWVfaW5kZXhfb2Zmc2V0KGFkZXYpOw0KPiAgIAlkYXRhID0gYWRldi0+bmJpby5m dW5jcy0+Z2V0X3BjaWVfZGF0YV9vZmZzZXQoYWRldik7DQo+ICAgDQo+IC0JaWYgKGRmX3YzXzZf c2V0X2RmX2NzdGF0ZShhZGV2LCBERl9DU1RBVEVfRElTQUxMT1cpKQ0KPiAtCQlyZXR1cm47DQo+ IC0NCj4gICAJc3Bpbl9sb2NrX2lycXNhdmUoJmFkZXYtPnBjaWVfaWR4X2xvY2ssIGZsYWdzKTsN Cj4gICAJV1JFRzMyKGFkZHJlc3MsIGxvX2FkZHIpOw0KPiAgIAlXUkVHMzIoZGF0YSwgbG9fdmFs KTsNCj4gICAJV1JFRzMyKGFkZHJlc3MsIGhpX2FkZHIpOw0KPiAgIAlXUkVHMzIoZGF0YSwgaGlf dmFsKTsNCj4gICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmYWRldi0+cGNpZV9pZHhfbG9jaywg ZmxhZ3MpOw0KPiAtDQo+IC0JZGZfdjNfNl9zZXRfZGZfY3N0YXRlKGFkZXYsIERGX0NTVEFURV9B TExPVyk7DQo+ICAgfQ0KPiAgIA0KPiAgIC8qIGdldCB0aGUgbnVtYmVyIG9mIGRmIGNvdW50ZXJz IGF2YWlsYWJsZSAqLw0KPiBAQCAtNTQ2LDcgKzUxMiw3IEBAIHN0YXRpYyB2b2lkIGRmX3YzXzZf cG1jX2dldF9jb3VudChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwNCj4gICAJCQkJICB1aW50 NjRfdCBjb25maWcsDQo+ICAgCQkJCSAgdWludDY0X3QgKmNvdW50KQ0KPiAgIHsNCj4gLQl1aW50 MzJfdCBsb19iYXNlX2FkZHIsIGhpX2Jhc2VfYWRkciwgbG9fdmFsID0gMCwgaGlfdmFsID0gMDsN Cj4gKwl1aW50MzJfdCBsb19iYXNlX2FkZHIsIGhpX2Jhc2VfYWRkciwgbG9fdmFsLCBoaV92YWw7 DQoNClRoaXMgcGFydCBsb29rcyBsaWtlIGl0IHdhcyB1bnJlbGF0ZWQgdG8gdGhlIERGIENzdGF0 ZSBjaGFuZ2VzLiBJZiB0aGlzIA0KYWRkcmVzc2VkIGEgcmVhbCBwcm9ibGVtLCBtYXliZSBpdCBj YW4gYmUgcmVpbnRyb2R1Y2VkIHdpdGggYSBzZXBhcmF0ZSANCmNvbW1pdCBhZnRlciB0aGlzIHJl dmVydC4NCg0KUmVnYXJkcywNCiDCoCBGZWxpeA0KDQoNCj4gICAJKmNvdW50ID0gMDsNCj4gICAN Cj4gICAJc3dpdGNoIChhZGV2LT5hc2ljX3R5cGUpIHsNCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vYW1kLWdmeA==