From: Michael Walle Date: Tue, 05 Nov 2019 10:36:41 +0100 Subject: [U-Boot] [EXT] [PATCH v2 2/2] arm: ls1028a: use the new flexspi driver In-Reply-To: References: <20191102182608.30624-1-michael@walle.cc> <20191102182608.30624-2-michael@walle.cc> Message-ID: <323d7fb74797db37986cd8daaa3fdf8c@walle.cc> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Singh, Am 2019-11-05 07:40, schrieb Kuldeep Singh: > Hi Michael, > >> -----Original Message----- >> From: U-Boot On Behalf Of Michael Walle >> Sent: Saturday, November 2, 2019 11:56 PM >> To: u-boot at lists.denx.de >> Subject: [EXT] [U-Boot] [PATCH v2 2/2] arm: ls1028a: use the new >> flexspi >> driver >> >> Caution: EXT Email >> >> Also align the fspi node with the kernel one. There is actually no >> driver which >> would match "nxp,dn-fspi". >> >> Signed-off-by: Michael Walle >> --- >> changes since v1: >> - none >> >> arch/arm/dts/fsl-ls1028a.dtsi | 14 ++++++++------ >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi >> b/arch/arm/dts/fsl-ls1028a.dtsi index >> 43a154e8e7..774e477542 100644 >> --- a/arch/arm/dts/fsl-ls1028a.dtsi >> +++ b/arch/arm/dts/fsl-ls1028a.dtsi >> @@ -49,14 +49,16 @@ >> <1 10 0x8>; /* Hypervisor PPI, active-low >> */ >> }; >> >> - fspi: flexspi at 20C0000 { >> - compatible = "nxp,dn-fspi"; >> + fspi: flexspi at 20c0000 { >> + compatible = "nxp,lx2160a-fspi"; >> #address-cells = <1>; >> #size-cells = <0>; >> - reg = <0x0 0x20C0000 0x0 0x10000>, >> - <0x0 0x20000000 0x0 0x10000000>; /*64MB >> flash*/ >> - reg-names = "FSPI", "FSPI-memory"; >> - num-cs = <1>; >> + reg = <0x0 0x20c0000 0x0 0x10000>, >> + <0x0 0x20000000 0x0 0x10000000>; >> + reg-names = "fspi_base", "fspi_mmap"; >> + clocks = <&clockgen 4 3>, <&clockgen 4 3>; >> + clock-names = "fspi_en", "fspi"; >> + interrupts = <0 25 0x4>; > > Please change the interrupts to "" as > it avoids magic numbers. This is consistent with the other interrupt properties, which doesn't have these constants either. IMHO another commit where all these magic numbers are removed would be better. > Reviewed-by: Kuldeep Singh Thanks. -michael