From: "flichtenheld (Code Review)"
Date: Fri, 19 Jul 2024 13:09:06 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <32999b5c5ec97fdeb5b15568fcfffd470203ea58-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="zqutD9gDvgU="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Avoid SIGUSR1 to
SIGHUP when the configuration is read from stdin
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--zqutD9gDvgU=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/533?usp=3Demail )
Change subject: Avoid SIGUSR1 to SIGHUP when the configuration is read from=
stdin
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
http://gerrit.openvpn.net/c/openvpn/+/533/comment/0584d87f_10f34ade :
PS1, Line 7: Avoid SIGUR1 to SIGHUP when the configuration is read from std=
in
> Typo -> "SIGUSR1"
Done
http://gerrit.openvpn.net/c/openvpn/+/533/comment/457ac179_ec7f95d4 :
PS1, Line 11: "close_context usr1 to hup" logic, the OpenVPN process will f=
ail as tries
> Please add a short explanation of when this logic might be hit. [=E2=80=
=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/533?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icfc179490d6821e22d14817941fb0bad667c713f
Gerrit-Change-Number: 533
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Fri, 19 Jul 2024 13:09:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--zqutD9gDvgU=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
View C=
hange
2 comments:
=
Commit Message:
- <=
p style=3D"margin-bottom: 4px;">Patch Set #1, Line 7:
Avoid SIGUR1 to SIGHUP when the config=
uration is read from stdin
Typo -> "SIGUSR1&q=
uot;
Done
Patch Set #1, Line 11: "close_context usr1 to hup" logic, the=
OpenVPN process will fail as tries
Please add a shor=
t explanation of when this logic might be hit. [=E2=80=A6]
=
Done
To view, visit change 533. To unsubscribe, or for help writing ma=
il filters, visit settings=
a>.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icfc179490d6821e22d14817941f=
b0bad667c713f
Gerrit-Change-Number: 533
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Fri, 19 Jul 2024 13:09:06=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--zqutD9gDvgU=--