Subject: Re: [PATCH v3 2/7] kselftest: Add test runner creation script References: <20190306214226.14598-1-tobin@kernel.org> <20190306214226.14598-3-tobin@kernel.org> From: Randy Dunlap Message-ID: <32a2dca5-d3cd-e7d3-e73b-406d897ae174@infradead.org> Date: Tue, 2 Apr 2019 14:33:12 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Kees Cook , "Tobin C. Harding" Cc: Shuah Khan , Jann Horn , Andy Shevchenko , Rasmus Villemoes , Stephen Rothwell , Andy Lutomirski , Daniel Micay , Arnd Bergmann , Miguel Ojeda , "Gustavo A. R. Silva" , Greg Kroah-Hartman , Alexander Shishkin , Kernel Hardening , "open list:KERNEL SELFTEST FRAMEWORK" , LKML List-ID: Hi, nits/typos below: On 4/2/19 2:27 PM, Kees Cook wrote: > On Wed, Mar 6, 2019 at 1:43 PM Tobin C. Harding wrote: >> >> >> Add test runner creation script. >> >> Signed-off-by: Tobin C. Harding >> --- >> tools/testing/selftests/kselftest_module.sh | 75 +++++++++++++++++++++ >> 1 file changed, 75 insertions(+) >> create mode 100755 tools/testing/selftests/kselftest_module.sh >> >> diff --git a/tools/testing/selftests/kselftest_module.sh b/tools/testing/selftests/kselftest_module.sh >> new file mode 100755 >> index 000000000000..b5d446738614 >> --- /dev/null >> +++ b/tools/testing/selftests/kselftest_module.sh >> @@ -0,0 +1,75 @@ >> +#!/bin/sh >> +# SPDX-License-Identifier: GPL-2.0+ >> + >> +# >> +# Runs an individual test module. kselftest expects a separate >> +# executable for each test. So test should each have an individial individual >> +# script that can call this script. >> +# >> + >> +# Individual test scrits should define these: scripts >> +module="" # filename (without the .ko). >> +desc="" # Output prefix. cheers. -- ~Randy