From: "cron2 (Code Review)" Date: Mon, 2 Jun 2025 15:30:42 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <32a7a6ba8a8a2044a1b839c948397592409cee75-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="y7M76AInvnI="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Do not segfault on missing --dh in server config List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --y7M76AInvnI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1037?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Do not segfault on missing --dh in server config ...................................................................... Do not segfault on missing --dh in server config Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250602152115.27130-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31= 844.html Signed-off-by: Gert Doering --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/1037/2 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 0d648ba..b9708343 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3698,7 +3698,7 @@ if (o->tls_server) { - if (streq(o->dh_file, "none")) + if (o->dh_file && streq(o->dh_file, "none")) { o->dh_file =3D NULL; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1037?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1 Gerrit-Change-Number: 1037 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --y7M76AInvnI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by cron2

Do not segfault on missing --dh in server config
=
Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1
Signed-off-by: = Frank Lichtenheld <frank@...2641...>
Acked-by: Gert Doering <ge= rt@...1296...>
Message-Id: <20250602152115.27130-1-gert@...1296...= >
URL: https://www.mail-archive.com/openvpn-devel@...1223...= et/msg31844.html
Signed-off-by: Gert Doering <gert@...1296...>
= ---
M src/openvpn/options.c
1 file changed, 1 insertion(+), 1 deletio= n(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes=
/37/1037/2
diff --git a/src/openvpn/options.c b/src/openvpn/options=
.c
index 0d648ba..b9708343 100644
--- a/src= /openvpn/options.c
+++ b/src/openvpn/options.c
@@ -3698,7 +3698,7 @@

if (o->= tls_server)
{
- if (streq(o->dh_file, "none"))
= + if (o->dh_file &= ;& streq(o->dh_file, "none"))
{
o->dh_file =3D NULL;
= }

To view, visit change 1037. To unsubscr= ibe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e13595c1057c680e1065eae84c= a94b273ed9ca1
Gerrit-Change-Number: 1037
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--y7M76AInvnI=--