From: shuah@kernel.org (shuah) Date: Mon, 8 Apr 2019 12:53:39 -0600 Subject: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control() In-Reply-To: <20190328025659.25684-1-guro@fb.com> References: <20190328025659.25684-1-guro@fb.com> Message-ID: <32b7ae48-99dd-1261-4086-37d416ffcfd5@kernel.org> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190408185339.PNLrzgu1mV0PnICGEw7wd-23nNVBgG0c-YyZ8vVS1uk@z> On 3/27/19 8:56 PM, Roman Gushchin wrote: > Dan reported, that cleanup path in test_memcg_subtree_control() > triggers a static checker warning: > ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \ > test_memcg_subtree_control() > error: uninitialized symbol 'child2'. > > Fix this by initializing child2 and parent2 variables and > split the cleanup path into few stages. > > Signed-off-by: Roman Gushchin > Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests") > Reported-by: Dan Carpenter > Cc: Dan Carpenter > Cc: Shuah Khan (Samsung OSG) > Cc: Mike Rapoport From and Signed-off don't match. Please fix it and resend the patch. thanks, -- Shuah