From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/4] drm/amd/amdgpu: Fold TTM debugfs entries into array (v2) Date: Tue, 19 Sep 2017 13:08:17 +0200 Message-ID: <32c4282c-e27e-4055-dacc-a1d795a1b325@gmail.com> References: <20170918173350.9543-1-tom.stdenis@amd.com> <20170918173350.9543-2-tom.stdenis@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170918173350.9543-2-tom.stdenis-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Tom St Denis , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTguMDkuMjAxNyB1bSAxOTozMyBzY2hyaWViIFRvbSBTdCBEZW5pczoKPiBTaWduZWQtb2Zm LWJ5OiBUb20gU3QgRGVuaXMgPHRvbS5zdGRlbmlzQGFtZC5jb20+CgpSZXZpZXdlZC1ieTogQ2hy aXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgoKPgo+ICh2Mik6IGFkZCBk b21haW5zIGFuZCBhdm9pZCBzdHJjbXAKPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV90dG0uYyB8IDU0ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5oIHwgIDQgKy0tCj4gICAy IGZpbGVzIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQo+Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+IGluZGV4IDhlZTE2ZGZkYjhhZi4u NTBkMjA5MDNkZTRmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV90dG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0u Ywo+IEBAIC0xODA5LDYgKzE4MDksMTkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJh dGlvbnMgYW1kZ3B1X3R0bV9ndHRfZm9wcyA9IHsKPiAgIAo+ICAgI2VuZGlmCj4gICAKPiArCj4g Kwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHsKPiArCWNoYXIgKm5hbWU7Cj4gKwljb25zdCBzdHJ1 Y3QgZmlsZV9vcGVyYXRpb25zICpmb3BzOwo+ICsJaW50IGRvbWFpbjsKPiArfSB0dG1fZGVidWdm c19lbnRyaWVzW10gPSB7Cj4gKwl7ICJhbWRncHVfdnJhbSIsICZhbWRncHVfdHRtX3ZyYW1fZm9w cywgVFRNX1BMX1ZSQU0gfSwKPiArI2lmZGVmIENPTkZJR19EUk1fQU1ER1BVX0dBUlRfREVCVUdG Uwo+ICsJeyAiYW1kZ3B1X2d0dCIsICZhbWRncHVfdHRtX2d0dF9mb3BzLCBUVE1fUExfVFQgfSwK PiArI2VuZGlmCj4gK307Cj4gKwo+ICAgI2VuZGlmCj4gICAKPiAgIHN0YXRpYyBpbnQgYW1kZ3B1 X3R0bV9kZWJ1Z2ZzX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gQEAgLTE4MTks MjIgKzE4MzIsMjEgQEAgc3RhdGljIGludCBhbWRncHVfdHRtX2RlYnVnZnNfaW5pdChzdHJ1Y3Qg YW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAlzdHJ1Y3QgZHJtX21pbm9yICptaW5vciA9IGFkZXYt PmRkZXYtPnByaW1hcnk7Cj4gICAJc3RydWN0IGRlbnRyeSAqZW50LCAqcm9vdCA9IG1pbm9yLT5k ZWJ1Z2ZzX3Jvb3Q7Cj4gICAKPiAtCWVudCA9IGRlYnVnZnNfY3JlYXRlX2ZpbGUoImFtZGdwdV92 cmFtIiwgU19JRlJFRyB8IFNfSVJVR08sIHJvb3QsCj4gLQkJCQkgIGFkZXYsICZhbWRncHVfdHRt X3ZyYW1fZm9wcyk7Cj4gLQlpZiAoSVNfRVJSKGVudCkpCj4gLQkJcmV0dXJuIFBUUl9FUlIoZW50 KTsKPiAtCWlfc2l6ZV93cml0ZShlbnQtPmRfaW5vZGUsIGFkZXYtPm1jLm1jX3ZyYW1fc2l6ZSk7 Cj4gLQlhZGV2LT5tbWFuLnZyYW0gPSBlbnQ7Cj4gLQo+IC0jaWZkZWYgQ09ORklHX0RSTV9BTURH UFVfR0FSVF9ERUJVR0ZTCj4gLQllbnQgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJhbWRncHVfZ3R0 IiwgU19JRlJFRyB8IFNfSVJVR08sIHJvb3QsCj4gLQkJCQkgIGFkZXYsICZhbWRncHVfdHRtX2d0 dF9mb3BzKTsKPiAtCWlmIChJU19FUlIoZW50KSkKPiAtCQlyZXR1cm4gUFRSX0VSUihlbnQpOwo+ IC0JaV9zaXplX3dyaXRlKGVudC0+ZF9pbm9kZSwgYWRldi0+bWMuZ2FydF9zaXplKTsKPiAtCWFk ZXYtPm1tYW4uZ3R0ID0gZW50Owo+ICsJZm9yIChjb3VudCA9IDA7IGNvdW50IDwgQVJSQVlfU0la RSh0dG1fZGVidWdmc19lbnRyaWVzKTsgY291bnQrKykgewo+ICsJCWVudCA9IGRlYnVnZnNfY3Jl YXRlX2ZpbGUoCj4gKwkJCQl0dG1fZGVidWdmc19lbnRyaWVzW2NvdW50XS5uYW1lLAo+ICsJCQkJ U19JRlJFRyB8IFNfSVJVR08sIHJvb3QsCj4gKwkJCQlhZGV2LAo+ICsJCQkJdHRtX2RlYnVnZnNf ZW50cmllc1tjb3VudF0uZm9wcyk7Cj4gKwkJaWYgKElTX0VSUihlbnQpKQo+ICsJCQlyZXR1cm4g UFRSX0VSUihlbnQpOwo+ICsJCWlmICh0dG1fZGVidWdmc19lbnRyaWVzW2NvdW50XS5kb21haW4g PT0gVFRNX1BMX1ZSQU0pCj4gKwkJCWlfc2l6ZV93cml0ZShlbnQtPmRfaW5vZGUsIGFkZXYtPm1j Lm1jX3ZyYW1fc2l6ZSk7Cj4gKwkJZWxzZSBpZiAodHRtX2RlYnVnZnNfZW50cmllc1tjb3VudF0u ZG9tYWluID09IFRUTV9QTF9UVCkKPiArCQkJaV9zaXplX3dyaXRlKGVudC0+ZF9pbm9kZSwgYWRl di0+bWMuZ2FydF9zaXplKTsKPiArCQlhZGV2LT5tbWFuLmRlYnVnZnNfZW50cmllc1tjb3VudF0g PSBlbnQ7Cj4gKwl9Cj4gICAKPiAtI2VuZGlmCj4gICAJY291bnQgPSBBUlJBWV9TSVpFKGFtZGdw dV90dG1fZGVidWdmc19saXN0KTsKPiAgIAo+ICAgI2lmZGVmIENPTkZJR19TV0lPVExCCj4gQEAg LTE4NDQsNyArMTg1Niw2IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X3R0bV9kZWJ1Z2ZzX2luaXQoc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAKPiAgIAlyZXR1cm4gYW1kZ3B1X2RlYnVnZnNf YWRkX2ZpbGVzKGFkZXYsIGFtZGdwdV90dG1fZGVidWdmc19saXN0LCBjb3VudCk7Cj4gICAjZWxz ZQo+IC0KPiAgIAlyZXR1cm4gMDsKPiAgICNlbmRpZgo+ICAgfQo+IEBAIC0xODUyLDE0ICsxODYz LDkgQEAgc3RhdGljIGludCBhbWRncHVfdHRtX2RlYnVnZnNfaW5pdChzdHJ1Y3QgYW1kZ3B1X2Rl dmljZSAqYWRldikKPiAgIHN0YXRpYyB2b2lkIGFtZGdwdV90dG1fZGVidWdmc19maW5pKHN0cnVj dCBhbWRncHVfZGV2aWNlICphZGV2KQo+ICAgewo+ICAgI2lmIGRlZmluZWQoQ09ORklHX0RFQlVH X0ZTKQo+ICsJdW5zaWduZWQgaTsKPiAgIAo+IC0JZGVidWdmc19yZW1vdmUoYWRldi0+bW1hbi52 cmFtKTsKPiAtCWFkZXYtPm1tYW4udnJhbSA9IE5VTEw7Cj4gLQo+IC0jaWZkZWYgQ09ORklHX0RS TV9BTURHUFVfR0FSVF9ERUJVR0ZTCj4gLQlkZWJ1Z2ZzX3JlbW92ZShhZGV2LT5tbWFuLmd0dCk7 Cj4gLQlhZGV2LT5tbWFuLmd0dCA9IE5VTEw7Cj4gLSNlbmRpZgo+IC0KPiArCWZvciAoaSA9IDA7 IGkgPCBBUlJBWV9TSVpFKHR0bV9kZWJ1Z2ZzX2VudHJpZXMpOyBpKyspCj4gKwkJZGVidWdmc19y ZW1vdmUoYWRldi0+bW1hbi5kZWJ1Z2ZzX2VudHJpZXNbaV0pOwo+ICAgI2VuZGlmCj4gICB9Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uaCBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uaAo+IGluZGV4IDY0NzA5ZTA0MWQ1 Yi4uN2FiYWU2ODY3MzM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV90dG0uaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90 dG0uaAo+IEBAIC0yNCw2ICsyNCw3IEBACj4gICAjaWZuZGVmIF9fQU1ER1BVX1RUTV9IX18KPiAg ICNkZWZpbmUgX19BTURHUFVfVFRNX0hfXwo+ICAgCj4gKyNpbmNsdWRlICJhbWRncHUuaCIKPiAg ICNpbmNsdWRlICJncHVfc2NoZWR1bGVyLmgiCj4gICAKPiAgICNkZWZpbmUgQU1ER1BVX1BMX0dE UwkJKFRUTV9QTF9QUklWICsgMCkKPiBAQCAtNDUsOCArNDYsNyBAQCBzdHJ1Y3QgYW1kZ3B1X21t YW4gewo+ICAgCWJvb2wJCQkJaW5pdGlhbGl6ZWQ7Cj4gICAKPiAgICNpZiBkZWZpbmVkKENPTkZJ R19ERUJVR19GUykKPiAtCXN0cnVjdCBkZW50cnkJCQkqdnJhbTsKPiAtCXN0cnVjdCBkZW50cnkJ CQkqZ3R0Owo+ICsJc3RydWN0IGRlbnRyeQkJCSpkZWJ1Z2ZzX2VudHJpZXNbOF07Cj4gICAjZW5k aWYKPiAgIAo+ICAgCS8qIGJ1ZmZlciBoYW5kbGluZyAqLwoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vYW1kLWdmeAo=