Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EC9FC433EF for ; Fri, 21 Jan 2022 20:59:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 118A681426; Fri, 21 Jan 2022 21:59:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="jxencv/k"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="jxencv/k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8619A81E25; Fri, 21 Jan 2022 21:59:19 +0100 (CET) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 99AF08129F for ; Fri, 21 Jan 2022 21:59:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id EFC034E2006; Fri, 21 Jan 2022 20:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642798753; bh=TuS23B15P4VWS8foCLZmRWhtr+J6TLR8ruqOCFQEn1I=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=jxencv/k+n8Pk7sQy7bJuGDOnPShcRIRYStkrOoStIZwz9O0rhgG2uFf1KcBckOp6 kJXgENxNppLsZ93YmtuYVzGn4GOhinRoKUkCbWj9/clpchC0OjFr4J5Ly2FrVsYu4K GfnfGIW5y6nIW+pIh8T3BJmmHVbwMOeReO3EHTPI= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X5T-J1_N-jWM; Fri, 21 Jan 2022 20:59:13 +0000 (UTC) Received: from www.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) by node.akkea.ca (Postfix) with ESMTPSA id 1D0F04E2003; Fri, 21 Jan 2022 20:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642798753; bh=TuS23B15P4VWS8foCLZmRWhtr+J6TLR8ruqOCFQEn1I=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=jxencv/k+n8Pk7sQy7bJuGDOnPShcRIRYStkrOoStIZwz9O0rhgG2uFf1KcBckOp6 kJXgENxNppLsZ93YmtuYVzGn4GOhinRoKUkCbWj9/clpchC0OjFr4J5Ly2FrVsYu4K GfnfGIW5y6nIW+pIh8T3BJmmHVbwMOeReO3EHTPI= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 21 Jan 2022 12:59:13 -0800 From: Angus Ainslie To: Jagan Teki Cc: Tudor.Ambarus@microchip.com, michael@walle.cc, dphadke@linux.microsoft.com, kernel@puri.sm, u-boot@lists.denx.de, vigneshr@ti.com Subject: Re: [PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV In-Reply-To: References: <20220120132010.3019854-1-michael@walle.cc> Message-ID: <32d31f8e28a8772ff2ef3bcd71f48e3c@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2022-01-20 06:39, Jagan Teki wrote: > On Thu, Jan 20, 2022 at 7:53 PM wrote: >> >> On 1/20/22 3:20 PM, Michael Walle wrote: >> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> > >> >>> + { >> >>> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, >> >> >> >> Can this name as "w25q16jv-im/jm" ? >> > >> > FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this >> > particular flash the name in linux is "w25q16jv-im/jm".. >> >> would you fix it? :D >> >> > >> > Anyhow, see [1] for a lengthy discussion on that name. That being said, I >> > still don't share Tudors opinion on using that made up name, just because >> > no one will find any flash if one searches for w25q16jvm in the internet. >> >> The temperature range "I/J" is skipped in the name because it does not >> have >> any influence on the jedec-id. That's why we don't include the >> "Package Type" >> field in the naming convention as well. > > Okay, I'm merging v3. let me know if you have any questions? > Thanks ! > Thanks, > Jagan.