From: "cron2 (Code Review)" Date: Sun, 19 Apr 2026 15:51:46 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <32de9819b975cf0afa5d24c4726ae37f367d2aba-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="YtSzIrXOFms="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: tapctl: Remove unused function dont_mute List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --YtSzIrXOFms= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/16= 15?usp=3Demail ) Change subject: tapctl: Remove unused function dont_mute ...................................................................... tapctl: Remove unused function dont_mute Identified by cppcheck. Change-Id: I87c40dc94035345add1162e5029e51288811cb09 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615 Message-Id: <20260419133947.21215-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 662.html Signed-off-by: Gert Doering --- M src/tapctl/error.h M src/tapctl/main.c 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/tapctl/error.h b/src/tapctl/error.h index 9632b2f..f9586dc 100644 --- a/src/tapctl/error.h +++ b/src/tapctl/error.h @@ -109,11 +109,11 @@ return (level & M_DEBUG_LEVEL) <=3D x_debug_level; } -/** Return true if flags represent and enabled, not muted log level */ +/** Return true if flags represent */ static inline bool msg_test(unsigned int flags) { - return check_debug_level(flags) && dont_mute(flags); + return check_debug_level(flags); } #endif /* ifndef ERROR_H */ diff --git a/src/tapctl/main.c b/src/tapctl/main.c index 1d047dd..6a4a240 100644 --- a/src/tapctl/main.c +++ b/src/tapctl/main.c @@ -686,15 +686,6 @@ } -bool -dont_mute(unsigned int flags) -{ - UNREFERENCED_PARAMETER(flags); - - return true; -} - - void x_msg_va(const unsigned int flags, const char *format, va_list arglist) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1615?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I87c40dc94035345add1162e5029e51288811cb09 Gerrit-Change-Number: 1615 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --YtSzIrXOFms= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

tapctl: Remove unused function dont_mute

= Identified by cppcheck.

Change-Id: I87c40dc94035345add1162e5029e5128= 8811cb09
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Ac= ked-by: Gert Doering <gert@...1296...>
Gerrit URL: https://gerrit.= openvpn.net/c/openvpn/+/1615
Message-Id: <20260419133947.21215-1-gert= @...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1466...= urceforge.net/msg36662.html
Signed-off-by: Gert Doering <gert@...1726...= ...>
---
M src/tapctl/error.h
M src/tapctl/main.c
2 files ch= anged, 2 insertions(+), 11 deletions(-)

diff --git a/src/tapctl/error.h b/src/tapctl/error.h
ind= ex 9632b2f..f9586dc 100644
--- a/src/tapctl/error.h<= br>+++ b/src/tapctl/error.h
@@ -109,11 +109,11 @@

return (level & M_DEBUG_LEVEL) <=3D x_debug_level;=
}

-/** Return true if flags represent and enabled, not muted l= og level */
+/** Retu= rn true if flags represent */
static inline bool msg_test(unsigned int flags)
{
- return check_debug_level(flags) &= & dont_mute(flags);
+ return check_debug_level(flags);
}

#endif /* ifndef ERROR_H */
diff --git = a/src/tapctl/main.c b/src/tapctl/main.c
index 1d047dd..6a4a= 240 100644
--- a/src/tapctl/main.c
+++ b/sr= c/tapctl/main.c
@@ -686,15 +686,6 @@
}


-bool
-dont_m= ute(unsigned int flags)
-{
- UNREFERENCED_P= ARAMETER(flags);
-
- return true;-}
-
change 1615. To unsubscribe, or for help wri= ting mail filters, visit settings.

=
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I87c40dc94035345add1162e5029= e51288811cb09
Gerrit-Change-Number: 1615
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --YtSzIrXOFms=--