From: Vasily Averin Subject: Re: [PATCH 1/9] memcg: accounting for allocations called with disabled BH Date: Wed, 10 Mar 2021 12:21:38 +0300 Message-ID: <32fab450-c62b-4f71-4d8e-4e956bc37cdd@virtuozzo.com> References: <18a0ae77-89ff-2679-ab19-378e38ce2be2@virtuozzo.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A/fNXpTuxABcaNN8chdZ8GWl7T6M35RohMwWnBTGqKk=; b=Cfmny1WRBpD8/ahSv2CkA86TuXy+cNk728//sUzoC1FcHzCfHiI41QKry+9xnVRuGxV81S4+w5CmFgsKAlUR/kccxcfRshHCVZLxFJ5pdOe+8YRcinSPZ0TWriBZizGTRIrxoKjNfb8HlfKIBQ2O6fzo5+pTxk2Y4uEMCMEc+Eg= In-Reply-To: Content-Language: en-US List-ID: Content-Type: text/plain; charset="us-ascii" To: Roman Gushchin , Shakeel Butt Cc: Cgroups , Linux MM , Johannes Weiner , Michal Hocko , Vladimir Davydov On 3/9/21 11:18 PM, Roman Gushchin wrote: > On Tue, Mar 09, 2021 at 11:39:41AM -0800, Shakeel Butt wrote: >> On Tue, Mar 9, 2021 at 12:04 AM Vasily Averin wrote: >>> >>> in_interrupt() check in memcg_kmem_bypass() is incorrect because >>> it does not allow to account memory allocation called from task context >>> with disabled BH, i.e. inside spin_lock_bh()/spin_unlock_bh() sections >>> >>> Signed-off-by: Vasily Averin >> >> In that file in_interrupt() is used at other places too. Should we >> change those too? > > Yes, it seems so. Let me prepare a fix (it seems like most of them were > introduced by me). No objects from my side, just keep me informed and add me in "Reported-by:" in your patches. Thank you, Vasily Averin