Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F306CA34 for ; Wed, 12 Jun 2024 09:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718184259; cv=none; b=JQwT4w8ac2bjWMTKNxF6CzhXFgup2bZudCnY3u/QV98DWGh7cMSXZUihgOpyRkq3Zx9OG1SWZM/NzsX8cUIXVueLPn7haCeGVTbApAtXMVmDRlDI+Bqupzp5P3XNYqo/eL2ZFVhckS04g2ZEA+Bj2toJ466zLxezLViFjz9UeEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718184259; c=relaxed/simple; bh=ytPB7o3sNt3WkmYesD0N7871LrdUiavykFcGUZgCd3s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cVz6vT4hOjzMdG6hBqkI/eCsVFXl1GHvfc4GIxkhoWjCY99y52WOgxt4gBLOxedUIPoTpFiE1CtSyFSwl3FGi0tvtBdz7kMs6x2JlHOMuqxx0pj0lnacXeaHExx8FYSaSi3eXUar5EUYwplAkIm+tpWocTJtWtEumUmzDXb1r5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LwAbxx58; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LwAbxx58" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718184258; x=1749720258; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ytPB7o3sNt3WkmYesD0N7871LrdUiavykFcGUZgCd3s=; b=LwAbxx58BVRv149Y/7ebD1qaO9eLGAzu5cmRKCK90tKsMad2U+sdYT4z W0cm+NqpkIq88D1yRGhF7R0f6Vez1IDtqWXH9FY4hY8M1NwFe1ZfYKkom 8DBI3nqwTExARrcRzD+xeSqaxecIjAlenEsVTfSfw5S1+83XZnY7bQb2v 63gHG+NE9MTWuZZFwV1+Lj8kjQnWXSHyFA20Tq/sEGi533eZSK/Cr/yFO +u3cxJMW2NnaxlyLb76doOkqaOsVpYycRZV4X9xU96oAMI34uBBUWc5EX P7P7QUbNLd0HTqP90jJ89sRuQx7JdvuVHxkEVb6Ugr/545xF1NhZRDimE A==; X-CSE-ConnectionGUID: 6dy+f7ocRyiuyK844BH4xg== X-CSE-MsgGUID: GKtiV2EaRX2n9gLRz4GSKw== X-IronPort-AV: E=McAfee;i="6600,9927,11100"; a="14732142" X-IronPort-AV: E=Sophos;i="6.08,232,1712646000"; d="scan'208";a="14732142" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 02:24:17 -0700 X-CSE-ConnectionGUID: SWx+sngdQ7iyekGkwC68SA== X-CSE-MsgGUID: bBfcdBtsTui+Tf8O3iArZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,232,1712646000"; d="scan'208";a="39839863" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.227.51]) ([10.124.227.51]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 02:24:11 -0700 Message-ID: <3315d483-cdc0-44cd-af56-9fee612de054@intel.com> Date: Wed, 12 Jun 2024 17:24:08 +0800 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 18/65] i386/tdx: Make Intel-PT unsupported for TD guest To: "Duan, Zhenzhong" , Paolo Bonzini , David Hildenbrand , Igor Mammedov , Eduardo Habkost , Marcel Apfelbaum , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Yanan Wang , "Michael S. Tsirkin" , Richard Henderson , Ani Sinha , Peter Xu , Cornelia Huck , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eric Blake , Markus Armbruster , Marcelo Tosatti Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, Michael Roth , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang References: <20240229063726.610065-1-xiaoyao.li@intel.com> <20240229063726.610065-19-xiaoyao.li@intel.com> <59fec569-95e1-9024-77fb-b6d2f89b3951@intel.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <59fec569-95e1-9024-77fb-b6d2f89b3951@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/31/2024 5:27 PM, Duan, Zhenzhong wrote: > > On 2/29/2024 2:36 PM, Xiaoyao Li wrote: >> Due to the fact that Intel-PT virtualization support has been broken in >> QEMU since Sapphire Rapids generation[1], below warning is triggered when >> luanching TD guest: >> >>    warning: host doesn't support requested feature: >> CPUID.07H:EBX.intel-pt [bit 25] >> >> Before Intel-pt is fixed in QEMU, just make Intel-PT unsupported for TD >> guest, to avoid the confusing warning. > > I guess normal guest has same issue. yeah, just the bug referenced by [1] > Thanks > > Zhenzhong > >> >> [1] >> https://lore.kernel.org/qemu-devel/20230531084311.3807277-1-xiaoyao.li@intel.com/ >> >> Signed-off-by: Xiaoyao Li >> --- >> Changes in v4: >>   - newly added patch; >> --- >>   target/i386/kvm/tdx.c | 5 +++++ >>   1 file changed, 5 insertions(+) >> >> diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c >> index 85d96140b450..239170142e4f 100644 >> --- a/target/i386/kvm/tdx.c >> +++ b/target/i386/kvm/tdx.c >> @@ -292,6 +292,11 @@ void tdx_get_supported_cpuid(uint32_t function, >> uint32_t index, int reg, >>       if (function == 1 && reg == R_ECX && !enable_cpu_pm) { >>           *ret &= ~CPUID_EXT_MONITOR; >>       } >> + >> +    /* QEMU Intel-pt support is broken, don't advertise Intel-PT */ >> +    if (function == 7 && reg == R_EBX) { >> +        *ret &= ~CPUID_7_0_EBX_INTEL_PT; >> +    } >>   } >>   enum tdx_ioctl_level{