From: "flichtenheld (Code Review)" Date: Wed, 24 Apr 2024 12:13:13 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, reynir@...2756... Message-ID: <3350fb9669a06cf312c46d1af82530fefe308b72-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="wM5Bg5lGcug="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Only schedule_exit() once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: reynir Cc: plaisthos , openvpn-devel --wM5Bg5lGcug= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, reynir. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/555?usp=3Demail ) Change subject: Only schedule_exit() once ...................................................................... Patch Set 2: Code-Review+2 (3 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/555/comment/090e8b75_da780d6c : PS1, Line 523: * only ever seems to be SIGTERM anyway. */ > I also considered dropping the `signal` argument as it is currently alway= s `SIGTERM` at all call sit [=E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/555/comment/01a64bab_9f4236b8 : PS1, Line 525: return; > You might want to consider changing the function to return a boolean to i= ndicate whether it did anyt [=E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/555/comment/123d7f7a_5b2bfd6a : PS1, Line 530: event_timeout_init(&c->c2.scheduled_exit, n_seconds, now= ); > It is always `c->options.scheduled_exit_interval` which is always 5 at th= e moment. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661 Gerrit-Change-Number: 555 Gerrit-PatchSet: 2 Gerrit-Owner: reynir Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: reynir Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: reynir Gerrit-Comment-Date: Wed, 24 Apr 2024 12:13:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: reynir Gerrit-MessageType: comment --wM5Bg5lGcug= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos, reynir.

Patch set 2:Code-Review +2=

Vi= ew Change

3 comments:

  • File src/openvpn/forward.c:

    =
    • Patch Set #1, Line 523= : * only ever seem= s to be SIGTERM anyway. */

      I also considered dropping= the `signal` argument as it is currently always `SIGTERM` at all call sit = [=E2=80=A6]

      Done

    • Patch Set #1, Line 525: return;

      = You might want to consider changing the function to return a boolean to ind= icate whether it did anyt [=E2=80=A6]

      Done

    • Patch Set #1, L= ine 530: event_time= out_init(&c->c2.scheduled_exit, n_seconds, now);

      It is always `c->options.scheduled_exit_interval` which is always 5 a= t the moment.

      Done

To view, visit change 555. To unsub= scribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9457f005f4ba970502e6b667d9d= c4299a588d661
Gerrit-Change-Number: 555
Gerrit-PatchSet: 2
Gerrit-Owner: reynir <reynir@...2756...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: reynir <reynir@...2756...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: reynir <reynir@...2756...= >
Gerrit-Comment-Date: Wed, 24 Apr 2024 12:13:13= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: reynir <reynir@...2800...= ...>
Gerrit-MessageType: comment
--wM5Bg5lGcug=--