From: Stefan Roese Date: Wed, 3 Apr 2019 14:22:45 +0200 Subject: [U-Boot] [PATCH 10/13 v3] Makefile: Add Kconfig option CONFIG_SPL_IMAGE to select the SPL binary In-Reply-To: <9b89ce68-e72d-cfdb-fd89-97341d6be4a9@denx.de> References: <20190402085727.14552-1-sr@denx.de> <20190402085727.14552-10-sr@denx.de> <26a6b0c3-3a23-b572-7f21-ce719b3137d9@microchip.com> <9b89ce68-e72d-cfdb-fd89-97341d6be4a9@denx.de> Message-ID: <3359a2ff-8ea8-4b33-e12b-ecf247eb7549@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Eugen, On 03.04.19 13:21, Stefan Roese wrote: >>> If I try to just use menuconfig and change this value to something else, >>> build fails. The purpose of this Kconfig is to name the SPL filename as >>> per the config's desire ? >>> >>> Or in fact is "which binary file to use to make the Combined SPL+U-BOOT >>> mega image" ? >> >> Ok, the commit message explains it pretty well, but the Kconfig help is >> totally different... hence the confusion sorry. >> So we need to either make a choice submenu in this Kconfig : either this >> or that; or, do exactly what the Kconfig says: rename the output binary >> into the value of this Kconfig. >> >> Does this make sense ? > > You are suggesting to add this SPL_IMAGE as choice instead of its > current implementation? That might be better, yes. Let me look into > this... I did look into this and I would prefer to stay with the original implementation of the defaults. Changing this into a Kconfig choice makes this a bit more complex in the Kconfig. Additionally and even more important (for my personal feeling), the original implementation is more in line with the BUILD_TARGET implemenation directly below this new implementation. So if you don't object, I would like to send a new version with the original implementation but with a "better" (more correct) description in Kconfig. What do you think? Thanks, Stefan